Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Stefano Zacchiroli
On Wed, Nov 11, 2009 at 10:36:55PM +0100, Mehdi Dogguy wrote: > I already fixed it in my local copy. I'll push soon. Thanks! -- Stefano Zacchiroli -o- PhD in Computer Science \ PostDoc @ Univ. Paris 7 z...@{upsilon.cc,pps.jussieu.fr,debian.org} -<>- http://upsilon.cc/zack/ Dietro un grande uomo

Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Mehdi Dogguy
Stefano Zacchiroli wrote: > > No problem, I remember discussing that on IRC, but it is of absolutely > there importance (I can be of course wrong!), the important thing is > fixing it :-) > I already fixed it in my local copy. I'll push soon. > FWIW, I've just discovered an even more annoying s

Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Stefano Zacchiroli
On Wed, Nov 11, 2009 at 10:09:37PM +0100, Mehdi Dogguy wrote: > > The thing that the need to leave a heading whitespace is not documented, > Is it a matter of documentation then? :p No, it is a matter of "sane default" :-P > BTW, I don't remember having discussed this issue with you, ever. No pr

Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Stefano Zacchiroli
On Wed, Nov 11, 2009 at 08:45:06PM +0100, Mehdi Dogguy wrote: > The spaces around options are present on purpose to be *sure* that > ocamlfind has to be called. You can relax the regexp and look only for > the option name if you like it that way. It's a matter of taste. Adding > a space at the begi

Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Mehdi Dogguy
Stefano Zacchiroli wrote: > > IMO it is not a matter on taste, in the sense that: once you say to > _anyone_ to write command line options / flags in a file, that anyone > will most likely write them without leaving a heading white space. That > would make dh_ocamldoc unable to understand the flag

Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Mehdi Dogguy
severity 555794 normal thanks Stefano Zacchiroli wrote: > Package: dh-ocaml > Version: 0.9.3 > Severity: important IMHO, severity important looks a bit too much for such issues. > The regexp to detect ocamldoc global flags looks like this: > > if $ocamldoc_flags_global =~ / -package | -predic

Bug#555794: dh_ocamldoc: wrong regexp to detect ocamldoc flags

2009-11-11 Thread Stefano Zacchiroli
Package: dh-ocaml Version: 0.9.3 Severity: important File: /usr/bin/dh_ocamldoc The regexp to detect ocamldoc global flags looks like this: if $ocamldoc_flags_global =~ / -package | -predicates | -syntax | -ppopt /; The spaces around the various alternatives should not be there and inhibit det