Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-17 Thread Ben Hutchings
On Tue, 2010-08-17 at 21:10 +0530, Ritesh Raj Sarraf wrote: > Hello Ben, > > On Tuesday 17 Aug 2010 06:05:35 Ben Hutchings wrote: > > Please add the check for DEBUG, and test that the result works. I think > > we can live with this for now and move it into Kbuild later. > > Patch attached. Pleas

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-17 Thread Ritesh Raj Sarraf
Hello Ben, On Tuesday 17 Aug 2010 06:05:35 Ben Hutchings wrote: > Please add the check for DEBUG, and test that the result works. I think > we can live with this for now and move it into Kbuild later. Patch attached. Please review and commit. Added the if condition to check for DEBUG. Built the

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-16 Thread Ben Hutchings
On Mon, 2010-08-16 at 19:06 +0530, Ritesh Raj Sarraf wrote: [...] > So what has been finalized ? > > Like Kurt already mentioned, objcopy does need to read the file. > I can put the conditional if DEBUG in the initial patch that I sent. Please add the check for DEBUG, and test that the result wor

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-16 Thread Ritesh Raj Sarraf
Hello Bastian et al, On Saturday 14 Aug 2010 15:46:33 Kurt Roeckx wrote: > On Sat, Aug 14, 2010 at 09:58:24AM +0200, Bastian Blank wrote: > > On Sat, Aug 14, 2010 at 04:17:27AM +0100, Ben Hutchings wrote: > > > [I also wonder why we are copying the unstripped modules into > > > /usr/lib/debug and

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-14 Thread Ritesh Raj Sarraf
On Saturday 14 Aug 2010 02:46:43 Kurt Roeckx wrote: > Why did you add a build-depends on binutils? It's build-essential. > Thanks for pointing this. Yes, we don't need to add binutils. Ritesh -- Ritesh Raj Sarraf | http://people.debian.org/~rrs Debian - The Universal Operating System signatu

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-14 Thread Kurt Roeckx
On Sat, Aug 14, 2010 at 09:58:24AM +0200, Bastian Blank wrote: > On Sat, Aug 14, 2010 at 04:17:27AM +0100, Ben Hutchings wrote: > > [I also wonder why we are copying the unstripped modules into > > /usr/lib/debug and not just debug info? > > Because the tools can't cope with them. > > >

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-14 Thread Ben Hutchings
On Sat, 2010-08-14 at 09:58 +0200, Bastian Blank wrote: > On Sat, Aug 14, 2010 at 04:17:27AM +0100, Ben Hutchings wrote: > > [I also wonder why we are copying the unstripped modules into > > /usr/lib/debug and not just debug info? > > Because the tools can't cope with them. OK. > >

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-14 Thread Bastian Blank
On Sat, Aug 14, 2010 at 04:17:27AM +0100, Ben Hutchings wrote: > [I also wonder why we are copying the unstripped modules into > /usr/lib/debug and not just debug info? Because the tools can't cope with them. > And shouldn't this really be > part of Kbuild

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-13 Thread Ben Hutchings
On Sat, 2010-08-14 at 02:01 +0530, Ritesh Raj Sarraf wrote: > tags 49 +patch > thanks > > Hello Bastian, > > On Tuesday 10 Aug 2010 13:35:58 Bastian Blank wrote: > > > I tried re-building the kernel image with dh_strip -k but that did not > > > help. So, how is the linux-image--dbg pack

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-13 Thread Kurt Roeckx
On Sat, Aug 14, 2010 at 02:01:02AM +0530, Ritesh Raj Sarraf wrote: > -Build-Depends: debhelper (>> 7), cpio, module-init-tools, python, lzma > [armel], libelf-dev, binutils-dev, asciidoc, xmlto > +Build-Depends: debhelper (>> 7), cpio, module-init-tools, python, lzma > [armel], libelf-dev, binuti

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-13 Thread Ritesh Raj Sarraf
tags 49 +patch thanks Hello Bastian, On Tuesday 10 Aug 2010 13:35:58 Bastian Blank wrote: > > I tried re-building the kernel image with dh_strip -k but that did not > > help. So, how is the linux-image--dbg package created ? > > debian/rules.real shows it. Thanks for pointing this out

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-10 Thread Bastian Blank
Please quote correctly. On Tue, Aug 10, 2010 at 01:27:20PM +0530, Ritesh Raj Sarraf wrote: > I looked into dh_strip and it does seem to be doing the right thing. The kernel build does not use dh_strip, as it does not build userspace binaries. > I tried re-building the kernel image with dh_strip

Bug#555549: 555549: adding .gnu_debuglink section in kernel modules

2010-08-10 Thread Ritesh Raj Sarraf
retitle 49 adding .gnu_debuglink section in kernel modules thanks Ben, I looked into dh_strip and it does seem to be doing the right thing. sub attach_debug { my $file=shift; my $debug_path=shift; doit("objcopy", "--add-gnu-debuglink", $debug_path, $file); } attac