Erik Schanze writes:
>>
>> http://cvs.fedoraproject.org/viewvc/rpms/gif2png/devel/gif2png-overflow.patch?revision=HEAD&root=extras&view=markup
>>
>> solves the issue better.
>
> You're right. Thank you for your attention.
fwiw, I changed my patch to abort/fail when filename length exceeds a
Hi,
I am the Fedora maintainer of gif2png and think that the supplied patch
is incomplete. In main(), there is done
| - strcpy(name, argv[i]);
| + strncpy( name, argv[i], sizeof( name ) );
| ...
| strcat(name, ".gif");
which could still overflow 'name'.
2 matches
Mail list logo
