Bug#544931: another problem in the patch

2009-09-05 Thread Raphael Geissert
On Saturday 05 September 2009 21:33:23 Martín Ferrari wrote: > On Sun, Sep 6, 2009 at 00:24, Raphael Geissert wrote: > > While checking something unrelated to the last patch I found that the > > following regex triggers an il: > > > > opts=uversionmangle=sx(.?)\Gxprint("foo")xg \ > > http://sf.net/

Bug#544931: another problem in the patch

2009-09-05 Thread Martín Ferrari
On Sun, Sep 6, 2009 at 00:24, Raphael Geissert wrote: > Hi Martín, Adam, * > > [Martín, hope you don't bother that I'm CC'ing you] Not at all, I'm not subscribed to the bug. > While checking something unrelated to the last patch I found that the > following regex triggers an il: > > opts=uversion

Bug#544931: another problem in the patch

2009-09-05 Thread Raphael Geissert
Hi Martín, Adam, * [Martín, hope you don't bother that I'm CC'ing you] While checking something unrelated to the last patch I found that the following regex triggers an il: opts=uversionmangle=sx(.?)\Gxprint("foo")xg \ http://sf.net/kcheckgmail/kcheckgmail-(.+)\.tar\.gz Other than that and #54

Bug#544931: another problem in the patch

2009-09-05 Thread Adam D. Barratt
On Sat, 2009-09-05 at 18:55 +0100, Adam D. Barratt wrote: > On Sat, 2009-09-05 at 18:35 +0200, Martín Ferrari wrote: > > See the patch below, or refer to revision 748 of > > svn://svn.debian.org/svn/pet/trunk/PET/Watch.pm [...] > I've included an updated patch below. PET SVN has also been updated

Bug#544931: another problem in the patch

2009-09-05 Thread Adam D. Barratt
On Sat, 2009-09-05 at 18:35 +0200, Martín Ferrari wrote: > On Sat, Sep 5, 2009 at 15:36, Martín Ferrari wrote: > > > $ perl -MPET::Watch -e '$r = shift; $s = shift; > > PET::Watch::safe_replace($s, $r); print "$s\n"' 's/()/./g' foo > > foo > > This was a mistake, I didn't call the function proper

Bug#544931: another problem in the patch

2009-09-05 Thread Martín Ferrari
On Sat, Sep 5, 2009 at 15:36, Martín Ferrari wrote: > $ perl -MPET::Watch -e '$r = shift; $s = shift; > PET::Watch::safe_replace($s, $r); print "$s\n"' 's/()/./g' foo > foo This was a mistake, I didn't call the function properly. Raphael's patch makes this loop forever! $ time perl -MPET::Watch

Bug#544931: another problem in the patch

2009-09-05 Thread Martín Ferrari
Hi Raphael, et al. I've been also working on trying to produce a fix for this issue, but I was stuck with dealing with zero-width matches, which are quite tricky to handle. I just tried and your patch doesn't handle this, take for example s/()/./g: $ perl -MPET::Watch -e '$r = shift; $s = shift;