Bug#543722: ikiwiki: htmltidy plugin discards all content if tidy is not installed.

2009-08-27 Thread Joey Hess
Hilko Bengen wrote: > I think that throwing away aggregated content if tidy couldn't cope with > it is not right either. Such behavior annoys users a great deal and it > is likely to confuse them because the "bug" seems unreproducible due to > varying external inputs over which the user has no cont

Bug#543722: ikiwiki: htmltidy plugin discards all content if tidy is not installed.

2009-08-26 Thread Hilko Bengen
Joey Hess writes: > We don't know tidy isn't installed, it might have failed to tidy the > html (can happen for very screwy html), or therotectically, have > crashed. So returning the untidied html is not right -- the site could > be relying on htmltidy to eg, close all unclosed tags in aggregate

Bug#543722: ikiwiki: htmltidy plugin discards all content if tidy is not installed.

2009-08-26 Thread Joey Hess
Hilko Bengen wrote: > If tidy is not installed, the process created by "open2" returns no > data. This case seems to handled by IkiWiki::Plugin::htmltidy::sanitize, > but in a quite user-unfriendly way -- all content that has been rendered > so far is discarded. > > return "" if $sigpipe || !

Bug#543722: ikiwiki: htmltidy plugin discards all content if tidy is not installed.

2009-08-26 Thread Hilko Bengen
Package: ikiwiki Version: 3.141592 Severity: normal If tidy is not installed, the process created by "open2" returns no data. This case seems to handled by IkiWiki::Plugin::htmltidy::sanitize, but in a quite user-unfriendly way -- all content that has been rendered so far is discarded. return