Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-30 Thread Nicholas Marriott
This is committed to CVS HEAD now and will be in the next release of fdm when I get around to it. Thanks! On Sat, Jul 25, 2009 at 08:02:46PM +0200, opter_l wrote: > As discussed here and on IRC. > > I have replaced the link() call in deliver-maildir.c by a call to a new > `safemove()' function.

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-27 Thread Nicholas Marriott
I'm going to run with this for a few days and if I don't see any problems I'll commit it, then it'll be in 1.7 when I get around to doing some more stuff on fdm. Thanks On Sat, Jul 25, 2009 at 08:02:46PM +0200, opter_l wrote: > As discussed here and on IRC. > > I have replaced the link() call

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-26 Thread Nicholas Marriott
Sorry for the delay, I was a bit busy yesterday. This looks great to me, I will give it further test, add the manual bits and commit it later on today or tomorrow. Thanks for your work! On Sat, Jul 25, 2009 at 08:02:46PM +0200, opter_l wrote: > As discussed here and on IRC. > > I have replaced

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-25 Thread opter_l
As discussed here and on IRC. I have replaced the link() call in deliver-maildir.c by a call to a new `safemove()' function. This function move a file with link() + unlink() or if it fails on EXDEV by using rename(). The patch is joined with this mail. I have tested it on AFS and ext3; the regre

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-24 Thread Nicholas Marriott
Hi > > Saying that, I don't see a reason not to make this work for people who > are > > prepared to accept the risk or who know for sure they are delivering mail > > sequentially. With fdm, you will want to set queue-high/queue-low to 1, > and > > perhaps parallel-accounts to 1 if you have multipl

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-24 Thread opter_l
On Thu, 23 Jul 2009 23:38:08 +0100, Nicholas Marriott wrote: > Hi > > Thanks for the report. > > This isn't really an fdm bug per se, the point of maildirs is to allow > delivery > to happen safely without locking. On AFS you are probably best using mboxes > which have flaws but can be locked a

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-23 Thread Nicholas Marriott
Hi Thanks for the report. This isn't really an fdm bug per se, the point of maildirs is to allow delivery to happen safely without locking. On AFS you are probably best using mboxes which have flaws but can be locked atomically. Saying that, I don't see a reason not to make this work for people

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-23 Thread Frank Terbeck
[ Ccing the fdm-users mailing list. Please reply to all addresses in ] [ To: and Cc: in order to keep all involved parties and the debian ] [ BTS in the loop. ] A new bug report via the debian BTS, which includes a suggestion for a fix. The refe

Bug#538194: fdm doesn't handle EXDEV when linking files.

2009-07-23 Thread Louis Opter
Package: fdm Version: 1.5-3 Severity: important Tags: patch Dear maintainer, link() fails with EXDEV when you try to link files accross file systems. On the AFS file system, this also occurs between directories : http://docs.openafs.org/AdminGuide/ch02.html#HDRWQ32 This special case breaks fdm