Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-14 Thread Sebastian Andrzej Siewior
* Asheesh Laroia | 2008-12-14 12:14:30 [-0800]: > 20:47 droncho New news from jacktimeline: Changeset [3205]: Fix > alpha compilation error. Debian Bug #508114. Yup, looks like upstream took my patch. That one is tiny little different to what you just posted but it should be fine. > -- Ashees

Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-14 Thread Asheesh Laroia
On Sun, 14 Dec 2008, Asheesh Laroia wrote: On Sat, 13 Dec 2008, Sebastian Andrzej Siewior wrote: So you should check for one of them IMHO. So in that case I was in the wrong line an passing va_list to next function is valid (I was wondering here a little...). Got it. So this patch fixes the

Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-14 Thread Sebastian Andrzej Siewior
* Asheesh Laroia | 2008-12-14 11:31:48 [-0800]: > Upstream seems slow to answer if the patch is good, even for the previous > patch which was not. So let's see if we can sanity-check this without > upstream's help. I've signed up to their mailing list and sent then the following email: --- Th

Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-14 Thread Asheesh Laroia
On Sat, 13 Dec 2008, Sebastian Andrzej Siewior wrote: So you should check for one of them IMHO. So in that case I was in the wrong line an passing va_list to next function is valid (I was wondering here a little...). Got it. So this patch fixes the FTBFS on alpha. Now that it compiles, the s

Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-13 Thread Asheesh Laroia
On Sat, 13 Dec 2008, Sebastian Andrzej Siewior wrote: * Asheesh Laroia | 2008-12-13 06:59:46 [-0800]: Hi. Hello, Is it adequate, do you think, to test if &ap == NULL? I am falling asleep so take it as a senseless suggestion. This is not what you want. You should not access va_list directl

Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-13 Thread Sebastian Andrzej Siewior
* Asheesh Laroia | 2008-12-13 06:59:46 [-0800]: > Hi. Hello, > Is it adequate, do you think, to test if &ap == NULL? I am falling asleep > so take it as a senseless suggestion. This is not what you want. You should not access va_list directly, you have to use helpers like va_{start|end|arg|copy

Bug#508114: jack-a-c-k: Patch not a total fix

2008-12-13 Thread Asheesh Laroia
Hi. The sun is rising where I am, and I am tired, so I will be a little brief. I tested your alpha patch, and it does not fix all the problems. Line 972 of client.c still has the same problem for me: if(ap) is still a va_list that is being treated improperly. I'm CC:ing my AM (Steffen) so h