Bug#498033: Fix for xzgv scaling crash

2008-09-09 Thread Theodore Tso
On Wed, Sep 10, 2008 at 12:41:19AM +1000, Trent W. Buck wrote: > > If xzgv is given a list of files it should just display the files > > right away, and not give you an empty image. [...] So I'm a bit > > confused how you are running into this situation given the scenario > > you have described. >

Bug#498033: Fix for xzgv scaling crash

2008-09-09 Thread Trent W. Buck
On Tue, Sep 09, 2008 at 10:15:59AM -0400, Theodore Tso wrote: > On Tue, Sep 09, 2008 at 11:32:25PM +1000, Trent W. Buck wrote: > > On Tue, Sep 09, 2008 at 08:59:02AM -0400, Theodore Tso wrote: > > > Also, since this bug report falls into the "Doctor, doctor, it hurts > > > when I do that --- then d

Bug#498033: Fix for xzgv scaling crash

2008-09-09 Thread Theodore Tso
On Tue, Sep 09, 2008 at 11:32:25PM +1000, Trent W. Buck wrote: > On Tue, Sep 09, 2008 at 08:59:02AM -0400, Theodore Tso wrote: > > Also, since this bug report falls into the "Doctor, doctor, it hurts > > when I do that --- then don't that!", > > The situation is that I do this: > > xzgv `mainli

Bug#498033: Fix for xzgv scaling crash

2008-09-09 Thread Trent W. Buck
On Tue, Sep 09, 2008 at 08:59:02AM -0400, Theodore Tso wrote: > Also, since this bug report falls into the "Doctor, doctor, it hurts > when I do that --- then don't that!", The situation is that I do this: xzgv `mainline -v -c @ | grep Saved | cut -d\" -f 2` ...which downloads new webcomics, a

Bug#498033: Fix for xzgv scaling crash

2008-09-09 Thread Theodore Tso
tags 498033 +pending severity 498033 minor thanks Andrian, Thanks for the proposed patch! Actually, you want to check to see if theimage is NULL before the recursion check; otherwise, the in_routine variable gets left set non-zero, which disables the command for the rest of the xzgv run. Also,

Bug#498033: Fix for xzgv scaling crash

2008-09-09 Thread Adrian Knoth
Hi! I can confirm the bug. It's a null pointer dereference: if theimage is NULL, the check in main.c:1724 segfaults. The attached patch corrects the problem. HTH Starting program: /tmp/xzgv-0.9+svn40/src/xzgv [Thread debugging using libthread_db enabled] [New Thread 0x7fa7102f4770 (LWP 9057)]