Bug#497489: checkbashisms: multiple patches

2010-05-26 Thread Raphael Geissert
Hi James, On Tuesday 25 May 2010 17:55:53 James Vega wrote: > I noticed via one of your other patches what looks to be a bad check for file > redirection. > > qr'(<\&|>\&)\s*((-|\d+)[^\s;|)}`&]|[^-\d\s]+)' => > qword 2\>&1>, > > This will have false positiv

Bug#497489: checkbashisms: multiple patches

2010-05-25 Thread James Vega
On Tue, May 25, 2010 at 10:45:47AM -0500, Raphael Geissert wrote: > On 25 May 2010 10:27, James Vega wrote: > > On Tue, May 25, 2010 at 11:14 AM, Raphael Geissert > > wrote: > >> I couldn't find another commit fixing the bug you found, so I'm going > >> to to include it in my next batch of chang

Bug#497489: checkbashisms: multiple patches

2010-05-25 Thread Raphael Geissert
On 25 May 2010 10:27, James Vega wrote: > On Tue, May 25, 2010 at 11:14 AM, Raphael Geissert > wrote: >> I couldn't find another commit fixing the bug you found, so I'm going >> to to include it in my next batch of changes (which I'm testing >> against the archive as I type.) > > I included it i

Bug#497489: checkbashisms: multiple patches

2010-05-25 Thread James Vega
On Tue, May 25, 2010 at 11:14 AM, Raphael Geissert wrote: > Hi James, > > On 25 May 2010 00:10, James Vega wrote: >> On Thu, May 20, 2010 at 09:19:07PM -0500, Raphael Geissert wrote: >>> Attached mbox includes patches for the corresponding bug reports among other >>> changes (bug fixes, new check

Bug#497489: checkbashisms: multiple patches

2010-05-25 Thread Raphael Geissert
Hi James, On 25 May 2010 00:10, James Vega wrote: > On Thu, May 20, 2010 at 09:19:07PM -0500, Raphael Geissert wrote: >> Attached mbox includes patches for the corresponding bug reports among other >> changes (bug fixes, new checks.) > > Thanks for the patches.  I've applied all of them, with one

Bug#497489: checkbashisms: multiple patches

2010-05-24 Thread James Vega
On Thu, May 20, 2010 at 09:19:07PM -0500, Raphael Geissert wrote: > Attached mbox includes patches for the corresponding bug reports among other > changes (bug fixes, new checks.) Thanks for the patches. I've applied all of them, with one slight change to the one below. diff --git a/scripts/che

Bug#497489: checkbashisms: multiple patches

2010-05-20 Thread Raphael Geissert
tag 535368 patch tag 497489 patch tag 572006 patch tag 531327 patch thanks Hi, Attached mbox includes patches for the corresponding bug reports among other changes (bug fixes, new checks.) The changes were tested against a regressions testsuite I wrote and the /bin/sh scripts of the entire arc