Bug#448437: unp: Incomplete filename escaping

2008-05-17 Thread Thijs Kinkhorst
On Monday 29 October 2007 23:02, Eduard Bloch wrote: > Yes, yes, but that's more complicated. I just tried to rewrite this > script in "good Perl" and it's a lot more work to do it right. > > Security team: please consider using the attached patch. It is a quick > fix which uses libstring-shellquot

Bug#448437: unp: Incomplete filename escaping

2008-04-23 Thread Moritz Muehlenhoff
severity 448437 grave thanks Erich Schubert wrote: > Package: unp > Version: 1.0.12 > Severity: important > Tags: security > > unp doesn't escape filenames properly. Try this: > > touch empty > zip \`ls\`.zip empty > unp \`ls\`.zip > > and it will give you a directory listing. > > This means t

Bug#448437: unp: Incomplete filename escaping

2007-12-15 Thread Eduard Bloch
#include * Florian Weimer [Mon, Oct 29 2007, 11:37:18PM]: > * Eduard Bloch: > > > Security team: please consider using the attached patch. It is a quick > > fix which uses libstring-shellquote-perl on @ARGV instead of the stupid > > doublequote protection before. > > I'd rather like to avoid int

Bug#448437: unp: Incomplete filename escaping

2007-10-29 Thread Florian Weimer
* Eduard Bloch: > Security team: please consider using the attached patch. It is a quick > fix which uses libstring-shellquote-perl on @ARGV instead of the stupid > doublequote protection before. I'd rather like to avoid introducing a new dependency in a security update, but it's probably a bit d

Bug#448437: unp: Incomplete filename escaping

2007-10-29 Thread Eduard Bloch
#include * Florian Weimer [Mon, Oct 29 2007, 03:00:52PM]: > * Erich Schubert: > > > unp doesn't escape filenames properly. Try this: > > > > touch empty > > zip \`ls\`.zip empty > > unp \`ls\`.zip > > > > and it will give you a directory listing. > > This should be fixed not by escaping file nam

Bug#448437: unp: Incomplete filename escaping

2007-10-29 Thread Eduard Bloch
#include * Erich Schubert [Mon, Oct 29 2007, 04:09:13PM]: > Hi, > > This should be fixed not by escaping file names, but by using Perl's > > "system" function which takes a list of arguments (and does not invoke > > the shell). > > Yeah, sorry, that was what I meant basically... right now, unp do

Bug#448437: unp: Incomplete filename escaping

2007-10-29 Thread Erich Schubert
Hi, > This should be fixed not by escaping file names, but by using Perl's > "system" function which takes a list of arguments (and does not invoke > the shell). Yeah, sorry, that was what I meant basically... right now, unp does something like \"$filename\" which is really naive... One of the thi

Bug#448437: unp: Incomplete filename escaping

2007-10-29 Thread Florian Weimer
* Erich Schubert: > unp doesn't escape filenames properly. Try this: > > touch empty > zip \`ls\`.zip empty > unp \`ls\`.zip > > and it will give you a directory listing. This should be fixed not by escaping file names, but by using Perl's "system" function which takes a list of arguments (and do

Bug#448437: unp: Incomplete filename escaping

2007-10-28 Thread Erich Schubert
Package: unp Version: 1.0.12 Severity: important Tags: security unp doesn't escape filenames properly. Try this: touch empty zip \`ls\`.zip empty unp \`ls\`.zip and it will give you a directory listing. This means that any application using 'unp' for a generic decompression utility might be vul