Bug#445549: 24_home_dir_fakeroot seems to leak memory

2007-10-07 Thread Loïc Minier
On Sun, Oct 07, 2007, Josselin Mouette wrote: > Or maybe what you mean is that it should be freed by gnome_vfs_shutdown. > I'll change the patch to that effect. I don't know whether gnome_vfs_shutdown() would be the place to free, but perhaps the g_strdup()s can be saved altogether in gnome_vfs

Bug#445549: 24_home_dir_fakeroot seems to leak memory

2007-10-07 Thread Josselin Mouette
Le dimanche 07 octobre 2007 à 12:17 +0200, Loïc Minier a écrit : > On Sun, Oct 07, 2007, Josselin Mouette wrote: > > Or maybe what you mean is that it should be freed by gnome_vfs_shutdown. > > I'll change the patch to that effect. > > I don't know whether gnome_vfs_shutdown() would be the place

Bug#445549: 24_home_dir_fakeroot seems to leak memory

2007-10-07 Thread Josselin Mouette
Le dimanche 07 octobre 2007 à 11:28 +0200, Loïc Minier a écrit : > On Sat, Oct 06, 2007, Josselin Mouette wrote: > > It shouldn't, as it is a static variable, so it should retain its same > > value between calls. > > Why shouldn't it be freed? This will probably give errors within > valgrind wh

Bug#445549: 24_home_dir_fakeroot seems to leak memory

2007-10-07 Thread Loïc Minier
On Sat, Oct 06, 2007, Josselin Mouette wrote: > It shouldn't, as it is a static variable, so it should retain its same > value between calls. Why shouldn't it be freed? This will probably give errors within valgrind when tracing any program using gnome-vfs. -- Loïc Minier

Bug#445549: 24_home_dir_fakeroot seems to leak memory

2007-10-06 Thread Josselin Mouette
Le samedi 06 octobre 2007 à 20:58 +0200, Loïc Minier a écrit : > Package: gnome-vfs2 > Version: 1:2.20.0-2 > Severity: normal > > Hi, > > While reading 24_home_dir_fakeroot, it came to my attention that it > seems to leak memory: g_get_home_dir() returns a const gchar that one > doesn'

Bug#445549: 24_home_dir_fakeroot seems to leak memory

2007-10-06 Thread Loïc Minier
Package: gnome-vfs2 Version: 1:2.20.0-2 Severity: normal Hi, While reading 24_home_dir_fakeroot, it came to my attention that it seems to leak memory: g_get_home_dir() returns a const gchar that one doesn't have to g_free(), but gnome_vfs_get_home_dir() g_strdup()s it or g_strdup()s g