Hi,
* Loïc Minier <[EMAIL PROTECTED]> [2007-02-11 21:04]:
> On Sun, Feb 11, 2007, Nico Golde wrote:
> > - return 1;
> > + return -1;
>
> Not sure about -1.
1 means success on VMS for example, just thought -1 is more
portable. But you can also consider to return EXIT_FAILURE
On Sun, Feb 11, 2007, Nico Golde wrote:
> > Could you send the remaining fixes as diff -w patches directly to
> > upstream? I can forward them if you prefer so.
> Feel free to forward :)
Can you please send them as diff -w to remove the indentation changes?
--
Loïc Minier <[EMAIL PROTECTED]>
Hi,
On Sun, Feb 11, 2007, Nico Golde wrote:
> -fd = open(filename, O_RDWR);
> + if((fd = open(filename, O_RDWR))<0){
Ok, one check for open().
> - key = atoi(argv[1]);
> + key = strtol(argv[1], NULL, 10);
Ok.
> - return
Package: acpi-support
Version: 0.90-3
Severity: wishlist
Tags: patch
Hi,
I created some patches to simplify the scripts in
acpi-support. Feel free to include.
Kind regards
Nico
-- System Information:
Debian Release: 4.0
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i6
4 matches
Mail list logo
