Bug#386752: cdebconf-gtk-udeb: Probably not enough memory allocated for string

2006-09-10 Thread Attilio Fiandrotti
Frans Pop wrote: On Sunday 10 September 2006 10:44, Attilio Fiandrotti wrote: There are a couple of places in the GTK frontend where i check for GTK version, and this is because i once used to compile it against GTK 2.8/2.9 while 2.0.9 was used in the d-i. Now that d-i has switched to 2.8.x,

Bug#386752: cdebconf-gtk-udeb: Probably not enough memory allocated for string

2006-09-10 Thread Frans Pop
On Sunday 10 September 2006 10:44, Attilio Fiandrotti wrote: > Aike has spotted a bug that would have been difficult to catch, in fact > this would have shown up only when booting in rescue mode and using > recent (2.8.21) GTKDFB libraries. Yes, excellent catch. > There are a couple of places in

Bug#386752: cdebconf-gtk-udeb: Probably not enough memory allocated for string

2006-09-10 Thread Attilio Fiandrotti
Aike Reyer wrote: Frans Pop wrote: In the patch it would probably make sense to move the malloc inside the existing #if statement instead of using a separate one. I'm not sure what kind of code is to be inserted for "TODO" right after malloc(). So I kept them separate. Hmm. General quest

Bug#386752: cdebconf-gtk-udeb: Probably not enough memory allocated for string

2006-09-09 Thread Frans Pop
On Saturday 09 September 2006 23:26, Aike Reyer wrote: > I had a look at frontend/gtk/gtk.c and think that in > expose_event_callback() the argument to malloc() (line 244) is to > small. In the following line the sprintf() does not only use "" > but "". So I suppose there > should be room for 34 ch

Bug#386752: cdebconf-gtk-udeb: Probably not enough memory allocated for string

2006-09-09 Thread Aike Reyer
Frans Pop wrote: > In the patch it would probably make sense to move the malloc inside the > existing #if statement instead of using a separate one. I'm not sure what kind of code is to be inserted for "TODO" right after malloc(). So I kept them separate. > Hmm. General question... > How does G

Bug#386752: cdebconf-gtk-udeb: Probably not enough memory allocated for string

2006-09-09 Thread Aike Reyer
Package: cdebconf-gtk-udeb Version: 0.105 Severity: normal Tags: patch I had a look at frontend/gtk/gtk.c and think that in expose_event_callback() the argument to malloc() (line 244) is to small. In the following line the sprintf() does not only use "" but "". So I suppose there should be room fo