Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Stephen Gran
This one time, at band camp, Nicolas François said: > Hello Stephen, > > On Thu, Jun 22, 2006 at 11:18:44AM +0100, Stephen Gran wrote: > > > > The bug is present in 1:4.0.16-2. Unless I'm missing something? > > Well, the bug present in 1:4.0.16-2 is a little bit different: > no mail spools are

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Nicolas François
package passwd clone 374705 -1 retitle -1 useradd do not create the mail spool (even with CREATE_MAIL_SPOOL=yes in /etc/default/useradd) severity -1 normal thanks Hello Stephen, On Thu, Jun 22, 2006 at 11:18:44AM +0100, Stephen Gran wrote: > > The bug is present in 1:4.0.16-2. Unless I'm miss

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Christian Perrier
tags 374705 fixed-upstream thanks > Above is return so instead "else" can be placed by only "}". > OK. I'll ASAP commit neccessary changes. > Probaly in comming monday will be good release 4.0.17. OK, so you will release with this fix. If that's completely sure, then I think that I will not try

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Stephen Gran
This one time, at band camp, Tomasz K??oczko said: > Dnia 22-06-2006, czw o godzinie 11:18 +0100, Stephen Gran napisa??(a): > [..] > > The bug is present in 1:4.0.16-2. Unless I'm missing something? > > Please test patch from: > http://cvs.pld.org.pl/shadow/src/useradd.c?r1=1.97&r2=1.99 [EMAIL P

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Tomasz Kłoczko
Dnia 22-06-2006, czw o godzinie 11:18 +0100, Stephen Gran napisał(a): [..] > The bug is present in 1:4.0.16-2. Unless I'm missing something? Please test patch from: http://cvs.pld.org.pl/shadow/src/useradd.c?r1=1.97&r2=1.99 kloczek -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subjec

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Stephen Gran
This one time, at band camp, Christian Perrier said: > Quoting Frans Pop ([EMAIL PROTECTED]): > > On Wednesday 21 June 2006 22:26, you wrote: > > > However, I think the issue is not present in the 4.0.16 versions > > > (according to my tests and according to the code). > > > > > > Can somebody else

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Tomasz Kłoczko
Dnia 21-06-2006, śro o godzinie 10:55 +0100, Stephen Gran napisał(a): > --- src/useradd.c~ 2006-06-21 10:51:01.0 +0100 > +++ src/useradd.c 2006-06-21 10:51:17.0 +0100 > @@ -1599,6 +1599,7 @@ > if (fd < 0) { > perror (_("Creating mai

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-22 Thread Christian Perrier
Quoting Frans Pop ([EMAIL PROTECTED]): > On Wednesday 21 June 2006 22:26, you wrote: > > However, I think the issue is not present in the 4.0.16 versions > > (according to my tests and according to the code). > > > > Can somebody else confirm? > > Confirmed. If I do a new install of unstable, the

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-21 Thread Frans Pop
On Wednesday 21 June 2006 22:26, you wrote: > However, I think the issue is not present in the 4.0.16 versions > (according to my tests and according to the code). > > Can somebody else confirm? Confirmed. If I do a new install of unstable, the mail spool dir is clean. pgpew6JqCacpj.pgp Descript

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-21 Thread Nicolas François
On Wed, Jun 21, 2006 at 09:57:04PM +0200, Nicolas François wrote: > Note: I still don't understand the Debian bug and can't reproduce it. I > will look closer later. I checked the code of 4.0.15-10. The bug is present in this version. However, I think the issue is not present in the 4.0.16 versio

Bug#374705: [Pkg-shadow-devel] Bug#374705: tentative patch

2006-06-21 Thread Nicolas François
Tomasz, On Wed, Jun 21, 2006 at 10:55:36AM +0100, Stephen Gran wrote: > Hey all, > > I think I might have found the problem. The mail spool is open()ed, and > then the fd is checked to see if there is an error (as is proper). The > problem is, the fchown/fchmod calls happen in the same logic pa