Bug#346447: gopher: FTBFS on hurd

2025-04-24 Thread João Pedro Malhado
X-Debbugs-Cc: debian-h...@lists.debian.org Hello John, On Sat, Apr 19, 2025 at 11:20:11PM -0500, John Goerzen wrote: > Every reference I have seen says it's not part of POSIX. However, Linux > and the BSDs seem to support it, so might as well just assume it will > work. If you have a patch to j

Bug#346447: gopher: FTBFS on hurd

2025-04-20 Thread João Pedro Malhado
Hello John, On Sat, Apr 19, 2025 at 11:20:11PM -0500, John Goerzen wrote: > Every reference I have seen says it's not part of POSIX. However, Linux > and the BSDs seem to support it, so might as well just assume it will > work. If you have a patch to just go that direction, I'll take it. Ok, I

Bug#346447: gopher: FTBFS on hurd

2025-04-19 Thread John Goerzen
On Wed, Apr 16 2025, João Pedro Malhado wrote: > Hello John, > > On Wed, Apr 16, 2025 at 07:32:22AM -0500, John Goerzen wrote: >> I think that would work fine on Linux and Hurd. That behavior, however, >> isn't POSIX so wouldn't be portable. Can you clarify what the problem >> with getcwd() as w

Bug#346447: gopher: FTBFS on hurd

2025-04-16 Thread João Pedro Malhado
Hello John, On Wed, Apr 16, 2025 at 07:32:22AM -0500, John Goerzen wrote: > I think that would work fine on Linux and Hurd. That behavior, however, > isn't POSIX so wouldn't be portable. Can you clarify what the problem > with getcwd() as written is on Hurd? From the description in glibc, it >

Bug#346447: gopher: FTBFS on hurd

2025-04-16 Thread John Goerzen
On Wed, Apr 16 2025, João Pedro Malhado wrote: > Hello John, > > Thank you for having a look at the patch. > I apologise as the patch is indeed a bit rushed. > > On Thu, Apr 10, 2025 at 10:15:02PM -0500, John Goerzen wrote: >> Thank you for sending this patch! I don't believe it's correct, >> how

Bug#346447: gopher: FTBFS on hurd

2025-04-16 Thread João Pedro Malhado
Hello John, Thank you for having a look at the patch. I apologise as the patch is indeed a bit rushed. On Thu, Apr 10, 2025 at 10:15:02PM -0500, John Goerzen wrote: > Thank you for sending this patch! I don't believe it's correct, > however. > > On line 202, curcwd is malloced. Overwriting it

Bug#346447: gopher: FTBFS on hurd

2025-04-10 Thread John Goerzen
Hi João, Thank you for sending this patch! I don't believe it's correct, however. On line 202, curcwd is malloced. Overwriting it prevents freeing it later, so this creates a memory leak. I suspect the later instance also has that issue. How exactly is getcwd() defined and used on Hurd? Than

Bug#346447: gopher: FTBFS on hurd

2025-04-10 Thread João Pedro Malhado
X-Debbugs-Cc: debian-h...@lists.debian.org Dear Maintainer, Would you consider the attached patch aiming to address the long standing FTBS on the Hurd, and allow Hurd users to explore gopher space? Best regards, João diff -ruNd gopher-3.0.17.4.orig/gopher/download.c gopher-3.0.17.4/gopher/downlo

Bug#346447: gopher: FTBFS on hurd-i386: Unconditional use of system limit macros

2007-01-15 Thread Michael Banck
Hi, 3.0.13 seems to have reverted parts of the Hurd patch we provided earlier; gopher/download.c now again first checks for HAVE_GETCWD and then HAVE_GET_CURRENT_DIR_NAME around lines 250 and 400. As the former is (i) defined on the Hurd but (ii) uses the undefined MAXPATHLEN macro, it FTBFS agai

Bug#346447: gopher: FTBFS on hurd-i386: Unconditional use of system limit macros

2006-01-07 Thread Michael Banck
Package: gopher Version: 3.0.11 Severity: important Tags: patch Hi, your package failed to autobuild: Automatic build of gopher_3.0.11 on beethoven by sbuild/hurd-i386 69 Build started at 20051207-1916 ** [...] Checking