Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-12-20 Thread Chris Pickett
Chris Pickett wrote: And, I've applied Loïc's AC_INCLUDES_DEFAULT patch to my local repository, r5551. I noticed that bug 342864 is still open. It's been closed in a released version of Check since 0.9.4. Cheers, Chris

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-19 Thread Chris Pickett
Chris Pickett wrote: Loïc Minier wrote: On Sun, Mar 19, 2006, Robert Collins wrote: Sure but lets not let the perfect be the enemy of the good: There are two patches now that will correct AM_PATH_CHECK with -Werror in CFLAGS. Both are improvements, and I'm completely happy with either being a

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-19 Thread Chris Pickett
Loïc Minier wrote: On Sun, Mar 19, 2006, Robert Collins wrote: Sure but lets not let the perfect be the enemy of the good: There are two patches now that will correct AM_PATH_CHECK with -Werror in CFLAGS. Both are improvements, and I'm completely happy with either being applied which will fix t

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-19 Thread Loïc Minier
On Sun, Mar 19, 2006, Robert Collins wrote: > Sure but lets not let the perfect be the enemy of the good: > There are two patches now that will correct AM_PATH_CHECK with -Werror > in CFLAGS. Both are improvements, and I'm completely happy with either > being applied which will fix the bug. Additio

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-19 Thread Robert Collins
On Sat, 2006-03-18 at 23:17 -0500, Chris Pickett wrote: > Robert Collins wrote: > > > CFLAGS="-Werror" may not have optimisations enabled in gcc -> many > > warnings are disabled. Can you reproduce with CFLAGS="-Werror -O2" ? > > I haven't tried this, but I just wanted to say: I think a lot of th

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-18 Thread Chris Pickett
Robert Collins wrote: CFLAGS="-Werror" may not have optimisations enabled in gcc -> many warnings are disabled. Can you reproduce with CFLAGS="-Werror -O2" ? I haven't tried this, but I just wanted to say: I think a lot of the AM_PATH_CHECK macro can be cleaned up or eliminated. Probably the

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-18 Thread Loïc Minier
On Sat, Mar 18, 2006, Robert Collins wrote: > > Robert Lemmen couldn't reproduce the bug, here's how: [...] > > ./configure CFLAGS="-Werror" > > CFLAGS="-Werror" may not have optimisations enabled in gcc -> many > warnings are disabled. Can you reproduce with CFLAGS="-Werror -O2" ? Sure, th

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-18 Thread Robert Collins
On Sat, 2006-03-18 at 11:21 +0100, Loïc Minier wrote: > tags #342864 + confirmed upstream patch > stop > > Hi, > > On Sun, Dec 11, 2005, Robert Collins wrote: > > The AM_PATH_CHECK macro in 0.9.3 fails to build if -Werror -g -O2 is > > used as the CFLAGS during autoconf > > Indeed. > >

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-18 Thread Loïc Minier
On Sat, Mar 18, 2006, Loïc Minier wrote: > Patch attached. Err, hmm. -- Loïc Minier <[EMAIL PROTECTED]> Current Earth status: NOT DESTROYED --- /usr/share/aclocal/check.m4 2006-01-02 17:55:01.0 +0100 +++ m4/check.m4 2006-03-18 11:16:49.0 +0100 @@ -30,10 +30,7 @@ LIBS="$C

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2006-03-18 Thread Loïc Minier
tags #342864 + confirmed upstream patch stop Hi, On Sun, Dec 11, 2005, Robert Collins wrote: > The AM_PATH_CHECK macro in 0.9.3 fails to build if -Werror -g -O2 is > used as the CFLAGS during autoconf Indeed. > Note that all that is needed is to add > #if HAVE_STRING_H > #include > #e

Bug#342864: AM_PATH_CHECK macro fails to build with -Werror

2005-12-11 Thread Robert Collins
package: check severity: normal The AM_PATH_CHECK macro in 0.9.3 fails to build if -Werror -g -O2 is used as the CFLAGS during autoconf: configure:22065: i486-linux-gnu-gcc -o conftest -Werror -g -O2 conftest.c -lcheck >&5 cc1: warnings being treated as errors conftest.c: In function 'main': con