Bug#333854: [PATCHES] [BUGS] Bug#333854: pg_group file update problems

2005-10-26 Thread Bruce Momjian
This bug will be fixed in the next 8.0.X release. I have not fixed 7.4.X because the risk/benefit does not warrant it, and 8.1 does not have this problem. --- Bruce Momjian wrote: > > I have developed a small patch to 8.0.

Bug#333854: [PATCHES] [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > OK, updated patch. > > I was sort of hoping that you would make the comments agree with the > code... Oh, you really read those comments? Fixed and attached. -- Bruce Momjian| http://candle.pha.pa.us pgman@candle.pha.pa.

Bug#333854: [PATCHES] [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Tom Lane
Bruce Momjian writes: > OK, updated patch. I was sort of hoping that you would make the comments agree with the code... regards, tom lane -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Bug#333854: [PATCHES] [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > In the patch, notice the old comment that suggests we might need to use > > CommandCounterIncrement(). > > ... which you failed to fix in any meaningful way. I'd suggest > > /* >* Advance the commmand counter to ensure we see all results

Bug#333854: [PATCHES] [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Tom Lane
Bruce Momjian writes: > In the patch, notice the old comment that suggests we might need to use > CommandCounterIncrement(). ... which you failed to fix in any meaningful way. I'd suggest /* * Advance the commmand counter to ensure we see all results * of current trans

Bug#333854: [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Bruce Momjian
I have developed a small patch to 8.0.X that fixes your reported problem: test=> CREATE GROUP g1; CREATE GROUP test=> CREATE USER u1 IN GROUP g1; CREATE USER test=> \! cat /u/pg/data/global/pg_group "g1""u1" test=> CREATE USER u2 IN GR

Bug#333854: [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Bruce Momjian
Tom Lane wrote: > Dennis Vshivkov <[EMAIL PROTECTED]> writes: > > The problem is that the code that updates pg_group file resolves > > group membership through the system user catalogue cache. > > Good catch. > > > The attached `98-6-pg_group-stale-data-fix.patch' makes the code > > in question a

Bug#333854: [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Tom Lane
Dennis Vshivkov <[EMAIL PROTECTED]> writes: > The problem is that the code that updates pg_group file resolves > group membership through the system user catalogue cache. Good catch. > The attached `98-6-pg_group-stale-data-fix.patch' makes the code > in question access the system user table dire

Bug#333854: [BUGS] Bug#333854: pg_group file update problems

2005-10-14 Thread Bruce Momjian
I can confirm your problem in current 8.0.X CVS. Your fixes to update pg_group when a user is added (because they might be added to a group at the same time) is correct too. And the visiblity problem is a valid bug too. ---

Bug#333854: pg_group file update problems

2005-10-13 Thread Dennis Vshivkov
Package: postgresql-8.0 Version: 8.0.3-13 Severity: important Tags: patch, upstream Here's the problem: db=# CREATE GROUP g1; CREATE GROUP db=# CREATE USER u1 IN GROUP g1;(1) CREATE USER # cat /var/lib/postgresql/8.0/main/global/pg_group # The file gets rewritten, but th