Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-26 Thread Thorsten Glaser
Dixi quod… > What do you think about this? I tried several variants and ended Arrgh, forgot the attachment, sorry. bye, //mirabilos -- 15:41⎜ Somebody write a testsuite for helloworld :-)From 9676611494d6dc1bf2a87fd4e2646dc366bb1e5e Mon Sep 17 00:00:00 2001 From: mirabilos Date: Thu, 26 Jan 20

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-26 Thread Thorsten Glaser
Dixi quod… > On Wed, 25 Jan 2017, Eric Blake wrote: > > > I also think we can try harder to point out the need for config.h to > > appear first. How about the following counter-proposal: […] > Nice, but I think I can improve on that a bit (later, I’m almost > dropping down due to tiredness), it s

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-25 Thread Zack Weinberg
On Wed, Jan 25, 2017 at 2:06 PM, Eric Blake wrote: > > I also think we can try harder to point out the need for config.h to > appear first. How about the following counter-proposal: ... If we're going to warn people about this in the context of specific macros we should do the same for AC_USE_SY

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-25 Thread Thorsten Glaser
On Wed, 25 Jan 2017, Eric Blake wrote: > Thanks; that's helpful. I'm still thinking we may want to iterate on Yes, of course; you know autoconf much better than I do. > You're deleting all mention that the macro may modify CC (true, it > doesn't do it on most platforms, but the code is still th

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-25 Thread Eric Blake
On 01/25/2017 11:30 AM, Thorsten Glaser wrote: > On Wed, 25 Jan 2017, Eric Blake wrote: > >> Please propose a patch to the documentation, rather than just telling me >> that it is wrong, so that we have a concrete proposal for a wording >> improvement that we can discuss. > Oh okay, I’ll cater for

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-25 Thread Thorsten Glaser
On Wed, 25 Jan 2017, Eric Blake wrote: > Please propose a patch to the documentation, rather than just telling me > that it is wrong, so that we have a concrete proposal for a wording > improvement that we can discuss. Oh okay, I’ll cater for lazy upstreams this time ;-) See the attached git form

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-25 Thread Eric Blake
On 01/25/2017 10:45 AM, Thorsten Glaser wrote: > > This is even more unfortunate, because now, if any program includes > a glibc system header before "config.h", the definition will be > ignored, because it comes too late. This is wrong. The manual clearly states that config.h MUST be included pr

Bug#158969: autoconf: AC_SYS_LARGEFILE documentation misleading

2017-01-25 Thread Thorsten Glaser
found 158969 2.69-10 thanks Hi *, I have to reopen this because the documentation is plain wrong and misleading still: -- Macro: AC_SYS_LARGEFILE Arrange for 64-bit file offsets, known as large-file support (http://www.unix-systems.org/version2/whatsnew/lfs20mar.html). On some h