Bug#1089625: dap-mode 0.8-1 upload

2024-12-18 Thread Xiyue Deng
Hi Soren, Soren Stoutner writes: > On Sunday, December 15, 2024 3:55:44 AM MST Sean Whitton wrote: >> I saw that you reformatted copyright claims to drop the (C) and to add >> commas. Generally licenses require us to reproduce copyright notices >> verbatim. IANAL, but reformatting is probably

Bug#1089625: dap-mode 0.8-1 upload

2024-12-18 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Wed 18 Dec 2024 at 10:18am -08, Xiyue Deng wrote: > >> I did try not including >> `[debian/tmp/]usr/share/doc/elpa-dap-mode/changelog' in d/docs, and >> dh_missing gave the following error: >> >> , >> | dh_missing: warning: usr/share/doc/elpa-dap

Bug#1089625: dap-mode 0.8-1 upload

2024-12-18 Thread Sean Whitton
Hello, On Wed 18 Dec 2024 at 10:18am -08, Xiyue Deng wrote: > I did try not including > `[debian/tmp/]usr/share/doc/elpa-dap-mode/changelog' in d/docs, and > dh_missing gave the following error: > > , > | dh_missing: warning: usr/share/doc/elpa-dap-mode/changelog exists in > | debian/tmp but

Bug#1089625: dap-mode 0.8-1 upload

2024-12-18 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Wed 18 Dec 2024 at 12:07am -08, Xiyue Deng wrote: > >> AIUI technically both work: in install files like >> d/{docs,install,links}, etc., the file path starts from source >> directory, and dh_install will fallback to search under debian/tmp if >> the

Bug#1089625: dap-mode 0.8-1 upload

2024-12-18 Thread Sean Whitton
Hello, On Wed 18 Dec 2024 at 12:07am -08, Xiyue Deng wrote: > AIUI technically both work: in install files like > d/{docs,install,links}, etc., the file path starts from source > directory, and dh_install will fallback to search under debian/tmp if > the file is not found under source directory[1

Bug#1089625: dap-mode 0.8-1 upload

2024-12-18 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Tue 17 Dec 2024 at 06:57pm -08, Xiyue Deng wrote: > >> Hi Sean, >> >> Sean Whitton writes: >> >>> Hello, >>> >>> On Tue 17 Dec 2024 at 02:08am -08, Xiyue Deng wrote: >>> The symlink should have been removed at 927b478, and my local built p

Bug#1089625: dap-mode 0.8-1 upload

2024-12-17 Thread Sean Whitton
Hello, On Tue 17 Dec 2024 at 06:57pm -08, Xiyue Deng wrote: > Hi Sean, > > Sean Whitton writes: > >> Hello, >> >> On Tue 17 Dec 2024 at 02:08am -08, Xiyue Deng wrote: >> >>> The symlink should have been removed at 927b478, and my local built >>> package does not seem to have any symlink to CHANG

Bug#1089625: dap-mode 0.8-1 upload

2024-12-17 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Tue 17 Dec 2024 at 02:08am -08, Xiyue Deng wrote: > >> The symlink should have been removed at 927b478, and my local built >> package does not seem to have any symlink to CHANGELOG.org anymore. Can >> you pull and retry? > > Hmm, sorry. > > But your

Bug#1089625: dap-mode 0.8-1 upload

2024-12-17 Thread Sean Whitton
Hello, On Tue 17 Dec 2024 at 02:08am -08, Xiyue Deng wrote: > The symlink should have been removed at 927b478, and my local built > package does not seem to have any symlink to CHANGELOG.org anymore. Can > you pull and retry? Hmm, sorry. But your install(1) invocation doesn't work, I think? I

Bug#1089625: dap-mode 0.8-1 upload

2024-12-17 Thread Xiyue Deng
Sean Whitton writes: > Hello, > > On Sun 15 Dec 2024 at 10:52pm -08, Xiyue Deng wrote: > >> To look at it from complexity point of view, installing CHANGELOG.org as >> changelog requires the following minimum change: >> 1) Not included CHANGELOG.org in d/docs (which now only includes >> NEWS.or

Bug#1089625: dap-mode 0.8-1 upload

2024-12-16 Thread Sean Whitton
Hello, On Sun 15 Dec 2024 at 10:52pm -08, Xiyue Deng wrote: > To look at it from complexity point of view, installing CHANGELOG.org as > changelog requires the following minimum change: > 1) Not included CHANGELOG.org in d/docs (which now only includes > NEWS.org), > 2) Override dh_installdocs

Bug#1089625: dap-mode 0.8-1 upload

2024-12-16 Thread Sean Whitton
Hello, On Mon 16 Dec 2024 at 02:15pm -07, Soren Stoutner wrote: > For example: > > 1. “years of publication for one copyright holder may be gathered together” > > https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#copyright-field I had forgotten about gathering years together, th

Bug#1089625: dap-mode 0.8-1 upload

2024-12-16 Thread Soren Stoutner
On Sunday, December 15, 2024 3:55:44 AM MST Sean Whitton wrote: > I saw that you reformatted copyright claims to drop the (C) and to add > commas. Generally licenses require us to reproduce copyright notices > verbatim. IANAL, but reformatting is probably not justified. Generally, both licenses

Bug#1089625: dap-mode 0.8-1 upload

2024-12-16 Thread Soren Stoutner
On Sunday, December 15, 2024 2:18:53 AM MST Xiyue Deng wrote: > Thanks for the detailed explanation! AIUI, as long as the files are > using the same license, their copyright holders can be grouped by one > stanza, regardless of individual file copyright holder differences. Is > my understanding c

Bug#1089625: dap-mode 0.8-1 upload

2024-12-15 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Sun 15 Dec 2024 at 01:19am -08, Xiyue Deng wrote: > >>> I think Lintian is correct, tbh. >> >> Can you expand a little on this? The lintian warning text does say: >> , >> | (Symlinks to another file in /usr/share/doc/pkg or a subdirectory >> | t

Bug#1089625: dap-mode 0.8-1 upload

2024-12-15 Thread Sean Whitton
Hello, On Sun 15 Dec 2024 at 01:19am -08, Xiyue Deng wrote: >> I think Lintian is correct, tbh. > > Can you expand a little on this? The lintian warning text does say: > , > | (Symlinks to another file in /usr/share/doc/pkg or a subdirectory > | thereof are fine and should not trigger this w

Bug#1089625: dap-mode 0.8-1 upload

2024-12-15 Thread Xiyue Deng
Hi Soren Soren Stoutner writes: > Xiyue, > > On Saturday, December 14, 2024 12:36:43 AM MST Xiyue Deng wrote: >> I took a look at the machine-readable copyright format document[1], >> specifically the example given in the copyright section 6.8, and I >> think it meant that if a group of file sha

Bug#1089625: dap-mode 0.8-1 upload

2024-12-15 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Fri 13 Dec 2024 at 11:36pm -08, Xiyue Deng wrote: > >> I also tried d/install, but it cannot rename files. > > You could try dh_exec. > >> In fact, all Debian control files supporting the "source destination" >> format seem to treat destination as a

Bug#1089625: dap-mode 0.8-1 upload

2024-12-14 Thread Sean Whitton
Hello, On Fri 13 Dec 2024 at 11:36pm -08, Xiyue Deng wrote: > I also tried d/install, but it cannot rename files. You could try dh_exec. > In fact, all Debian control files supporting the "source destination" > format seem to treat destination as a directory only and are created > on demand, wh

Bug#1089625: dap-mode 0.8-1 upload

2024-12-14 Thread Soren Stoutner
Xiyue, On Saturday, December 14, 2024 12:36:43 AM MST Xiyue Deng wrote: > I took a look at the machine-readable copyright format document[1], > specifically the example given in the copyright section 6.8, and I > think it meant that if a group of file shares any copyright holder(s), > those files

Bug#1089625: dap-mode 0.8-1 upload

2024-12-13 Thread Xiyue Deng
Hi Sean, Thanks for the clear and detailed review! Please see my reply below. Sean Whitton writes: > Hello Xiyue, > > Alright, looking at commit 8e06c63: > > - Renaming the file from CHANGELOG.org to changelog in a build target > dirties the tree, and could mean the package will fail to buil

Bug#1089625: dap-mode 0.8-1 upload

2024-12-13 Thread Sean Whitton
Hello Xiyue, Alright, looking at commit 8e06c63: - Renaming the file from CHANGELOG.org to changelog in a build target dirties the tree, and could mean the package will fail to build twice. You could rename it back in the clean target, but I think it would be more maintainable to install C

Bug#1089625: dap-mode 0.8-1 upload

2024-12-12 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello, > > On Wed 11 Dec 2024 at 10:44pm -08, Xiyue Deng wrote: > >> Thank you both for clarifying! I was trying one last attempt by >> providing changelog as a symlink to the CHANGELOG.org in hope that Emacs >> could recognize the org format through the symlink,

Bug#1089625: dap-mode 0.8-1 upload

2024-12-12 Thread Sean Whitton
Hello, On Wed 11 Dec 2024 at 10:44pm -08, Xiyue Deng wrote: > Thank you both for clarifying! I was trying one last attempt by > providing changelog as a symlink to the CHANGELOG.org in hope that Emacs > could recognize the org format through the symlink, but apparently that > didn't work and it

Bug#1089625: dap-mode 0.8-1 upload

2024-12-11 Thread Xiyue Deng
Hi Sean, Nicholas, Nicholas D Steeves writes: > On Wed, 11 Dec 2024, 21:57 Sean Whitton, wrote: > >> Hello, >> >> On Tue 10 Dec 2024 at 10:32pm -08, Xiyue Deng wrote: >> >> > That said, even though I would prefer to ship CHANGELOG.org under >> > /usr/share/doc/dap-mode as-is, I would not insist

Bug#1089625: dap-mode 0.8-1 upload

2024-12-11 Thread Nicholas D Steeves
On Wed, 11 Dec 2024, 21:57 Sean Whitton, wrote: > Hello, > > On Tue 10 Dec 2024 at 10:32pm -08, Xiyue Deng wrote: > > > That said, even though I would prefer to ship CHANGELOG.org under > > /usr/share/doc/dap-mode as-is, I would not insist. Do you think it is > > OK to just skip/not-shipping it?

Bug#1089625: dap-mode 0.8-1 upload

2024-12-11 Thread Sean Whitton
Hello, On Tue 10 Dec 2024 at 10:32pm -08, Xiyue Deng wrote: > I see. I checked Policy 12.7[1] and it does suggest providing an > upstream in plain text format and should be named `changelog', though > as I understand it, the footnote suggests that the purpose is more about > make it easy to be f

Bug#1089625: dap-mode 0.8-1 upload

2024-12-10 Thread Xiyue Deng
Sean Whitton writes: > Hello, > > On Tue 10 Dec 2024 at 10:45am -08, Xiyue Deng wrote: > >> Hi Sean, >> >> Sean Whitton writes: >> >>> Hello Xiyue, >>> >>> Thanks for adopting the package. >>> >>> You've added a wrong-name-for-upstream-changelog override. What name >>> does the file get install

Bug#1089625: dap-mode 0.8-1 upload

2024-12-10 Thread Sean Whitton
Hello, On Tue 10 Dec 2024 at 10:45am -08, Xiyue Deng wrote: > Hi Sean, > > Sean Whitton writes: > >> Hello Xiyue, >> >> Thanks for adopting the package. >> >> You've added a wrong-name-for-upstream-changelog override. What name >> does the file get installed as? The .org extension shouldn't be

Bug#1089625: dap-mode 0.8-1 upload

2024-12-10 Thread Xiyue Deng
Hi Sean, Sean Whitton writes: > Hello Xiyue, > > Thanks for adopting the package. > > You've added a wrong-name-for-upstream-changelog override. What name > does the file get installed as? The .org extension shouldn't be present > in the filesystem under /usr/share/doc, if that is what it is.

Bug#1089625: dap-mode 0.8-1 upload

2024-12-10 Thread Sean Whitton
Hello Xiyue, Thanks for adopting the package. You've added a wrong-name-for-upstream-changelog override. What name does the file get installed as? The .org extension shouldn't be present in the filesystem under /usr/share/doc, if that is what it is. -- Sean Whitton