Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-07 Thread Dmitry Shachnev
On Tue, May 07, 2024 at 05:58:55PM +, Thorsten Glaser wrote: > Dmitry Shachnev dixit: > > >Will you be able to forward your patch upstream when you finalize it? > > Sort of. I can do the CLA, Gerrit, etc. dance, but I probably cannot > respond well if they want me to test things with vanilla

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-07 Thread Thorsten Glaser
Dmitry Shachnev dixit: >Will you be able to forward your patch upstream when you finalize it? Sort of. I can do the CLA, Gerrit, etc. dance, but I probably cannot respond well if they want me to test things with vanilla upstream (instead of the packaging), or if they have requests I as a C (but n

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-07 Thread Sune Stolborg Vuorela
On Monday, May 6, 2024 4:51:25 PM CEST Thorsten Glaser wrote: > It still does not address the OS/2 table, but it does manage to > fix both the PDF-side and font-side hhea table metrics, which is > enough for Atril at least. (Not sure whether it’s enough for my > gf’s printer, I’ll have to test. Or

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-06 Thread Thorsten Glaser
Dixi quod… >Dmitry Shachnev dixit: >>Now that you dug so deeply, maybe you can try to replace qRound in those >>three lines that you mentioned with TO_TTF, and check if it fixes the bug > >That *and* figure out somehow how to fix the PDF /FontBBox, at >least… (though I binary-patched the hhea ascen

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-05 Thread Thorsten Glaser
Dixi quod… >values). I’ll build it now so I don’t know if it even compiles yet… font.hhea.ascender = TO_TTF(properties.ascent.toReal()); font.hhea.descender = TO_TTF(-properties.descent.toReal()); font.hhea.lineGap = TO_TTF(properties.leading.toReal());

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-05 Thread Thorsten Glaser
Dixi quod… >>Now that you dug so deeply, maybe you can try to replace qRound in those >>three lines that you mentioned with TO_TTF, and check if it fixes the bug > >That *and* figure out somehow how to fix the PDF /FontBBox, at I’m trying this (attached). That does both (by letting toTruetype() a

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-05 Thread Thorsten Glaser
Hi Dmitry, (you use Googlemail, which is problematic, I picked your reply from the BTS; perhaps send to 1070406-submitter@b.d.o instead which should arrive) >I checked Qt 4 history [1] and there this code dates back to “Long live Qt!” >commit from 2009. So it’s unlikely that we can find the origi

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-05 Thread Dmitry Shachnev
On Sun, May 05, 2024 at 08:45:25PM +, Thorsten Glaser wrote: > Dixi quod… > > >correct… but it only changes the metrics in the head table, not > >in the OS/2 or hhea tables (as can be seen when loading the font > >from the PDF in FontForge). Furthermore, the /FontBBox in the PDF > >is construc

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-05 Thread Thorsten Glaser
Dixi quod… >correct… but it only changes the metrics in the head table, not >in the OS/2 or hhea tables (as can be seen when loading the font >from the PDF in FontForge). Furthermore, the /FontBBox in the PDF >is constructed from the values from the original font. And Atril uses the values from t

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-05 Thread Thorsten Glaser
Dixi quod… >$ atril moo.pdf Further debugging reveals the cause: When Qt5 embeds a font, it scales it to 2048 ppem, no matter if it was 1000 ppem (PS/CFF) or 1024 ppem (TTF) before. I think this is because [QTBUG-586] it cannot embed CFF fonts, so it always converts to TTF (apparently even if it

Bug#1070406: Qt5: badly clips some fonts when rendering to PDFs

2024-05-04 Thread Thorsten Glaser
Package: qtbase5-dev Version: 5.15.10+dfsg-7.2+b1 Severity: normal X-Debbugs-Cc: t...@mirbsd.de Control: found -1 5.15.2+dfsg-9 Control: found -1 5.7.1+dfsg-3+deb9u4 Control: affects -1 musescore Control: affects -1 musescore3 I’ve received reports that PDFs generated by Mu͒seScore when viewed in