Hi Chris,
Thanks again for your guidance and help!
On 24.04.2017 19:13, Chris Lamb wrote:
> So, I think…
>
> if get_image_size(self.path) != get_image_size(other.path):
> raise AssertionError
>
> … are better written as:
>
> assert get_image_size(self.path) == get_image_size(othe
Hi Chris,
On 21.04.2017 22:58, Chris Lamb wrote:
> Hey Maria,
Thank you for looking into this!
> Some very quick thoughts:
> [...]
I tried to improve indentation and other cosmetic things. What do you
think of the current state?
Regarding Config().html_output -- I put the comment that should
Hi Chris!
> Could you push this to a branch so we can more easily play with it? :)
Pushed to siamezzze/image-visual-comparison . Thanks for your input!
Maria
signature.asc
Description: OpenPGP digital signature
Hi,
I believe the attached patch provides the requested feature.
I would be very grateful for any review or general advice on how to make
it better.
From 7bdcf310284a11e788fe761f86b1d1dbb51cf968 Mon Sep 17 00:00:00 2001
From: Maria Glukhova
Date: Sat, 1 Apr 2017 22:07:54 +0300
Subject: [PATCH
erences[1].source2 == 'APK metadata'
+assert differences[2].source1 == 'APK metadata'
+assert differences[2].source2 == 'APK metadata'
+
+@skip_unless_tools_exist('apktool', 'zipinfo')
+def test_skip_undecoded_android_manifest(differences):
+a
Chris,
вс, 15 янв. 2017 г. в 4:57, Chris Lamb :
> As it happens I wrote my own fix before I saw your email
> and I have pushed it — what do you think?
>
>
Making APK metadata appear at fixed place surely looks better. IMO, that
approach follows the original intent of the request much more closely
; rather than none.
>
>
> Regards,
>
> --
> ,''`.
> : :' : Chris Lamb
> `. `'` la...@debian.org / chris-lamb.co.uk
>`-
>
From 67e0ca7b632699f54aec27069efd4e0c547ab708 Mon Sep 17 00:00:00 2001
From: Maria Glukhova
Date: Fri, 13 Jan 2017
es, so adding these tests would extend the time taken by the whole
testing process significantly (almost doubles it at my system). Which makes
me wonder if that was the reason such tests were not added together with
APK comparator in the first place...
Maria Glukhov
e with that idea!
Maria
From 7abab29f878f7fe8e1229995c06a404d5d4e0b40 Mon Sep 17 00:00:00 2001
From: Maria Glukhova
Date: Sat, 7 Jan 2017 18:42:19 +0300
Subject: [PATCH] Generic order-line difference for all kind of inputs.
---
diffoscope/comparators/text.py | 13 -
diffoscope/diff.py | 27 +
9 matches
Mail list logo
