Bug#894997: [PATCH] git-svn: avoid warning on undef readline()

2018-04-08 Thread Junio C Hamano
Eric Wong writes: > Ævar Arnfjörð Bjarmason wrote: >> See https://public-inbox.org/git/86h8oobl36@phe.ftfl.ca/ for the >> original report. > > Thanks for taking a look at this. Also https://bugs.debian.org/894997 > >> --- a/perl/Git.pm >> +++ b/perl/Git.pm >> @@ -554,7 +554,7 @@ sub get_rec

Bug#842477: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: (commenting out of order) > It's probably worthwhile to split off git-sh-setup into git-sh-setup & > git-sh-setup-internal along with a documentation fix. A lot of what > it's doing (e.g. git_broken_path_fix(), and adding a die() function) > is probably only neede

Bug#842477: [PATCH] git-sh-setup: Restore sourcability from outside scripts

2016-10-30 Thread Junio C Hamano
Anders Kaseorg writes: > v2.10.0-rc0~45^2~2 “i18n: git-sh-setup.sh: mark strings for > translation” broke outside scripts such as guilt that source > git-sh-setup as described in the documentation: > > $ . "$(git --exec-path)/git-sh-setup" > sh: 6: .: git-sh-i18n: not found > > This also affects

Bug#434599: [PATCH] git-imap-send: use libcurl for implementation

2014-10-29 Thread Junio C Hamano
Bernhard Reiter writes: > Resending this once more, as indicated by > > Hope my formatting and posting style is now conformant. Sorry for the noise. Thanks. The patch does not apply for me (please send a trial message to yourself and then try to apply it out of your mailbox to avoid such an i

Bug#434599: [PATCH/RFC] git-imap-send: use libcurl for implementation

2014-08-19 Thread Junio C Hamano
Bernhard Reiter writes: > Am 2014-08-17 um 20:42 schrieb Jeff King: >> [...] >> I'm not sure I understand this comment. Even if SSL is not in use, wouldn't we be passing a regular pipe to curl, which would break? >>> >>> Yeah, we can't do that, and thus would have to keep the handwritt

Bug#757297: 'git status' output is confusing after 'git add -N'

2014-08-07 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Aug 7, 2014 at 7:34 AM, Jonathan Nieder wrote: >> Package: git >> Version: 1:2.0.0-1 >> Tags: upstream >> >> $ git init foo >> Initialized empty Git repository in /tmp/t/foo/.git/ >> $ cd foo >> $ echo hi >README >> $ git add -N README >> $ git status >>

Bug#727226: [PATCH] cvsserver: Determinize output to combat Perl 5.18 hash randomization

2013-10-30 Thread Junio C Hamano
Anders Kaseorg writes: > Perl 5.18 randomizes the seed used by its hash function, so iterating > through hashes results in different orders from run to run: > http://perldoc.perl.org/perl5180delta.html#Hash-overhaul > > This usually broke t9400 (gitcvs.dbname, gitcvs.ext.dbname, when > running

Bug#666250: [PATCH] Documentation: replace 'vi' for 'editor' to reflect build-time option

2012-03-30 Thread Junio C Hamano
Rodrigo Silva writes: > At 23:16 29/3/2012, Junio C Hamano wrote: > ... >>I've already rejected this patch once, but that was primarily because the >>patch was not justified with the above "I read everybody else's git uses >>'vi' on the Interweb

Bug#575917: [long] worktree setup cases

2010-10-20 Thread Junio C Hamano
Nguyen Thai Ngoc Duy writes: > Assumptions: > > 1. When .git is a file and contains a relative path, I assume it is >relative to .git file's parent directory. read_gitfile_gently() >function will make the path absolute, but it depends on (maybe >wrong) cwd. Ok. I agree that a regul

Bug#554682: [PATCH 3/8] bundle: give list_prerequisites() loop body its own function

2010-06-30 Thread Junio C Hamano
Jonathan Nieder writes: > No functional change intended. > > Signed-off-by: Jonathan Nieder > --- > bundle.c | 57 +++-- > 1 files changed, 31 insertions(+), 26 deletions(-) > > diff --git a/bundle.c b/bundle.c > index 0dd2acb..e90b5c5 10064

Bug#554682: [PATCH 2/8] bundle: use libified rev-list --boundary

2010-06-30 Thread Junio C Hamano
Jonathan Nieder writes: > The revision walker produces structured output, which should be a > little easier to work with than the text from rev-list. Hmm, doesn't it negatively affect later traversal you would need to do if you smudged the flag bits by running revision traversal like this? --

Bug#578764: 'commit -a' safety

2010-04-24 Thread Junio C Hamano
Petr Baudis writes: > On Sat, Apr 24, 2010 at 01:10:24PM +0200, Wincent Colaiuta wrote: >> El 24/04/2010, a las 11:40, Jakub Narebski escribió: >> > I'd like for 'git commit -a' to *fail* if there are staged changes for >> > tracked files, excluding added, removed and renamed files. > > Thanks fo

Bug#578764: Please default to 'commit -a' when no changes were added

2010-04-23 Thread Junio C Hamano
Goswin von Brederlow writes: > But you are already rejecting it in the design phase before there even > is a patch. We do review both the design and the implementation on this list, and it actually is a *good* thing if a proposal is rejected when its design is flawed at the conceptual level. A

Bug#578764: Please default to 'commit -a' when no changes were added

2010-04-22 Thread Junio C Hamano
Goswin von Brederlow writes: >> Exact. It is therefore not progress to impose some inconvenience to one >> work flow in order to make another one easier. And in this case we're >> talking about the difference between having to type an additional -a vs >> the risk of creating a commit with un

Bug#462557: [PATCH] Let 'git -h' show usage without a git dir

2009-11-08 Thread Junio C Hamano
Jonathan Nieder writes: > diff --git a/git.c b/git.c > index bd2c5fe..bfa9518 100644 > --- a/git.c > +++ b/git.c > @@ -220,6 +220,11 @@ const char git_version_string[] = GIT_VERSION; > * RUN_SETUP for reading from the configuration file. > */ > #define NEED_WORK_TREE (1<<2) > +/* > + *

Bug#553296: gitignore broken completely

2009-10-30 Thread Junio C Hamano
Jeff King writes: > On Fri, Oct 30, 2009 at 12:41:27PM -0700, Junio C Hamano wrote: > >> I've never understood the use of "ls-files -i" without -o, so in that >> sense, I have done 2. myself already long time ago. >> >> In other words, I do not r

Bug#553296: gitignore broken completely

2009-10-30 Thread Junio C Hamano
Jeff King writes: > I am not sure simply reverting is the best choice; the patch does do > something useful. And while it strictly breaks backwards compatibility > on the output without "-i", the old behavior was considered a bug. But > the "-i" behavior is useless now, so we need to figure out h

Bug#553296: gitignore broken completely

2009-10-30 Thread Junio C Hamano
Jeff King writes: > On Fri, Oct 30, 2009 at 02:41:55PM -0400, Jeff King wrote: > >> >6. Revert the patch and rework it so that it will only have effect if >> > there is no -i option on the command line. (That is similiar to a >> > mix of 3 and 4.) >> >> Yeah, that would actually

Bug#469250: Commit f5bbc322 to git broke pre-commit hooks which read stdin

2008-03-04 Thread Junio C Hamano
Johannes Sixt <[EMAIL PROTECTED]> writes: >> It is not metastore. It is an interactive hook that reads from the user >> who is sitting on the terminal and invoked the git-commit program. > > Are you saying stdin should not be directed to /dev/null, or that an > interactive hook is required to do

Bug#469250: Commit f5bbc322 to git broke pre-commit hooks which read stdin

2008-03-04 Thread Junio C Hamano
Johannes Schindelin <[EMAIL PROTECTED]> writes: > Hi, > > On Tue, 4 Mar 2008, David Bremner wrote: > >> It looks like line 435 of builtin-commit.c disables stdin for hooks >> (with the disclaimer that I first looked at the git source ten minutes >> ago). >> >> hook.no_stdin = 1 >> >> I

Bug#427078: [PATCH] Create a new manpage for the gitignore format, and reference it elsewhere

2007-06-01 Thread Junio C Hamano
Josh Triplett <[EMAIL PROTECTED]> writes: Thanks, but shouldn't all the in-text mention of "gitignore(5)" and friends, not just in "See Also" section, use "gitlink:gitignore[5]" instead? -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROT

Bug#386495: [PATCH] apply --unidiff-zero: loosen sanity checks for --unidiff=0 patches

2006-09-17 Thread Junio C Hamano
But if all you have to work with is a patch without context, this flag may come handy as the last resort. Signed-off-by: Junio C Hamano <[EMAIL PROTECTED]> --- builtin-apply.c | 112 +++- t/t3403-rebase-skip.sh|4 +- t/t

Bug#386495: git-apply fails to apply some patches

2006-09-16 Thread Junio C Hamano
Gerrit Pape <[EMAIL PROTECTED]> writes: >... > On top of that, I try to apply this interdiff generated patch: > > diff -u pciutils-2.1.11/debian/dirs pciutils-2.1.11/debian/dirs > --- pciutils-2.1.11/debian/dirs > +++ pciutils-2.1.11/debian/dirs > @@ -6,0 +7 @@ > +var/lib/pciutils > > and git-appl