[Cython] Broken tests

2011-05-27 Thread Stefan Behnel
Hi, could we please make it a requirement to run the complete test suite after a branch merge? Or at least taking a close look at Jenkins after pushing a merge? And then fixing the bugs it finds? Stefan ___ cython-devel mailing list cython-devel@pyt

Re: [Cython] Broken tests

2011-05-27 Thread Vitja Makarov
2011/5/27 Stefan Behnel : > Hi, > > could we please make it a requirement to run the complete test suite after a > branch merge? Or at least taking a close look at Jenkins after pushing a > merge? And then fixing the bugs it finds? > > Stefan > There are failing tests in _control_flow branch. I gu

Re: [Cython] Broken tests

2011-05-27 Thread Dag Sverre Seljebotn
On 05/27/2011 02:41 PM, Vitja Makarov wrote: 2011/5/27 Stefan Behnel: Hi, could we please make it a requirement to run the complete test suite after a branch merge? Or at least taking a close look at Jenkins after pushing a merge? And then fixing the bugs it finds? Stefan There are failing

Re: [Cython] Broken tests

2011-05-27 Thread Vitja Makarov
2011/5/27 Dag Sverre Seljebotn : > On 05/27/2011 02:41 PM, Vitja Makarov wrote: >> >> 2011/5/27 Stefan Behnel: >>> >>> Hi, >>> >>> could we please make it a requirement to run the complete test suite >>> after a >>> branch merge? Or at least taking a close look at Jenkins after pushing a >>> merge?

Re: [Cython] [cython] Openmp (#30)

2011-05-27 Thread Stefan Behnel
[regarding the code for analysing uninitialised variables in the OpenMP branch] dagss, 27.05.2011 10:32: I suggest this: a) Vitja and Stefan notifies Mark of any issues that stops control flow analysis from going into trunk (outright collisions etc.). Those have prioritiy over fused types work

Re: [Cython] [cython] Openmp (#30)

2011-05-27 Thread Dag Sverre Seljebotn
On 05/27/2011 03:54 PM, Stefan Behnel wrote: [regarding the code for analysing uninitialised variables in the OpenMP branch] dagss, 27.05.2011 10:32: I suggest this: a) Vitja and Stefan notifies Mark of any issues that stops control flow analysis from going into trunk (outright collisions etc.

[Cython] Control Flow

2011-05-27 Thread Vitja Makarov
I've recently fixed some issues: - closure variables were not tracked - scoped expression variables were initialized to None So, I should fix broken tests, here are some of them: nogil (should be fixed) purecdef (upstream) cfunc_directive_in_pyclass (upstream) bufaccess_noassignT444 (should be

Re: [Cython] Control Flow

2011-05-27 Thread Dag Sverre Seljebotn
On 05/27/2011 04:27 PM, Vitja Makarov wrote: I've recently fixed some issues: - closure variables were not tracked - scoped expression variables were initialized to None So, I should fix broken tests, here are some of them: nogil (should be fixed) purecdef (upstream) cfunc_directive_in_pyc

Re: [Cython] [cython] Openmp (#30)

2011-05-27 Thread mark florisson
On 27 May 2011 16:15, Dag Sverre Seljebotn wrote: > On 05/27/2011 03:54 PM, Stefan Behnel wrote: >> >> [regarding the code for analysing uninitialised variables in the OpenMP >> branch] >> >> dagss, 27.05.2011 10:32: >>> >>> I suggest this: >>> >>> a) Vitja and Stefan notifies Mark of any issues t

[Cython] Bug in ord(Py_UNICODE) optimization

2011-05-27 Thread John Ehresman
Hi, ord() applied to a Py_UNICODE typed variable seems to yield a 1 character unicode string rather than an integer. The following doctest fails when added to unicodefunction.pyx: def Py_UNICODE_ord(unicode s): """ >>> Py_UNICODE_ord(u' ') 32 """ cdef Py_UNICODE u u =

[Cython] Redundant Cython exception message strings

2011-05-27 Thread Stefan Behnel
Hi, I recently stumbled over a tradeoff question with AttributeError, and now found the same situation for UnboundLocalError in Vitja's control flow branch. So here it is. When we raise an exception several times in different parts of the code with a message that only differs slightly each t

Re: [Cython] Redundant Cython exception message strings

2011-05-27 Thread Robert Bradshaw
On Fri, May 27, 2011 at 3:32 PM, Stefan Behnel wrote: > Hi, > > I recently stumbled over a tradeoff question with AttributeError, and now > found the same situation for UnboundLocalError in Vitja's control flow > branch. So here it is. > > When we raise an exception several times in different part

Re: [Cython] Broken tests

2011-05-27 Thread Robert Bradshaw
On Fri, May 27, 2011 at 6:16 AM, Vitja Makarov wrote: > 2011/5/27 Dag Sverre Seljebotn : >> On 05/27/2011 02:41 PM, Vitja Makarov wrote: >>> >>> 2011/5/27 Stefan Behnel: Hi, could we please make it a requirement to run the complete test suite after a branch merge? Or

Re: [Cython] Bug in ord(Py_UNICODE) optimization

2011-05-27 Thread Stefan Behnel
John Ehresman, 27.05.2011 21:55: ord() applied to a Py_UNICODE typed variable seems to yield a 1 character unicode string rather than an integer. The following doctest fails when added to unicodefunction.pyx: def Py_UNICODE_ord(unicode s): """ >>> Py_UNICODE_ord(u' ') 32 """

Re: [Cython] Control Flow

2011-05-27 Thread Robert Bradshaw
On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov wrote: > I've recently fixed some issues: > >  - closure variables were not tracked >  - scoped expression variables were initialized to None > > So, I should fix broken tests, here are some of them: > > nogil (should be fixed) > purecdef (upstream) >