Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-29 Thread Victor Makarov
2014/1/29 Stefan Behnel : > Victor Makarov, 26.01.2014 20:15: >> Fixed here >> https://github.com/cython/cython/commit/9f7256fd07961b912d2224d995533c821441381b > > Hmm, it's unfortunate that this needs to be disabled. > > I guess the correct way to eventually implement this would be by creating a

Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-29 Thread Stefan Behnel
Victor Makarov, 26.01.2014 20:15: > Fixed here > https://github.com/cython/cython/commit/9f7256fd07961b912d2224d995533c821441381b Hmm, it's unfortunate that this needs to be disabled. I guess the correct way to eventually implement this would be by creating a new control flow block also for RHS

Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-26 Thread Victor Makarov
2014/1/24 Stefan Behnel : > Victor Makarov, 23.01.2014 21:02: >> I'd like to fix this if you don't mind. > > Oh, I certainly don't mind. :) > Fixed here https://github.com/cython/cython/commit/9f7256fd07961b912d2224d995533c821441381b -- vitja. ___ c

Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-23 Thread Stefan Behnel
Victor Makarov, 23.01.2014 21:02: > I'd like to fix this if you don't mind. Oh, I certainly don't mind. :) Stefan ___ cython-devel mailing list cython-devel@python.org https://mail.python.org/mailman/listinfo/cython-devel

Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-23 Thread Victor Makarov
2014/1/23 Syam Gadde : > On 01/23/2014 01:04 PM, Stefan Behnel wrote: >> >> BTW, thanks for cutting down the code to a short and easy to analyse test >> case, but if the original code really has a control flow like that, there >> might be some space left for improved clarity. > > > Absolutely. In

Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-23 Thread Syam Gadde
On 01/23/2014 01:04 PM, Stefan Behnel wrote: BTW, thanks for cutting down the code to a short and easy to analyse test case, but if the original code really has a control flow like that, there might be some space left for improved clarity. Absolutely. In the wild, it manifested itself in PyFF

Re: [Cython] segfault due to using DECREF instead of XDECREF

2014-01-23 Thread Stefan Behnel
Syam Gadde, 21.01.2014 23:00: > It seems that cython's static code analysis is failing on the following > code. It thinks that a particular variable (myobject2) must not be > NULL, but in fact it is, so the __Pyx_DECREF_SET segfaults. This came > from third-party code, so I could fix it with an e