Re: [Cython] Py_UNICODE* string support

2013-03-04 Thread Stefan Behnel
Nikita Nemkin, 04.03.2013 18:39: > On Mon, 04 Mar 2013 01:56:59 +0600, Stefan Behnel wrote: >> As one little nit-pick, may I ask you to rename the new name references >> to "unicode" into "py_unicode" in your code? For example, "is_unicode", >> "get_unicode_const", "unicode_const_index", etc. Given

Re: [Cython] Py_UNICODE* string support

2013-03-04 Thread Nikita Nemkin
On Mon, 04 Mar 2013 01:56:59 +0600, Stefan Behnel wrote: As one little nit-pick, may I ask you to rename the new name references to "unicode" into "py_unicode" in your code? For example, "is_unicode", "get_unicode_const", "unicode_const_index", etc. Given that Py_UNICODE is no longer the na

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Stefan Behnel
Stefan Behnel, 03.03.2013 20:41: > Nikita Nemkin, 03.03.2013 14:40: >> Please reconsider your decision wrt C-level literals. >> I believe that nogil code and a bit of efficiency (on 3.3) justify their >> existence. (char* literals do have C-level literals, Py_UNICODE* is in >> the same basket when

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Stefan Behnel
Nikita Nemkin, 03.03.2013 14:40: > Please reconsider your decision wrt C-level literals. > I believe that nogil code and a bit of efficiency (on 3.3) justify their > existence. (char* literals do have C-level literals, Py_UNICODE* is in > the same basket when it comes to Windows code). > The code t

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Nikita Nemkin
On Sun, 03 Mar 2013 15:32:36 +0600, Stefan Behnel wrote: 1) I would like to get rid of UnicodeConst. A Py_UNICODE* is not different from any other C array, except that it can coerce to and from Unicode strings. So the representation of a literal should be a (properly reference counted) Pyth

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Stefan Behnel
Nikita Nemkin, 03.03.2013 09:25: > On Sun, 03 Mar 2013 13:52:49 +0600, Stefan Behnel wrote: >> Are you aware that Py_UNICODE is deprecated as of Py3.3? >> >> http://docs.python.org/3.4/c-api/unicode.html >> >> Your changes look a bit excessive for supporting something that's >> inefficient in recen

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Nikita Nemkin
On Sun, 03 Mar 2013 13:52:49 +0600, Stefan Behnel wrote: Are you aware that Py_UNICODE is deprecated as of Py3.3? http://docs.python.org/3.4/c-api/unicode.html Your changes look a bit excessive for supporting something that's inefficient in recent Python versions and basically "dead". Yes

Re: [Cython] Py_UNICODE* string support

2013-03-02 Thread Stefan Behnel
Nikita Nemkin, 03.03.2013 08:39: > Please review my feature proposal to add Py_UNICODE* string support > for better Windows interoperability: > https://github.com/cython/cython/pull/191 > > This is motivated by my current work that involves calling lots of Windows > APIs. > > If people are intere

[Cython] Py_UNICODE* string support

2013-03-02 Thread Nikita Nemkin
Hi, Please review my feature proposal to add Py_UNICODE* string support for better Windows interoperability: https://github.com/cython/cython/pull/191 This is motivated by my current work that involves calling lots of Windows APIs. If people are interested I can elaborate on some important p