Re: [Cython] PyUnicode_Tailmatch

2015-07-07 Thread Robert Bradshaw
On Tue, Jul 7, 2015 at 12:07 PM, Stefan Behnel wrote: > Robert Bradshaw schrieb am 07.07.2015 um 19:05: >> On Tue, Jul 7, 2015 at 8:11 AM, Josh Ayers wrote: >>> In the function __Pyx_PyUnicode_Tailmatch, the return type of >>> PyUnicode_Tailmatch is assumed to be in int. See line 543 of >>> Cytho

Re: [Cython] PyUnicode_Tailmatch

2015-07-07 Thread Stefan Behnel
Robert Bradshaw schrieb am 07.07.2015 um 19:05: > On Tue, Jul 7, 2015 at 8:11 AM, Josh Ayers wrote: >> In the function __Pyx_PyUnicode_Tailmatch, the return type of >> PyUnicode_Tailmatch is assumed to be in int. See line 543 of >> Cython/Utility/StringTools.c. >> >> PyUnicode_Tailmatch actually r

Re: [Cython] PyUnicode_Tailmatch

2015-07-07 Thread Robert Bradshaw
Fixed (though I'm inclined to agree with the assessment that this choice of return type was a bug in the first place). https://github.com/cython/cython/commit/0a5890216d29d7bce941c9ab5cb0cb818eed643d On Tue, Jul 7, 2015 at 8:11 AM, Josh Ayers wrote: > Cython devs, > > In the function __Pyx_PyUni

[Cython] PyUnicode_Tailmatch

2015-07-07 Thread Josh Ayers
Cython devs, In the function __Pyx_PyUnicode_Tailmatch, the return type of PyUnicode_Tailmatch is assumed to be in int. See line 543 of Cython/Utility/StringTools.c. PyUnicode_Tailmatch actually returns a Py_ssize_t. See: https://docs.python.org/3/c-api/unicode.html#c.PyUnicode_Tailmatch. Fo