Re: [Cython] PyPy3 fixes

2015-03-19 Thread Robert Bradshaw
On Thu, Mar 19, 2015 at 8:13 AM, Lisandro Dalcin wrote: > On 18 March 2015 at 17:07, Stefan Behnel wrote: >> LGTM. I tend to use the shorter "#ifndef" instead of "#if !defined()", >> though. > > Do you want me to change it in master? No problem, just ask for it. Go for it.

Re: [Cython] PyPy3 fixes

2015-03-19 Thread Lisandro Dalcin
On 18 March 2015 at 17:07, Stefan Behnel wrote: > LGTM. I tend to use the shorter "#ifndef" instead of "#if !defined()", though. Do you want me to change it in master? No problem, just ask for it. -- Lisandro Dalcin Research Scientist Computer, Electrical and Mathematical Sciences

Re: [Cython] PyPy3 fixes

2015-03-18 Thread Stefan Behnel
Lisandro Dalcin schrieb am 08.03.2015 um 20:25: > 1) Stefan, I had to push this fix, just to be sure, please double check. > > https://github.com/cython/cython/commit/6bd3f7b9e494d1259082aecfc0366da15fc105ec Thanks - sorry for the bug. > 2) PyPy3 defines some legacy (Py2) Py_TPFLAGS_XXX values.

[Cython] PyPy3 fixes

2015-03-08 Thread Lisandro Dalcin
1) Stefan, I had to push this fix, just to be sure, please double check. https://github.com/cython/cython/commit/6bd3f7b9e494d1259082aecfc0366da15fc105ec 2) PyPy3 defines some legacy (Py2) Py_TPFLAGS_XXX values. Do you like the following fix? IOW, I check if the value is #define'd, if not I #defi