Re: [Cython] Control Flow

2011-05-30 Thread Stefan Behnel
Vitja Makarov, 30.05.2011 22:15: 2011/5/30 Stefan Behnel: Vitja Makarov, 30.05.2011 20:53: I see sigsegv in lxml tests: 1222/1364 ( 89.6%): test_xmlschema_import_file (lxml.tests.test_xmlschema.ETreeXMLSchemaTestCase) ... Segmentation fault https://sage.math.washington.edu:8091/hudson/job/cy

Re: [Cython] Control Flow

2011-05-30 Thread Vitja Makarov
2011/5/30 Stefan Behnel : > Vitja Makarov, 30.05.2011 20:53: >> >> I see sigsegv in lxml tests: >> >> 1222/1364 ( 89.6%): test_xmlschema_import_file >> (lxml.tests.test_xmlschema.ETreeXMLSchemaTestCase) ... Segmentation >> fault >> >> https://sage.math.washington.edu:8091/hudson/job/cython-devel-lx

Re: [Cython] Control Flow

2011-05-30 Thread Stefan Behnel
Vitja Makarov, 30.05.2011 20:53: I see sigsegv in lxml tests: 1222/1364 ( 89.6%): test_xmlschema_import_file (lxml.tests.test_xmlschema.ETreeXMLSchemaTestCase) ... Segmentation fault https://sage.math.washington.edu:8091/hudson/job/cython-devel-lxml-trunk-py27/890/console Is that control flow r

Re: [Cython] Control Flow

2011-05-30 Thread Vitja Makarov
2011/5/29 Vitja Makarov : > 2011/5/29 Stefan Behnel : >> Vitja Makarov, 29.05.2011 11:17: >>> >>> 2011/5/29 Stefan Behnel: Vitja Makarov, 29.05.2011 10:11: > > I've started new branch called control_flow_fixes. I think you can safely apply the subsequent fixes to the mas

Re: [Cython] Control Flow

2011-05-29 Thread Vitja Makarov
2011/5/29 Stefan Behnel : > Vitja Makarov, 29.05.2011 11:17: >> >> 2011/5/29 Stefan Behnel: >>> >>> Vitja Makarov, 29.05.2011 10:11: I've started new branch called control_flow_fixes. >>> >>> I think you can safely apply the subsequent fixes to the master branch, >>> now >>> that the feat

Re: [Cython] Control Flow

2011-05-29 Thread Stefan Behnel
Vitja Makarov, 29.05.2011 11:17: 2011/5/29 Stefan Behnel: Vitja Makarov, 29.05.2011 10:11: I've started new branch called control_flow_fixes. I think you can safely apply the subsequent fixes to the master branch, now that the feature is in. That will also give you broader feedback from Jenki

Re: [Cython] Control Flow

2011-05-29 Thread Vitja Makarov
2011/5/29 Stefan Behnel : > Vitja Makarov, 29.05.2011 10:11: >> >> 2011/5/28 Stefan Behnel: >>> >>> Stefan Behnel, 28.05.2011 18:06: Let's see how much of Sage we break. >>> >>> ... quite a bit. From a superficial glance, there seem to be some real >>> bugs, > > Bugs in Sage, to be clear.

Re: [Cython] Control Flow

2011-05-29 Thread Stefan Behnel
Vitja Makarov, 29.05.2011 10:11: 2011/5/28 Stefan Behnel: Stefan Behnel, 28.05.2011 18:06: Let's see how much of Sage we break. ... quite a bit. From a superficial glance, there seem to be some real bugs, Bugs in Sage, to be clear. but most of the failures and warnings are most likely j

Re: [Cython] Control Flow

2011-05-29 Thread Vitja Makarov
2011/5/28 Stefan Behnel : > Stefan Behnel, 28.05.2011 18:06: >> >> Let's see how much of Sage we break. > > ... quite a bit. From a superficial glance, there seem to be some real bugs, > but most of the failures and warnings are most likely just uninitialised > variables that are expected to be Non

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Stefan Behnel, 28.05.2011 18:06: Let's see how much of Sage we break. ... quite a bit. From a superficial glance, there seem to be some real bugs, but most of the failures and warnings are most likely just uninitialised variables that are expected to be None. https://sage.math.washington.ed

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Vitja, here are some more quirks, but they are minor issues. I'll commit my changes to lxml to keep it working, and then merge in the branch. It's certainly in a "good enough for a merge" state. I'm actually surprised how few problems I had to fix, given how old the code in lxml is by now. L

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Vitja Makarov, 28.05.2011 16:58: -Wextra enables "maybe uninitialized" warning and unused entry. Interesting: cdef int _raise_if_stored(self) except -1: if self._exc_info is None: return 0 type, value, traceback = self._exc_info self._exc_info = None

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Vitja Makarov, 28.05.2011 16:58: 2011/5/28 Stefan Behnel: Vitja Makarov, 28.05.2011 14:12: 2011/5/28 Stefan Behnel: Ok, I think we're done then, right? Anything else to do before merging it back? I hope so ;) I gave your branch a test with lxml and it spit out a couple of missing initial

Re: [Cython] Control Flow

2011-05-28 Thread Vitja Makarov
2011/5/28 Stefan Behnel : > Vitja Makarov, 28.05.2011 14:12: >> >> 2011/5/28 Stefan Behnel: >>> >>> Ok, I think we're done then, right? Anything else to do before merging it >>> back? >> >> I hope so ;) > > I gave your branch a test with lxml and it spit out a couple of missing > initialisation war

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Vitja Makarov, 28.05.2011 14:12: 2011/5/28 Stefan Behnel: Ok, I think we're done then, right? Anything else to do before merging it back? I hope so ;) I gave your branch a test with lxml and it spit out a couple of missing initialisation warnings. Most of them were due to the usage of C out

Re: [Cython] Control Flow

2011-05-28 Thread Vitja Makarov
2011/5/28 Stefan Behnel : > Vitja Makarov, 28.05.2011 13:48: >> >> 2011/5/28 Stefan Behnel: >>> >>> Vitja Makarov, 28.05.2011 11:48: 2011/5/28 Robert Bradshaw: > > On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov wrote: >> >> I've recently fixed some issues: >> >>  -

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Vitja Makarov, 28.05.2011 13:48: 2011/5/28 Stefan Behnel: Vitja Makarov, 28.05.2011 11:48: 2011/5/28 Robert Bradshaw: On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov wrote: I've recently fixed some issues: - closure variables were not tracked - scoped expression variables were initiali

Re: [Cython] Control Flow

2011-05-28 Thread Vitja Makarov
2011/5/28 Stefan Behnel : > Vitja Makarov, 28.05.2011 11:48: >> >> 2011/5/28 Robert Bradshaw: >>> >>> On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov wrote: I've recently fixed some issues:  - closure variables were not tracked  - scoped expression variables were initialized

Re: [Cython] Control Flow

2011-05-28 Thread Stefan Behnel
Vitja Makarov, 28.05.2011 11:48: 2011/5/28 Robert Bradshaw: On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov wrote: I've recently fixed some issues: - closure variables were not tracked - scoped expression variables were initialized to None So, I should fix broken tests, here are some of th

Re: [Cython] Control Flow

2011-05-28 Thread Vitja Makarov
2011/5/28 Robert Bradshaw : > On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov > wrote: >> I've recently fixed some issues: >> >>  - closure variables were not tracked >>  - scoped expression variables were initialized to None >> >> So, I should fix broken tests, here are some of them: >> >> nogil

Re: [Cython] Control Flow

2011-05-27 Thread Robert Bradshaw
On Fri, May 27, 2011 at 7:27 AM, Vitja Makarov wrote: > I've recently fixed some issues: > >  - closure variables were not tracked >  - scoped expression variables were initialized to None > > So, I should fix broken tests, here are some of them: > > nogil (should be fixed) > purecdef (upstream) >

Re: [Cython] Control Flow

2011-05-27 Thread Dag Sverre Seljebotn
On 05/27/2011 04:27 PM, Vitja Makarov wrote: I've recently fixed some issues: - closure variables were not tracked - scoped expression variables were initialized to None So, I should fix broken tests, here are some of them: nogil (should be fixed) purecdef (upstream) cfunc_directive_in_pyc

[Cython] Control Flow

2011-05-27 Thread Vitja Makarov
I've recently fixed some issues: - closure variables were not tracked - scoped expression variables were initialized to None So, I should fix broken tests, here are some of them: nogil (should be fixed) purecdef (upstream) cfunc_directive_in_pyclass (upstream) bufaccess_noassignT444 (should be

Re: [Cython] Control flow graph

2011-04-14 Thread Stefan Behnel
Vitja Makarov, 14.04.2011 09:27: Can I use cython-generators project on hudson for control-flow tests? So I'll move cf branch development to my master branch. Sure. I renamed the tab to "cython-vitek". It's your repo, use it as you see fit. Stefan

Re: [Cython] Control flow graph

2011-04-14 Thread Vitja Makarov
Can I use cython-generators project on hudson for control-flow tests? So I'll move cf branch development to my master branch. -- vitja. ___ cython-devel mailing list cython-devel@python.org http://mail.python.org/mailman/listinfo/cython-devel

Re: [Cython] Control flow graph

2011-03-02 Thread Vitja Makarov
2011/2/28 Vitja Makarov : > 2011/2/23 Vitja Makarov : >> 2011/2/23 Vitja Makarov : >>> 2011/2/22 Stefan Behnel : Vitja Makarov, 20.02.2011 18:23: > > 2011/2/16 Vitja Makarov: >> >> Hmm... both python and codespeaks in the thread Yes, we should keep it to cython-devel

Re: [Cython] Control flow graph

2011-02-28 Thread Vitja Makarov
2011/2/23 Vitja Makarov : > 2011/2/23 Vitja Makarov : >> 2011/2/22 Stefan Behnel : >>> Vitja Makarov, 20.02.2011 18:23: 2011/2/16 Vitja Makarov: > > Hmm... both python and codespeaks in the thread >>> >>> Yes, we should keep it to cython-devel only. Sorry for mixing it up. >>> >>>

Re: [Cython] Control flow graph

2011-02-22 Thread Vitja Makarov
2011/2/22 Stefan Behnel : > Vitja Makarov, 20.02.2011 18:23: >> >> 2011/2/16 Vitja Makarov: >>> >>> Hmm... both python and codespeaks in the thread > > Yes, we should keep it to cython-devel only. Sorry for mixing it up. > > >>> Here is my commit it's mostly broken now but anyway >>> >>> https://gi

Re: [Cython] Control flow graph

2011-02-22 Thread Stefan Behnel
Vitja Makarov, 20.02.2011 18:23: 2011/2/16 Vitja Makarov: Hmm... both python and codespeaks in the thread Yes, we should keep it to cython-devel only. Sorry for mixing it up. Here is my commit it's mostly broken now but anyway https://github.com/vitek/cython/commit/5579b23c3c1c06981331b6427

Re: [Cython] Control flow graph

2011-02-20 Thread Vitja Makarov
2011/2/16 Vitja Makarov : > 2011/2/15 Stefan Behnel : >> Robert Bradshaw, 15.02.2011 08:21: >>> >>> On Mon, Feb 14, 2011 at 9:49 PM, Vitja Makarov wrote: 2011/2/15 Robert Bradshaw: > > On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov wrote: >> >> Hi! >> >> In order

Re: [Cython] Control flow graph

2011-02-15 Thread Vitja Makarov
2011/2/15 Stefan Behnel : > Robert Bradshaw, 15.02.2011 08:21: >> >> On Mon, Feb 14, 2011 at 9:49 PM, Vitja Makarov wrote: >>> >>> 2011/2/15 Robert Bradshaw: On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov wrote: > > Hi! > > In order to implement "reaching definitions" alg

Re: [Cython] Control flow graph

2011-02-15 Thread Vitja Makarov
2011/2/15 Stefan Behnel : > Robert Bradshaw, 15.02.2011 08:21: >> >> On Mon, Feb 14, 2011 at 9:49 PM, Vitja Makarov wrote: >>> >>> 2011/2/15 Robert Bradshaw: On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov wrote: > > Hi! > > In order to implement "reaching definitions" alg

Re: [Cython] Control flow graph

2011-02-15 Thread Dag Sverre Seljebotn
On 02/15/2011 08:21 AM, Robert Bradshaw wrote: On Mon, Feb 14, 2011 at 9:49 PM, Vitja Makarov wrote: 2011/2/15 Robert Bradshaw: On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov wrote: Hi! In order to implement "reaching definitions" algorithm. I'm now working on control-flo

Re: [Cython] Control flow graph

2011-02-14 Thread Stefan Behnel
Robert Bradshaw, 15.02.2011 08:21: On Mon, Feb 14, 2011 at 9:49 PM, Vitja Makarov wrote: 2011/2/15 Robert Bradshaw: On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov wrote: Hi! In order to implement "reaching definitions" algorithm. I'm now working on control-flow (or data-flow) graph. Here is

Re: [Cython] Control flow graph

2011-02-14 Thread Robert Bradshaw
On Mon, Feb 14, 2011 at 9:49 PM, Vitja Makarov wrote: > 2011/2/15 Robert Bradshaw : >> On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov >> wrote: >>> Hi! >>> >>> In order to implement "reaching definitions" algorithm. >>> I'm now working on control-flow (or data-flow) graph. >>> >>> Here is funny

Re: [Cython] Control flow graph

2011-02-14 Thread Vitja Makarov
2011/2/15 Vitja Makarov : > 2011/2/15 Robert Bradshaw : >> On Sun, Feb 13, 2011 at 11:40 PM, Vitja Makarov >> wrote: >>> Hi! >>> >>> In order to implement "reaching definitions" algorithm. >>> I'm now working on control-flow (or data-flow) graph. >>> >>> Here is funny picture made with graphviz ;

Re: [Cython] Control flow graph

2011-02-14 Thread Greg Ewing
Vitja Makarov wrote: Here is funny picture made with graphviz ;) http://piccy.info/view3/1099337/ca29d7054d09bd0503cefa25f5f49420/1200/ Gives the term "spaghetti code" a whole new meaning! -- Greg ___ cython-devel mailing list cython-devel@python.

Re: [Cython] Control flow graph

2011-02-14 Thread Dag Sverre Seljebotn
On 02/14/2011 08:40 AM, Vitja Makarov wrote: Hi! In order to implement "reaching definitions" algorithm. I'm now working on control-flow (or data-flow) graph. Here is funny picture made with graphviz ;) http://piccy.info/view3/1099337/ca29d7054d09bd0503cefa25f5f49420/1200/ Cool! This wi

Re: [Cython] Control flow graph

2011-02-14 Thread Stefan Behnel
Vitja Makarov, 14.02.2011 08:40: In order to implement "reaching definitions" algorithm. I'm now working on control-flow (or data-flow) graph. Cool. Another good topic for the workshop. I've added it to the list on the wiki page. Note that it's related to the NameNode graph, but not completely

[Cython] Control flow graph

2011-02-13 Thread Vitja Makarov
Hi! In order to implement "reaching definitions" algorithm. I'm now working on control-flow (or data-flow) graph. Here is funny picture made with graphviz ;) http://piccy.info/view3/1099337/ca29d7054d09bd0503cefa25f5f49420/1200/ -- vitja. ___ cython-