Re: [Cython] [PATCH] make memoryviews work when strides is NULL (unfinished)

2012-09-19 Thread mark florisson
On 19 September 2012 08:03, Christoph Groth wrote: > Hi Mark, > >> Thanks for the patch, it looks fine to me. If you want, you could make >> a pull request and I'll merge it. > > Ok, the pull request is here: > https://github.com/cython/cython/pull/150 > > Please double-check that the dereferencin

Re: [Cython] [PATCH] make memoryviews work when strides is NULL (unfinished)

2012-09-19 Thread Christoph Groth
Hi Mark, > Thanks for the patch, it looks fine to me. If you want, you could make > a pull request and I'll merge it. Ok, the pull request is here: https://github.com/cython/cython/pull/150 Please double-check that the dereferencing of buf->strides in PyErr_SetString(PyExc_ValueError is still sa

Re: [Cython] [PATCH] make memoryviews work when strides is NULL (unfinished)

2012-09-18 Thread mark florisson
On 18 September 2012 15:19, Christoph Groth wrote: > Hi, > > Thanks a lot for the recently added generic memoryview support, it's > just what we needed to optimize an important part of our program. > > However, I believe that there's a problem with Cython's support for > objects which do not provi

[Cython] [PATCH] make memoryviews work when strides is NULL (unfinished)

2012-09-18 Thread Christoph Groth
Hi, Thanks a lot for the recently added generic memoryview support, it's just what we needed to optimize an important part of our program. However, I believe that there's a problem with Cython's support for objects which do not provide "strides" information (because they are C-contiguous). The b