Re: [Cython] Preparing Cython 3.0 with breaking changes

2018-08-20 Thread Erik Bray
On Sat, Aug 18, 2018 at 9:19 AM Stefan Behnel wrote: > > Hi all, > > following the versioning discussion, I created a milestone to collect > (breaking) changes that should go into the future Cython 3.0 release. > > https://github.com/cython/cython/milestone/58 > > While a major version change is a

Re: [Cython] Cython 0.29 – or 29.0 ?

2018-08-17 Thread Erik Bray
On Fri, Aug 17, 2018 at 12:03 PM Stefan Behnel wrote: > > Robert Bradshaw schrieb am 16.08.2018 um 00:48: > > If we're going to ditch the 0.x, I'd go for 1.0 as well. I'm a huge fan of > > semantic versioning. > > I'm ok with it, just fear that it might become excessive for Cython (ok, > I'm the o

Re: [Cython] Should we start requiring "language_level=2" for .pyx files?

2018-05-31 Thread Erik Bray
On Mon, May 28, 2018 at 8:56 PM, Stefan Behnel wrote: > Hi, > > Python 3 is clearly taking over the world these days, so it starts feeling > arcane to require Py2 syntax in .pyx files. Increasingly, it means that > people cannot just rename .py files anymore to start optimising them, > because the

Re: [Cython] Bug with inlined functions that access globals

2017-11-24 Thread Erik Bray
On Fri, Nov 24, 2017 at 2:16 PM, Stefan Behnel wrote: > Erik Bray schrieb am 24.11.2017 um 13:44: >> I think maybe I've seen this brought up once or twice before in the >> past, but with no real discussion. There is a slightly unpythonic >> problem with using cpdef inl

[Cython] Bug with inlined functions that access globals

2017-11-24 Thread Erik Bray
Hi, I think maybe I've seen this brought up once or twice before in the past, but with no real discussion. There is a slightly unpythonic problem with using cpdef inline functions defined in a .pxd file that happen to access global variables. For example: $ cat foo.pxd FOO_A = 1 cpdef inline f

Re: [Cython] Why does embed-position use relative filenames?

2017-10-27 Thread Erik Bray
On Fri, Oct 27, 2017 at 11:35 AM, Jeroen Demeyer wrote: > My use case is for calling Cython at runtime. For example, using > cython.inline or %%cython or the SageMath-specific cython() function. In > that case, absolute paths make the most sense since you want to support the > user running Cython

Re: [Cython] Why does embed-position use relative filenames?

2017-10-25 Thread Erik Bray
On Wed, Oct 25, 2017 at 2:50 PM, Jeroen Demeyer wrote: > On 2017-10-25 14:42, Erik Bray wrote: >> >> IMO the relative paths make more sense in a way, because when the >> module is installed the path is relative to the file's location >> relative to its `sys.path`

Re: [Cython] Why does embed-position use relative filenames?

2017-10-25 Thread Erik Bray
On Wed, Oct 25, 2017 at 2:50 PM, Jeroen Demeyer wrote: > On 2017-10-25 14:42, Erik Bray wrote: >> >> IMO the relative paths make more sense in a way, because when the >> module is installed the path is relative to the file's location >> relative to its `sys.path`

Re: [Cython] Why does embed-position use relative filenames?

2017-10-25 Thread Erik Bray
On Wed, Oct 25, 2017 at 2:24 PM, Jeroen Demeyer wrote: > When Cython is run with the --embed-position option (or when > Cython.Compiler.Options.embed_pos_in_docstring is true), Cython writes > headers in the docstring like > > File: sage/rings/integer.pyx (starting at line 358) > > The filenames t

Re: [Cython] Minor issue with running tests and -Wlong-long

2016-09-05 Thread Erik Bray
On Sat, Sep 3, 2016 at 10:46 AM, Stefan Behnel wrote: > Erik Bray schrieb am 25.04.2016 um 17:18: >> As some of you already know I've been doing some work on Cython on >> Cygwin [in the process I I'm constantly mixing the two up in speech, >> but maybe in writing

Re: [Cython] Suggested action for "Python.h not found"

2016-06-09 Thread Erik Bray
On Thu, Jun 9, 2016 at 7:37 AM, Elizabeth A. Fischer wrote: >> Or maybe by default it can just point the user to an Installation Page >> which explains in detail what needs to be done to get those headers for >> various systems ? > > > I think having this information on an installation instruction

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-06-06 Thread Erik Bray
On Wed, May 18, 2016 at 12:22 AM, Robert Bradshaw wrote: > On Fri, May 13, 2016 at 4:26 AM, Erik Bray wrote: >> On Thu, May 12, 2016 at 12:55 AM, Greg Ewing >> wrote: >>> Erik Bray wrote: >>>> >>>> A developer who writes some code that >

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-05-13 Thread Erik Bray
On Thu, May 12, 2016 at 12:55 AM, Greg Ewing wrote: > Erik Bray wrote: >> >> A developer who writes some code that >> happens to use long double isn't going to think themselves "Gosh, I >> guess I can't accept `long double` here because it may caus

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-05-11 Thread Erik Bray
On Tue, May 10, 2016 at 8:01 AM, Robert Bradshaw wrote: > On Wed, May 4, 2016 at 8:01 AM, Erik Bray wrote: >> On Tue, May 3, 2016 at 7:15 PM, Robert Bradshaw wrote: >>> On Tue, May 3, 2016 at 3:04 AM, Erik Bray wrote: >>>> I agree that it would be safest not

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-05-04 Thread Erik Bray
On Tue, May 3, 2016 at 7:15 PM, Robert Bradshaw wrote: > On Tue, May 3, 2016 at 3:04 AM, Erik Bray wrote: >> >> On Thu, Apr 28, 2016 at 9:29 AM, Robert Bradshaw >> wrote: >> > On Wed, Apr 27, 2016 at 3:07 AM, Erik Bray >> > wrote: >> >> >

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-05-03 Thread Erik Bray
On Thu, Apr 28, 2016 at 9:29 AM, Robert Bradshaw wrote: > On Wed, Apr 27, 2016 at 3:07 AM, Erik Bray wrote: >> >> On Tue, Apr 26, 2016 at 10:55 PM, Robert Bradshaw >> wrote: >> > On Tue, Apr 26, 2016 at 8:36 AM, Erik Bray >> > wrote: >> >> &g

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-04-27 Thread Erik Bray
On Wed, Apr 27, 2016 at 12:07 PM, Erik Bray wrote: > On Tue, Apr 26, 2016 at 10:55 PM, Robert Bradshaw wrote: >> On Tue, Apr 26, 2016 at 8:36 AM, Erik Bray wrote: >>> >>> On Tue, Apr 26, 2016 at 5:16 PM, Dima Pasechnik >>> wrote: >>> > Hi, >

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-04-27 Thread Erik Bray
On Tue, Apr 26, 2016 at 10:55 PM, Robert Bradshaw wrote: > On Tue, Apr 26, 2016 at 8:36 AM, Erik Bray wrote: >> >> On Tue, Apr 26, 2016 at 5:16 PM, Dima Pasechnik >> wrote: >> > Hi, >> > certainly we did something with Sage on cygwin to work around these.

Re: [Cython] Cygwin: Handling missing C99 long double functions

2016-04-26 Thread Erik Bray
at in cases where Cython generates code containing C math functions, it ought to support a fallback. This will require some feature checks so that Cython can generate wrappers, when necessary, around the double versions of those functions (as Numpy currently does). Erik > On Tue, Apr 26, 2016 a

[Cython] Cygwin: Handling missing C99 long double functions

2016-04-26 Thread Erik Bray
Hi again, Sorry if I'm spamming the list too much, but I've encountered another pretty serious and unfortunate issue with Cython on Cygwin. The problem now is that many of libm long double functions like sqrtl, tanl, etc. are missing on Cygwin (missing from newlib to be specific). I think this is

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-26 Thread Erik Bray
On Mon, Apr 11, 2016 at 7:49 PM, Ian Henriksen wrote: > On Mon, Apr 11, 2016 at 7:46 AM Erik Bray wrote: >> >> On Mon, Apr 11, 2016 at 2:51 PM, Nathaniel Smith wrote: >> > On Apr 11, 2016 04:18, "Erik Bray" wrote: >> >> >> >> On Fri, A

[Cython] Minor issue with running tests and -Wlong-long

2016-04-25 Thread Erik Bray
Hello, As some of you already know I've been doing some work on Cython on Cygwin [in the process I I'm constantly mixing the two up in speech, but maybe in writing I'll do better :)]. There are several issues with the tests on Cygwin, and that's one thing I'll work on. But a major annoyance I've

Re: [Cython] Cannot cythonize subclasses of setuptools.extension._Extension

2016-04-19 Thread Erik Bray
ols over all else. I'll see if I can reproduce it. Jason Coombs who mantains setuptools is usually quick to release bug fix versions if he gets a patch. Erik > On Mon, Apr 18, 2016 at 11:16 AM, Erik Bray wrote: >> >> On Sat, Apr 16, 2016 at 1:29 PM, Manuel Nuno Melo >> w

Re: [Cython] Cannot cythonize subclasses of setuptools.extension._Extension

2016-04-18 Thread Erik Bray
ing now. The local .eggs cache directory created for setup_requires downloads most certainly does not get added to easy_install.pth. Are you sure you're not thinking of `setup.py develop`? [1] https://pypi.python.org/pypi/d2to1 [2] https://bitbucket.org/dholth/setup-requires/src > On Sat, Apr 16,

Re: [Cython] Cannot cythonize subclasses of setuptools.extension._Extension

2016-04-16 Thread Erik Bray
in astropy_helpers which makes it possible, for example, to pull in Cython via setup_requires, but only if it's needed. Remind me on Monday and I can point out how it works. > On Apr 14, 2016 8:17 PM, "Matthew Brett" wrote: > > > > On Thu, Apr 14, 2016 at 6:0

Re: [Cython] Cannot cythonize subclasses of setuptools.extension._Extension

2016-04-14 Thread Erik Bray
On Wed, Apr 13, 2016 at 9:35 PM, Manuel Nuno Melo wrote: > Hello devs, > > I'm developing the setup.py for a scientific package, MDAnalysis (see PR > #799). We depend on distutils and setuptool. Namely, we use > setuptools.extension.Extension class for our extensions. > > Some older versions of se

Re: [Cython] cdef public declarations

2016-04-12 Thread Erik Bray
On Tue, Apr 12, 2016 at 10:36 AM, Jeroen Demeyer wrote: > (this thread is related to the thread "Question about how best require > compiler options for C sources") > > I have a question for Cython users and developers: are you sure that "cdef > public" actually works as documented at > http://docs

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-12 Thread Erik Bray
On Tue, Apr 12, 2016 at 10:27 AM, Jeroen Demeyer wrote: > On 2016-04-12 10:16, Erik Bray wrote: >> >> That said, I >> think it makes more sense for cythonize() to read the distutils >> options from the C source instead of the Cython source, though in >> practice

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-12 Thread Erik Bray
On Mon, Apr 11, 2016 at 7:49 PM, Ian Henriksen wrote: > That aside, I agree with Nathaniel that exporting public declarations as a > part of the > shared object interface was a design mistake. That aside, however, using an > api > declaration lets you get equivalent results without exposing anythi

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-12 Thread Erik Bray
On Mon, Apr 11, 2016 at 8:36 PM, Ian Henriksen wrote: > On Mon, Apr 11, 2016 at 11:50 AM Ian Henriksen > wrote: >> >> To answer the original question about define macros, it appears that the >> canonical >> way to pass preprocessor defines through distutils is to use the >> define_macros >> keywo

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-12 Thread Erik Bray
On Mon, Apr 11, 2016 at 7:38 PM, Jeroen Demeyer wrote: > On 2016-04-11 15:23, Erik Bray wrote: >> >> In this case I really do want the symbol "hello" to be >> exported by the DLL, as well as be understood between translation >> units making up the same librar

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-11 Thread Erik Bray
On Mon, Apr 11, 2016 at 2:51 PM, Nathaniel Smith wrote: > On Apr 11, 2016 04:18, "Erik Bray" wrote: >> >> On Fri, Apr 8, 2016 at 5:49 PM, Nathaniel Smith wrote: >> > Can you give a tiny concrete example? My questions are basic enough that >> > I >&

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-11 Thread Erik Bray
On Mon, Apr 11, 2016 at 2:51 PM, Nathaniel Smith wrote: > Now, back to your example: Here the caller and callee are both compiled into > the same shared library, so you don't want dllexport/dllimport at all, you > just want a shared-library-internal symbol, which as we see is much easier. Sorry,

Re: [Cython] Fwd: Question about how best require compiler options for C sources

2016-04-11 Thread Erik Bray
the command-line, and that seems the clearest to me. Best, Erik > On Apr 8, 2016 5:35 AM, "Erik Bray" wrote: >> >> Hi all, >> >> I'd like to call attention to an issue I've been looking into for the >> past couple days: >> >> https:

[Cython] Fwd: Question about how best require compiler options for C sources

2016-04-08 Thread Erik Bray
Hi all, I'd like to call attention to an issue I've been looking into for the past couple days: https://github.com/cython/cython/pull/360 To summarize the discussion, when building DLLs for Windows, functions that should be exported by that DLL must be marked __declspec(dllexport) in their decla