Re: [Cython] Shared utility Option vs. Compilation Directive

2025-03-03 Thread da-woods
Personally: I don't think 3 is worthwhile. I weakly prefer 1 to 2 on the basis that we were trying to get away from Options where possible.  However, this is probably a case where Options will usually be right (it forces a setting on every module that you're processing in a batch, which is wh

Re: [Cython] Shared utility Option vs. Compilation Directive

2025-03-03 Thread matus valo via cython-devel
> I don't think 3 is worthwhile. I tend to agree. > I weakly prefer 1 to 2 on the basis that we were trying to get away from Options where possible. I think I have the same opinion. `Option` variant is much simpler and I cannot see any benefit using a shared module with only a subset of .pyx fil

[Cython] Shared utility Option vs. Compilation Directive

2025-03-03 Thread matus valo via cython-devel
Hi All, Based on the comment https://github.com/cython/cython/pull/6531#discussion_r1975502026 I would like to start a discussion about using Option vs Compilation Directive. Basically, we have 3 options: 1. Use PR https://github.com/cython/cython/pull/6531 as is. I will proceed with the rest of