Re: [Cython] nonecheck and as_none_safe_node method

2013-03-04 Thread Zaur Shibzukhov
2013/3/5 Stefan Behnel > Zaur Shibzukhov, 05.03.2013 07:21: > > In ExprNodes.py there are several places where method `as_none_safe_node` > > was applied in order to wrap a node by NoneCheckNode. > > I think it would be resonable to apply that mostly only in cases when > > noncheck=True. > > > >

Re: [Cython] nonecheck and as_none_safe_node method

2013-03-04 Thread Stefan Behnel
Zaur Shibzukhov, 05.03.2013 07:21: > In ExprNodes.py there are several places where method `as_none_safe_node` > was applied in order to wrap a node by NoneCheckNode. > I think it would be resonable to apply that mostly only in cases when > noncheck=True. > > Here are possible changes in ExprNodes

Re: [Cython] nonecheck and as_none_safe_node method

2013-03-04 Thread Zaur Shibzukhov
2013/3/5 Zaur Shibzukhov > 2013/3/5 Zaur Shibzukhov > >> In ExprNodes.py there are several places where method `as_none_safe_node` >> was applied in order to wrap a node by NoneCheckNode. >> I think it would be resonable to apply that mostly only in cases when >> noncheck=True. >> >> Here are po

Re: [Cython] nonecheck and as_none_safe_node method

2013-03-04 Thread Zaur Shibzukhov
2013/3/5 Zaur Shibzukhov > In ExprNodes.py there are several places where method `as_none_safe_node` > was applied in order to wrap a node by NoneCheckNode. > I think it would be resonable to apply that mostly only in cases when > noncheck=True. > > Here are possible changes in ExprNodes.py: > >

[Cython] nonecheck and as_none_safe_node method

2013-03-04 Thread Zaur Shibzukhov
In ExprNodes.py there are several places where method `as_none_safe_node` was applied in order to wrap a node by NoneCheckNode. I think it would be resonable to apply that mostly only in cases when noncheck=True. Here are possible changes in ExprNodes.py: https://github.com/intellimath/cython/comm

Re: [Cython] Py_UNICODE* string support

2013-03-04 Thread Stefan Behnel
Nikita Nemkin, 04.03.2013 18:39: > On Mon, 04 Mar 2013 01:56:59 +0600, Stefan Behnel wrote: >> As one little nit-pick, may I ask you to rename the new name references >> to "unicode" into "py_unicode" in your code? For example, "is_unicode", >> "get_unicode_const", "unicode_const_index", etc. Given

Re: [Cython] Py_UNICODE* string support

2013-03-04 Thread Nikita Nemkin
On Mon, 04 Mar 2013 01:56:59 +0600, Stefan Behnel wrote: As one little nit-pick, may I ask you to rename the new name references to "unicode" into "py_unicode" in your code? For example, "is_unicode", "get_unicode_const", "unicode_const_index", etc. Given that Py_UNICODE is no longer the na

Re: [Cython] PR on refcounting memoryview buffers

2013-03-04 Thread Sturla Molden
Den 20. feb. 2013 kl. 11:55 skrev Sturla Molden : > > Den 18. feb. 2013 kl. 19:32 skrev Sturla Molden : > >> The problem this addresses is when GCC does not use atomic builtins and >> emits __synch_fetch_and_add_4 and __synch_fetch_and_sub_4 when Cython are >> internally refcounting memoryview