Re: [Cython] To Add datetime.pxd to cython.cpython

2013-03-03 Thread Zaur Shibzukhov
2013/3/3 Zaur Shibzukhov : > 2013/3/3 Zaur Shibzukhov : >> 2013/3/3 Zaur Shibzukhov : >>> 2013/3/2 Stefan Behnel : Hi, the last pull request looks good to me now. https://github.com/cython/cython/pull/189 Any more comments on it? >>> >>> As was suggested earlier,

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Stefan Behnel
Stefan Behnel, 03.03.2013 20:41: > Nikita Nemkin, 03.03.2013 14:40: >> Please reconsider your decision wrt C-level literals. >> I believe that nogil code and a bit of efficiency (on 3.3) justify their >> existence. (char* literals do have C-level literals, Py_UNICODE* is in >> the same basket when

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Stefan Behnel
Nikita Nemkin, 03.03.2013 14:40: > Please reconsider your decision wrt C-level literals. > I believe that nogil code and a bit of efficiency (on 3.3) justify their > existence. (char* literals do have C-level literals, Py_UNICODE* is in > the same basket when it comes to Windows code). > The code t

Re: [Cython] To Add datetime.pxd to cython.cpython

2013-03-03 Thread Zaur Shibzukhov
2013/3/3 Zaur Shibzukhov : > 2013/3/3 Zaur Shibzukhov : >> 2013/3/2 Stefan Behnel : >>> Hi, >>> >>> the last pull request looks good to me now. >>> >>> https://github.com/cython/cython/pull/189 >>> >>> Any more comments on it? >> >> As was suggested earlier, I added `import_datetime` inline functio

Re: [Cython] To Add datetime.pxd to cython.cpython

2013-03-03 Thread Zaur Shibzukhov
2013/3/3 Zaur Shibzukhov : > 2013/3/2 Stefan Behnel : >> Hi, >> >> the last pull request looks good to me now. >> >> https://github.com/cython/cython/pull/189 >> >> Any more comments on it? > > As was suggested earlier, I added `import_datetime` inline function to > initialize PyDateTime C API inst

Re: [Cython] To Add datetime.pxd to cython.cpython

2013-03-03 Thread Zaur Shibzukhov
2013/3/2 Stefan Behnel : > Hi, > > the last pull request looks good to me now. > > https://github.com/cython/cython/pull/189 > > Any more comments on it? > > Stefan > As was suggested earlier, I added `import_datetime` inline function to initialize PyDateTime C API instead of direct usage of "non-

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Nikita Nemkin
On Sun, 03 Mar 2013 15:32:36 +0600, Stefan Behnel wrote: 1) I would like to get rid of UnicodeConst. A Py_UNICODE* is not different from any other C array, except that it can coerce to and from Unicode strings. So the representation of a literal should be a (properly reference counted) Pyth

Re: [Cython] About IndexNode and unicode[index]

2013-03-03 Thread Zaur Shibzukhov
2013/3/2 Stefan Behnel : > Stefan Behnel, 28.02.2013 22:16: > > https://github.com/scoder/cython/commit/cc4f7daec3b1f19b5acaed7766e2b6f86902ad94 > > Stefan > I tried to build with that change. Tests `unicode_indexing` and `index` are passed. ___ cython-de

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Stefan Behnel
Nikita Nemkin, 03.03.2013 09:25: > On Sun, 03 Mar 2013 13:52:49 +0600, Stefan Behnel wrote: >> Are you aware that Py_UNICODE is deprecated as of Py3.3? >> >> http://docs.python.org/3.4/c-api/unicode.html >> >> Your changes look a bit excessive for supporting something that's >> inefficient in recen

Re: [Cython] Py_UNICODE* string support

2013-03-03 Thread Nikita Nemkin
On Sun, 03 Mar 2013 13:52:49 +0600, Stefan Behnel wrote: Are you aware that Py_UNICODE is deprecated as of Py3.3? http://docs.python.org/3.4/c-api/unicode.html Your changes look a bit excessive for supporting something that's inefficient in recent Python versions and basically "dead". Yes