Re: [Cython] read-only memory views

2012-09-19 Thread Robert Bradshaw
On Wed, Sep 19, 2012 at 12:06 AM, Christoph Groth wrote: > Robert Bradshaw > writes: > >> Coincidentally, I actually implemented rudimentary const support a >> couple of days ago. It's not perfect, but at least it allows you to >> provide the correct declarations to deal with const polluted^H^H^H

Re: [Cython] [PATCH] make memoryviews work when strides is NULL (unfinished)

2012-09-19 Thread mark florisson
On 19 September 2012 08:03, Christoph Groth wrote: > Hi Mark, > >> Thanks for the patch, it looks fine to me. If you want, you could make >> a pull request and I'll merge it. > > Ok, the pull request is here: > https://github.com/cython/cython/pull/150 > > Please double-check that the dereferencin

Re: [Cython] read-only memory views

2012-09-19 Thread mark florisson
On 19 September 2012 00:15, Robert Bradshaw wrote: > On Tue, Sep 18, 2012 at 3:42 PM, mark florisson > wrote: >> On 18 September 2012 20:55, Christoph Groth wrote: >>> Hello, >>> >>> I have written a python extension module, tinyarray, (to be made public >>> soon) which implements an important s

Re: [Cython] read-only memory views

2012-09-19 Thread Christoph Groth
Robert Bradshaw writes: > Coincidentally, I actually implemented rudimentary const support a > couple of days ago. It's not perfect, but at least it allows you to > provide the correct declarations to deal with const polluted^H^H^H^H > correct code (including const c++ class methods, for which th

Re: [Cython] [PATCH] make memoryviews work when strides is NULL (unfinished)

2012-09-19 Thread Christoph Groth
Hi Mark, > Thanks for the patch, it looks fine to me. If you want, you could make > a pull request and I'll merge it. Ok, the pull request is here: https://github.com/cython/cython/pull/150 Please double-check that the dereferencing of buf->strides in PyErr_SetString(PyExc_ValueError is still sa