Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread Stefan Behnel
Wes McKinney, 26.01.2012 18:56: > Just wanted to bring this issue to your guys' attention in case you > knew what was responsible for this: > > https://github.com/ipython/ipython/issues/1317#issuecomment-3652550 > > I traced down the problem (with git bisect) to a seemingly innocuous > commit ref

Re: [Cython] AddTraceback() slows down generators

2012-01-26 Thread Stefan Behnel
Vitja Makarov, 26.01.2012 21:19: > 2012/1/27 Stefan Behnel: >> Robert Bradshaw, 21.01.2012 23:09: >>> On Sat, Jan 21, 2012 at 10:50 AM, Stefan Behnel wrote: I did some callgrind profiling on Cython's generators and was surprised to find that AddTraceback() represents a serious performance

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread Fernando Perez
On Thu, Jan 26, 2012 at 11:21 AM, mark florisson wrote: > Apologies, it was indeed a rather vague comment. I had some issues No worries. > with pasting unicode characters a few years back that would get > incorrect codepoints in ipython but not regular python, but I'm afraid We had a long and d

Re: [Cython] AddTraceback() slows down generators

2012-01-26 Thread Vitja Makarov
2012/1/27 Stefan Behnel : > Robert Bradshaw, 21.01.2012 23:09: >> On Sat, Jan 21, 2012 at 10:50 AM, Stefan Behnel wrote: >>> I did some callgrind profiling on Cython's generators and was surprised to >>> find that AddTraceback() represents a serious performance penalty for short >>> running generat

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread mark florisson
On 26 January 2012 19:40, Wes McKinney wrote: > On Thu, Jan 26, 2012 at 2:21 PM, mark florisson > wrote: >> On 26 January 2012 19:10, Fernando Perez wrote: >>> On Thu, Jan 26, 2012 at 10:37 AM, mark florisson >>> wrote: On a side note, ipython is not something I usually trust to test

Re: [Cython] AddTraceback() slows down generators

2012-01-26 Thread Stefan Behnel
Robert Bradshaw, 21.01.2012 23:09: > On Sat, Jan 21, 2012 at 10:50 AM, Stefan Behnel wrote: >> I did some callgrind profiling on Cython's generators and was surprised to >> find that AddTraceback() represents a serious performance penalty for short >> running generators. >> >> I profiled a compiled

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread Wes McKinney
On Thu, Jan 26, 2012 at 2:21 PM, mark florisson wrote: > On 26 January 2012 19:10, Fernando Perez wrote: >> On Thu, Jan 26, 2012 at 10:37 AM, mark florisson >> wrote: >>> On a side note, ipython is not something I usually trust to test >>> things out, as it gets things wrong sometimes which can

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread mark florisson
On 26 January 2012 19:27, Stefan Behnel wrote: > mark florisson, 26.01.2012 20:15: >> On 26 January 2012 18:53, Stefan Behnel wrote: >>> mark florisson, 26.01.2012 16:20: I think this problem can trivially be solved by creating a ProxyNode that should never be replaced by any transform,

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread Stefan Behnel
mark florisson, 26.01.2012 20:15: > On 26 January 2012 18:53, Stefan Behnel wrote: >> mark florisson, 26.01.2012 16:20: >>> I think this problem can trivially be solved by creating a ProxyNode >>> that should never be replaced by any transform, but it's argument may >>> be replaced. So you wrap sel

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread mark florisson
On 26 January 2012 19:10, Fernando Perez wrote: > On Thu, Jan 26, 2012 at 10:37 AM, mark florisson > wrote: >> On a side note, ipython is not something I usually trust to test >> things out, as it gets things wrong sometimes which can seriously make >> you question your own sanity. > > I should n

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread mark florisson
On 26 January 2012 18:53, Stefan Behnel wrote: > mark florisson, 26.01.2012 16:20: >> On 26 January 2012 06:39, Vitja Makarov wrote: >>> 2012/1/25 Stefan Behnel: Back to the old idea of separating the type analysis into 1) a basic typing, inference and entry creation step and 2) a proper

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread mark florisson
On 26 January 2012 18:51, Vitja Makarov wrote: > 2012/1/26 mark florisson : >> On 26 January 2012 06:39, Vitja Makarov wrote: >>> 2012/1/25 Stefan Behnel : mark florisson, 24.01.2012 14:53: > On 24 January 2012 11:37, Konrad Hinsen wrote: >> Compiling the attached Cython file produce

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread Fernando Perez
On Thu, Jan 26, 2012 at 10:37 AM, mark florisson wrote: > On a side note, ipython is not something I usually trust to test > things out, as it gets things wrong sometimes which can seriously make > you question your own sanity. I should note that we'd love to know specifics about problems that se

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread Stefan Behnel
mark florisson, 26.01.2012 16:20: > On 26 January 2012 06:39, Vitja Makarov wrote: >> 2012/1/25 Stefan Behnel: >>> Back to the old idea of separating the type analysis into 1) a basic >>> typing, inference and entry creation step and 2) a proper type analysis, >>> coercion, etc. step. >>> >> >> Yea

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread Vitja Makarov
2012/1/26 mark florisson : > On 26 January 2012 06:39, Vitja Makarov wrote: >> 2012/1/25 Stefan Behnel : >>> mark florisson, 24.01.2012 14:53: On 24 January 2012 11:37, Konrad Hinsen wrote: > Compiling the attached Cython file produced the attached C file which > has errors in lines 5

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread mark florisson
On 26 January 2012 18:36, mark florisson wrote: > On 26 January 2012 17:56, Wes McKinney wrote: >> Just wanted to bring this issue to your guys' attention in case you >> knew what was responsible for this: >> >> https://github.com/ipython/ipython/issues/1317#issuecomment-3652550 >> >> I traced do

Re: [Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread mark florisson
On 26 January 2012 17:56, Wes McKinney wrote: > Just wanted to bring this issue to your guys' attention in case you > knew what was responsible for this: > > https://github.com/ipython/ipython/issues/1317#issuecomment-3652550 > > I traced down the problem (with git bisect) to a seemingly innocuous

[Cython] Slow traceback reconstruction in IPython between 0.15.1 and master

2012-01-26 Thread Wes McKinney
Just wanted to bring this issue to your guys' attention in case you knew what was responsible for this: https://github.com/ipython/ipython/issues/1317#issuecomment-3652550 I traced down the problem (with git bisect) to a seemingly innocuous commit referenced in that GitHub thread. The issue seeme

Re: [Cython] Bug in Cython producing incorrect C code

2012-01-26 Thread mark florisson
On 26 January 2012 06:39, Vitja Makarov wrote: > 2012/1/25 Stefan Behnel : >> mark florisson, 24.01.2012 14:53: >>> On 24 January 2012 11:37, Konrad Hinsen wrote: Compiling the attached Cython file produced the attached C file which has errors in lines 532-534:  __pyx_v_self->x