Re: [PATCH] Cygwin: console: Avoid slipping past disable_master_thread check.

2024-02-03 Thread Jeremy Drake via Cygwin-patches
Thanks for taking the time to write this up, this issue has been bugging me for years... (see also: https://cygwin.com/pipermail/cygwin-patches/2021q4/011638.html) On Sat, 3 Feb 2024, Johannes Schindelin wrote: > Concretely, the hangs occur typically when some `pacman` process (a > package manage

Re: [PATCH] Cygwin: console: Avoid slipping past disable_master_thread check.

2024-02-03 Thread Takashi Yano
On Sat, 3 Feb 2024 15:53:29 +0100 (CET) Johannes Schindelin wrote: > I wonder what could be a symptom of this bug. I ask because we have > noticed a couple of inexplicable hangs in GitHub workflow runs in the Git > for Windows and the MSYS2 projects, hangs that are almost certainly due to > the Con

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Corinna Vinschen
On Feb 4 00:04, Takashi Yano wrote: > On Sat, 3 Feb 2024 15:27:06 +0100 (CET) > Johannes Schindelin wrote: > > On IRC, you reported that the thread would crash if `cons` was not fixed > > up. The symptom was that that crash would apparently prevent the exit code > > from being read, and it would b

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Takashi Yano
On Sat, 3 Feb 2024 15:27:06 +0100 (CET) Johannes Schindelin wrote: > On IRC, you reported that the thread would crash if `cons` was not fixed > up. The symptom was that that crash would apparently prevent the exit code > from being read, and it would be left at 0, indicating potentially > incorrect

Re: [PATCH] Cygwin: console: Avoid slipping past disable_master_thread check.

2024-02-03 Thread Johannes Schindelin
Hi Takashi, On Sat, 3 Feb 2024, Takashi Yano wrote: > If disable_master_thread flag is set between the code checking that > flag not be set and the code acquiring input_mutex, input record is > processed once after setting disable_master_thread flag. This patch > prevents that. > > Fixes: d4aacd5

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Johannes Schindelin
Hi Takashi, On Sat, 3 Feb 2024, Johannes Schindelin wrote: > On Fri, 2 Feb 2024, Takashi Yano wrote: > > > If non-cygwin process is executed in console, the exit code is not > > set correctly. This is because the stub process for non-cygwin app > > crashes in fhandler_console::set_disable_master_

Re: [PATCH] Cygwin: console: Fix exit code for non-cygwin process.

2024-02-03 Thread Johannes Schindelin
Hi Takashi, On Fri, 2 Feb 2024, Takashi Yano wrote: > If non-cygwin process is executed in console, the exit code is not > set correctly. This is because the stub process for non-cygwin app > crashes in fhandler_console::set_disable_master_thread() due to NULL > pointer dereference. This bug was

[PATCH] Cygwin: net: Make if_nametoindex, etc. consistent with if_nameindex.

2024-02-03 Thread Takashi Yano
Currently, if_nametoindex() and if_indextoname() handle interface names such as "ethernet_32777", while if_nameindex() returns the names such as "{5AF7ACD0-D52E-4DFC-A4D0-54D3E6D6B2AC}". This patch unifies the interface names to the latter. Fixes: c356901f0d69 ("Rename if_indextoname to cygwin_if_