Re: Setup patch: List command line options on stdout

2004-11-20 Thread Max Bowsher
Dave wrote: Definitely go for a dialog box. Revised patch attached. Sorry, but I have to reject this patch. The MessageBox output takes no account of the fact that it is being displayed in a proportional-width font, and as a result comes out impressively mangled. As the reality is that the comma

Re: Setup patch: List command line options on stdout

2004-11-19 Thread Dave
>On Thu, Nov 18, 2004 at 02:43:35PM -0800, Dave wrote: >>* Print help to messagebox. Could also send it to stdout in case the user >>happens to be running from bash. [patches in this thread] > >It makes no sense that this would work from bash unless: > >http://sources.redhat.com/ml/cygwin-apps/2004

Re: Setup patch: List command line options on stdout

2004-11-19 Thread Max Bowsher
Robert Collins wrote: I'll note that I started work on having a separate console program, which would be guiless, for just this reason. Interesting... should I expect a branch to show up in setup CVS any time soon? :-) Max.

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Robert Collins
On Fri, 2004-11-19 at 01:08 +, Max Bowsher wrote: > > I am currently quite strongly opposed to turning setup.exe into a > console > app just to display help text. Please bear in mind that any command > line > options that setup has are purely for advanced automation uses - they > are > not

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Max Bowsher
Brian Dessent wrote: Dave wrote: Leaving: * Print help to messagebox. Could also send it to stdout in case the user happens to be running from bash. [patches in this thread] * Make setup a console program which hides the console as soon as it determines it doesn't need it. Probably leading to Ye ol

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Brian Dessent
Dave wrote: > Leaving: > * Print help to messagebox. Could also send it to stdout in case the user > happens to be running from bash. [patches in this thread] > * Make setup a console program which hides the console as soon as it > determines > it doesn't need it. Probably leading to Ye olde flas

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Christopher Faylor
On Thu, Nov 18, 2004 at 02:43:35PM -0800, Dave wrote: >* Print help to messagebox. Could also send it to stdout in case the user >happens to be running from bash. [patches in this thread] It makes no sense that this would work from bash unless: http://sources.redhat.com/ml/cygwin-apps/2004-11/msg

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Dave
Brian wrote: >Upon looking at the patch again it looks like it also spits the usage >text into the setup log, which I suppose is sufficient. Much better >than having nothing. Just to clarify, the patch actually stops the usage text going into the log. It just notes in the usage log that it is out

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Christopher Faylor
On Thu, Nov 18, 2004 at 05:47:58PM +0100, Reini Urban wrote: >Christopher Faylor schrieb: >>On Thu, Nov 18, 2004 at 10:32:29AM +0100, Reini Urban wrote: >>>Unfortunately we need -mwindows. >> >>No. We don't. What do you think -mwindows implies? >> >> From the gcc spec file: >>*link: >> %{mwindows

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Reini Urban
Christopher Faylor schrieb: On Thu, Nov 18, 2004 at 10:32:29AM +0100, Reini Urban wrote: Christopher Faylor schrieb: On Wed, Nov 17, 2004 at 08:53:41PM +0100, Reini Urban wrote: Christopher Faylor schrieb: Applications linked with -mwindows (i.e., GUI apps) can't print to stdout. How does this act

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Christopher Faylor
On Thu, Nov 18, 2004 at 10:32:29AM +0100, Reini Urban wrote: >Christopher Faylor schrieb: >>On Wed, Nov 17, 2004 at 08:53:41PM +0100, Reini Urban wrote: >> >>>Christopher Faylor schrieb: >>> On Wed, Nov 17, 2004 at 10:10:58AM +0100, Reini Urban wrote: >Dave schrieb: > > >>

Re: Setup patch: List command line options on stdout

2004-11-18 Thread Reini Urban
Christopher Faylor schrieb: On Wed, Nov 17, 2004 at 08:53:41PM +0100, Reini Urban wrote: Christopher Faylor schrieb: On Wed, Nov 17, 2004 at 10:10:58AM +0100, Reini Urban wrote: Dave schrieb: Here's a simple and useful patch for setup. Might reduce queries about unattended installs, and save peop

RE: Setup patch: List command line options on stdout

2004-11-17 Thread Gary R. Van Sickle
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Igor Pechtchanski [snip] > > This has little bearing on the current discussion, but did > you ever try just pressing Ctrl-C while in the dialog box? > On Win2k/XP this should copy the contents of th

RE: Setup patch: List command line options on stdout

2004-11-17 Thread Gary R. Van Sickle
[snip] > I really don't understand why we should stand on our heads to > make setup.exe a console subsystem program (you don't need to > both specify -mwindows and -Wl,--subsystem=console, btw) when > you can just open up a dialog box to display the options, > like every other windows program i

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Brian Dessent
Igor Pechtchanski wrote: > On Wed, 17 Nov 2004, Brian Dessent wrote: > > > I haven't tried your patch, but if you make a dialog how about one that > > you can select and copy the text from, like a simple read-only richedit > > control? I always hated pop-up dialog boxes that contained vital > > i

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Igor Pechtchanski
On Wed, 17 Nov 2004, Brian Dessent wrote: > Dave wrote: > > > Definitely go for a dialog box. > > > > Revised patch attached. Should these be directed exclusively at > > bugzilla now? > > I haven't tried your patch, but if you make a dialog how about one that > you can select and copy the text fro

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Brian Dessent
Dave wrote: > Definitely go for a dialog box. > > Revised patch attached. Should these be directed exclusively at bugzilla now? I haven't tried your patch, but if you make a dialog how about one that you can select and copy the text from, like a simple read-only richedit control? I always hated

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Christopher Faylor
On Wed, Nov 17, 2004 at 03:27:20PM -0800, Dave wrote: >Hmmm. Just wonderring... Yep. OK. I see the output of stdout when >setup is run from bash. It doesn't appear if running from cmd. That >explains it. You must be using CYGWIN=tty then, maybe? That would explain this. >Revised patch atta

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Dave
cgf said: >On Wed, Nov 17, 2004 at 08:53:41PM +0100, Reini Urban wrote: >>Christopher Faylor schrieb: >>>On Wed, Nov 17, 2004 at 10:10:58AM +0100, Reini Urban wrote: >>> >>>Actually, there was a thread about this on the cygwin list not too long >>>ago. >> >>Yep. This suggested a complicated trick.

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Christopher Faylor
On Wed, Nov 17, 2004 at 08:53:41PM +0100, Reini Urban wrote: >Christopher Faylor schrieb: >>On Wed, Nov 17, 2004 at 10:10:58AM +0100, Reini Urban wrote: >> >>>Dave schrieb: >>> Here's a simple and useful patch for setup. Might reduce queries about unattended installs, and save people having

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Reini Urban
Christopher Faylor schrieb: On Wed, Nov 17, 2004 at 10:10:58AM +0100, Reini Urban wrote: Dave schrieb: Here's a simple and useful patch for setup. Might reduce queries about unattended installs, and save people having to resort to source. Patch is against CVS (as of yesterday). Modify the leader te

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Christopher Faylor
On Wed, Nov 17, 2004 at 10:10:58AM +0100, Reini Urban wrote: >Dave schrieb: >>Here's a simple and useful patch for setup. Might reduce queries about >>unattended installs, and save people having to resort to source. >> >>Patch is against CVS (as of yesterday). >>Modify the leader text as you see fi

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Reini Urban
Dave schrieb: Here's a simple and useful patch for setup. Might reduce queries about unattended installs, and save people having to resort to source. Patch is against CVS (as of yesterday). Modify the leader text as you see fit :) Dave Kilroy. ---

Re: Setup patch: List command line options on stdout

2004-11-17 Thread Reini Urban
Dave schrieb: Here's a simple and useful patch for setup. Might reduce queries about unattended installs, and save people having to resort to source. Patch is against CVS (as of yesterday). Modify the leader text as you see fit :)