Re: Patch for Setup.exe problem and for mklink2.cc

2002-04-06 Thread Guy Harrison
On Wed, 03 Apr 2002 13:11:53 EST, Brian Keener <[EMAIL PROTECTED]> wrote: > wrote: >> > As for the &'s, I wonder if it's a w32api reference issue? The compiler >> >> > complains if they are present for me. >> >> For me it is the opposite. g++ complains when they are *not* >> >> present. >> >I

Re: Patch for Setup.exe problem and for mklink2.cc

2002-04-03 Thread Brian Keener
wrote: > > As for the &'s, I wonder if it's a w32api reference issue? The compiler > > > complains if they are present for me. > > For me it is the opposite. g++ complains when they are *not* > > present. > I believe this might be related to the above discussion so I thought I would add this

Re[4]: Patch for Setup.exe problem and for mklink2.cc

2002-03-29 Thread Pavel Tsekov
Hello Robert, Friday, March 29, 2002, 10:44:23 AM, you wrote: >> Btw I don't think my question is related to this is issue but >> still... I notice there is a dummy column in the list view >> after the "Package" column - is this a feature ? If so what >> is its purpose ? RC> There shouldn't b

RE: Re[2]: Patch for Setup.exe problem and for mklink2.cc

2002-03-29 Thread Robert Collins
> -Original Message- > From: Pavel Tsekov [mailto:[EMAIL PROTECTED]] > Sent: Friday, March 29, 2002 8:42 PM > To: Robert Collins > Cc: [EMAIL PROTECTED] > Subject: Re[2]: Patch for Setup.exe problem and for mklink2.cc > > > Hello Robert, > > Friday,

Re[2]: Patch for Setup.exe problem and for mklink2.cc

2002-03-29 Thread Pavel Tsekov
Hello Robert, Friday, March 29, 2002, 10:25:08 AM, you wrote: >> > Found the problem causing the segment violation and probably >> > causing Jonas Eriksson's problem. It is a typical case of >> > 'off by 1'. In PickView::set_headers the loop filling the >> > window header does one iteration to

RE: Patch for Setup.exe problem and for mklink2.cc

2002-03-29 Thread Robert Collins
> -Original Message- > From: Robert Collins > Sent: Thursday, March 28, 2002 1:11 AM > To: Ton van Overbeek; [EMAIL PROTECTED]; > [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: RE: Patch for Setup.exe problem and for mklink2.cc > > > > > &

RE: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Gary R. Van Sickle
[snip] > > > > There have been a few of these off-by-ones in Setup. Is it > > possible your habit of using 1-based arrays is a contributing > > factor Rob? This isn't a convention I see much (modulo > > "Numerical Recipies"); is there a reason you use this convention? > > Errm, there aren't any

RE: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Robert Collins
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED]] On Behalf Of Gary R Van Sickle > Sent: Thursday, March 28, 2002 4:48 AM > To: [EMAIL PROTECTED] > Subject: RE: Patch for Setup.exe problem and for mklink2.cc > > > [snip] > &

RE: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Gary R Van Sickle
[snip] > > Found the problem causing the segment violation and probably > > causing Jonas Eriksson's problem. It is a typical case of > > 'off by 1'. In PickView::set_headers the loop filling the > > window header does one iteration too much, resulting in a > > call to DoInsertItem with a NU

Re: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread tvoverbe
Robert wrote: > I'll check the off-by-one fix in tomorrow, as I'm off to bed now. > > As for the &'s, I wonder if it's a w32api reference issue? The compiler > complains if they are present for me. For me it is the opposite. g++ complains when they are *not* present. The w32api include

RE: Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Robert Collins
> -Original Message- > From: Ton van Overbeek [mailto:[EMAIL PROTECTED]] > Sent: Thursday, March 28, 2002 1:03 AM > To: [EMAIL PROTECTED]; [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: Patch for Setup.exe problem and for mklink2.cc > > > Found the

Patch for Setup.exe problem and for mklink2.cc

2002-03-27 Thread Ton van Overbeek
Found the problem causing the segment violation and probably causing Jonas Eriksson's problem. It is a typical case of 'off by 1'. In PickView::set_headers the loop filling the window header does one iteration too much, resulting in a call to DoInsertItem with a NULL string pointer and hence a cra