Alan,
I was going to say that I'll review the patch later, and offer a few quick
comments, but it looks like I did a full patch review, so here goes:
(1) WOW, this is a HUGE ChangeLog. Wa-ay too detailed. Most of this
stuff should go into comments in the script, if you feel like documenting
it
All,
I am attaching a new release of the this patch to mitigate below.
Igor, please review and advise. Note: I built against 1.19 for the
generic-build-script and 1.7 for the
generic readme.
Change log entry:
2004-02-24 Alan Miles <[EMAIL PROTECTED]>
* templates/generic-readme : Chan
On Wed, 18 Feb 2004, Yaakov Selkowitz wrote:
> Igor Pechtchanski wrote:
>
> | Yaakov,
> |
> | This looks good. The only two comments I have are:
> |
> | 1) You replaced '&&'s by ';' after 'fi's in install() (where they were
> | needed), and left the one after 'find' in mkpatch() (where it was not
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Igor Pechtchanski wrote:
| Yaakov,
|
| This looks good. The only two comments I have are:
|
| 1) You replaced '&&'s by ';' after 'fi's in install() (where they were
| needed), and left the one after 'find' in mkpatch() (where it was not).
| This is mi
On Wed, 18 Feb 2004, Yaakov Selkowitz wrote:
Igor,
OK, here's the patch again, along with my ChangeLog. Feel free to edit
as necessary.
Yaakov
2004-02-17 Yaakov Selkowitz
* generic-build-script: Add 'configure', 'make', and 'test'
arguments as aliases for 'conf', 'build', and
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Igor,
OK, here's the patch again, along with my ChangeLog. Feel free to edit
as necessary.
Yaakov
2004-02-17 Yaakov Selkowitz
* generic-build-script: Add 'configure', 'make', and 'test'
arguments as aliases for 'conf', 'build', and
