Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-27 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: ... Using std::set_intersection() on values from std::map() here is probably a mistake. It's simple to write, but the performance is not good. A faster alternative which avoids set_intersection calls in a loop is possibly to use one large data structure which maps filenames

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-27 Thread Jon Turney via Cygwin-apps
On 24/04/2023 17:26, Christian Franke via Cygwin-apps wrote: Jon Turney via Cygwin-apps wrote: Detect filename collisions between packages Don't check filenames under /etc/postinstall/ for collisions Report when filename collisions exist Add option '--collisions' to enable IMO a useful enhance

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-24 Thread Christian Franke via Cygwin-apps
Jon Turney via Cygwin-apps wrote: Detect filename collisions between packages Don't check filenames under /etc/postinstall/ for collisions Report when filename collisions exist Add option '--collisions' to enable IMO a useful enhancement. Notes: Reading file catalog from a package is modera

[PATCH setup 2/2] Detect filename collisions between packages

2023-04-23 Thread Jon Turney via Cygwin-apps
Detect filename collisions between packages Don't check filenames under /etc/postinstall/ for collisions Report when filename collisions exist Add option '--collisions' to enable Notes: Reading file catalog from a package is moderately expensive in terms of I/O: To extract all the filenames from