Re: [PATCH setup] Avoid stringop-overflow warning with gcc8

2018-10-13 Thread Corinna Vinschen
On Oct 13 13:50, Jon Turney wrote: > On 12/10/2018 16:58, Corinna Vinschen wrote: > > On Oct 12 16:43, Jon Turney wrote: > [...] > > > diff --git a/desktop.cc b/desktop.cc > > > index 927c02f..d003e91 100644 > > > --- a/desktop.cc > > > +++ b/desktop.cc > > > @@ -107,7 +107,8 @@ start_menu (const s

Re: [PATCH setup] Avoid stringop-overflow warning with gcc8

2018-10-13 Thread Jon Turney
On 12/10/2018 16:58, Corinna Vinschen wrote: On Oct 12 16:43, Jon Turney wrote: [...] diff --git a/desktop.cc b/desktop.cc index 927c02f..d003e91 100644 --- a/desktop.cc +++ b/desktop.cc @@ -107,7 +107,8 @@ start_menu (const std::string& title, const std::string& target,

Re: [PATCH setup] Avoid stringop-overflow warning with gcc8

2018-10-12 Thread Corinna Vinschen
On Oct 12 16:43, Jon Turney wrote: > desktop.cc: In function 'void start_menu(const string&, const string&, const > string&, const string&)': > desktop.cc:110:11: error: 'char* strncat(char*, const char*, size_t)' > specified bound 260 equals destination size [-Werror=stringop-overflow=] > > I t

[PATCH setup] Avoid stringop-overflow warning with gcc8

2018-10-12 Thread Jon Turney
desktop.cc: In function 'void start_menu(const string&, const string&, const string&, const string&)': desktop.cc:110:11: error: 'char* strncat(char*, const char*, size_t)' specified bound 260 equals destination size [-Werror=stringop-overflow=] I think strlcat() was meant here, which MinGW does