On Aug 11 19:24, Achim Gratz wrote:
> Corinna Vinschen writes:
> > Patch applied.
>
> As a follow-up on the discussion I've checked why this is a conversion
> operator in the first place and the answer is "no particularly good
> reason". I propose to keep the implementation unchanged, but as a pl
Currently setup.exe silently terminates when starting it with a command
line parameter that it does not know about. It should show the usage
message in this case.
>From bd41fd08b8be7cc9e150cb8edefa48519309ecd6 Mon Sep 17 00:00:00 2001
From: Achim Gratz
Date: Sat, 10 Aug 2013 18:05:24 +0200
Subje
Corinna Vinschen writes:
> Patch applied.
As a follow-up on the discussion I've checked why this is a conversion
operator in the first place and the answer is "no particularly good
reason". I propose to keep the implementation unchanged, but as a plain
member function str() instead, which should
Corinna Vinschen writes:
> Not quite. ostringstream::str returns string, the string constructor
> implicitely returns string&.
I could be reading it wrong, but I don't think that's what the C++11
standard says should happen. The implicit copy constructor transfering
the return value out of the f
On Aug 9 13:54, Christopher Faylor wrote:
> On Fri, Aug 09, 2013 at 07:47:23PM +0200, Corinna Vinschen wrote:
> >On Aug 9 12:55, Christopher Faylor wrote:
> >> On Fri, Aug 09, 2013 at 11:01:32AM -0500, Thrall, Bryan wrote:
> >> >Christopher Faylor wrote on 2013-08-09:
> >> >> On Fri, Aug 09, 2013
Corinna Vinschen writes:
>> - return std::string(hexdigest);
> ^^
>
> I'm wondering if that was the problem.
I was wondering about this, too — but then the SEGV should have happened
in the calling function. I believe that the vetting of hexdigest[32]
with a zero
On Fri, Aug 09, 2013 at 07:47:23PM +0200, Corinna Vinschen wrote:
>On Aug 9 12:55, Christopher Faylor wrote:
>> On Fri, Aug 09, 2013 at 11:01:32AM -0500, Thrall, Bryan wrote:
>> >Christopher Faylor wrote on 2013-08-09:
>> >> On Fri, Aug 09, 2013 at 11:07:26AM +0200, Corinna Vinschen wrote:
>> >>>
On Aug 9 12:55, Christopher Faylor wrote:
> On Fri, Aug 09, 2013 at 11:01:32AM -0500, Thrall, Bryan wrote:
> >Christopher Faylor wrote on 2013-08-09:
> >> On Fri, Aug 09, 2013 at 11:07:26AM +0200, Corinna Vinschen wrote:
> >>> On Aug 8 20:34, Achim Gratz wrote:
>
> I've been having spo
On Fri, Aug 09, 2013 at 11:01:32AM -0500, Thrall, Bryan wrote:
>Christopher Faylor wrote on 2013-08-09:
>> On Fri, Aug 09, 2013 at 11:07:26AM +0200, Corinna Vinschen wrote:
>>> On Aug 8 20:34, Achim Gratz wrote:
I've been having sporadic SEGV on WinXP/Pro just after the MD5 of a
pa
Christopher Faylor wrote on 2013-08-09:
> On Fri, Aug 09, 2013 at 11:07:26AM +0200, Corinna Vinschen wrote:
>> On Aug 8 20:34, Achim Gratz wrote:
>>>
>>> I've been having sporadic SEGV on WinXP/Pro just after the MD5 of a
>>> package was checked that used to clear up after a reboot. Today,
with
On Fri, Aug 09, 2013 at 11:07:26AM +0200, Corinna Vinschen wrote:
>On Aug 8 20:34, Achim Gratz wrote:
>>
>> I've been having sporadic SEGV on WinXP/Pro just after the MD5 of a
>> package was checked that used to clear up after a reboot. Today, with a
>> freshly built setup.exe this failure was n
On Aug 8 20:34, Achim Gratz wrote:
>
> I've been having sporadic SEGV on WinXP/Pro just after the MD5 of a
> package was checked that used to clear up after a reboot. Today, with a
> freshly built setup.exe this failure was now entirely reproduceable.
> I've fixed it by reimplementing the string
I've been having sporadic SEGV on WinXP/Pro just after the MD5 of a
package was checked that used to clear up after a reboot. Today, with a
freshly built setup.exe this failure was now entirely reproduceable.
I've fixed it by reimplementing the string formatting for the MD5 digest
using C++ strea
On Tue, Jan 22, 2013 at 04:32:22AM +0900, green fox wrote:
>Chris, language please.
Sorry for being unclear. I was writing in English.
>The problem in lack of decent package manager is something most of us here
>know for a long time. Hope everyone agrees on this point.
Reiteration of this point
Chris, language please.
The problem in lack of decent package manager is something most of us here
know for a long time. Hope everyone agrees on this point.
Here we're just focusing to concentrate the work,
refactor what key items we need, or can leave out with, re-use and such.
At the same time
Achim Gratz writes:
> I have one last idea of how to live without that particular change. If
> it works, I'll drop the patch.
I've done some tests and I can implement my minimum requirement by
changing the directory structure to something like:
repo/release/... (packages directory)
repo/setup_cu
On Mon, Jan 21, 2013 at 06:46:00PM +0900, green fox wrote:
>On 1/21/13, Christopher Faylor wrote:
>> On Mon, Jan 21, 2013 at 04:03:04PM +0900, green fox wrote:
>>>On 1/20/13, Christopher Faylor wrote:
What *specifically* do you really like?
>>>
>>>+1 for being able to specify custom setup.ini N
On 1/21/13, Christopher Faylor wrote:
> On Mon, Jan 21, 2013 at 04:03:04PM +0900, green fox wrote:
>>On 1/20/13, Christopher Faylor wrote:
>>>What *specifically* do you really like?
>>
>>+1 for being able to specify custom setup.ini Not a happy moment when
>>you realize some package is missing, hav
On 1/20/13, Achim Gratz wrote:
> I plan to publish my infrastructure, but haven't yet since it a) isn't
> feature complete and b) I need to clean up a few things. I don't want
> to fork setup.exe if I can help it.
Agrred. No one likes to fork, and that includes myself.
And believe me, clean up of
On Mon, Jan 21, 2013 at 04:03:04PM +0900, green fox wrote:
>On 1/20/13, Christopher Faylor wrote:
>>What *specifically* do you really like?
>
>+1 for being able to specify custom setup.ini Not a happy moment when
>you realize some package is missing, having spent 2 housr to distribute
>the blob on
On 1/20/13, Christopher Faylor wrote:
>
> What *specifically* do you really like?
>
> cgf
>
+1 for being able to specify custom setup.ini
Not a happy moment when you realize some package is missing, having
spent 2 housr to distribute the blob on the network.
Only a _workaround_, but If I can just
Christopher Faylor writes:
> I was referring to your change which handled versioned setup.ini's.
> That is not a requirement for an unattended Cygwin install.
I do have that requirement, not that I love it very much.
> If there was a general hue and cry for the feature that you want to add,
> I'd
green fox writes:
> Achim, reguardless of if this code getting into cygwin (or not), could
> you be able to provide a copy of this on public git/whatever server?
I plan to publish my infrastructure, but haven't yet since it a) isn't
feature complete and b) I need to clean up a few things. I don't
On Sun, Jan 20, 2013 at 12:35:32PM +0900, green fox wrote:
>Achim, reguardless of if this code getting into cygwin (or not), could
>you be able to provide a copy of this on public git/whatever server?
>I really like this.
What *specifically* do you really like?
cgf
Achim, reguardless of if this code getting into cygwin (or not), could
you be able to provide a copy of this on public git/whatever server?
I really like this.
Just for note, in the past, unattended instalation/update using
automated package management, we resorted into using apt-cyg written
by St
On Sat, Jan 19, 2013 at 09:47:31PM +0100, Achim Gratz wrote:
>Christopher Faylor writes:
>>I'm really not too keen on adding hacks to setup so that people can use
>>it for other than its intended purpose.
>
>If there is another method to do an unattended Cygwin install, I'm all
>ears. I have brief
Christopher Faylor writes:
> I'm really not too keen on adding hacks to setup so that people can
> use it for other than its intended purpose.
If there is another method to do an unattended Cygwin install, I'm all
ears. I have briefly pondered to script a standalone installer, but it
requires too
On Sat, Jan 19, 2013 at 08:41:05AM +0100, Achim Gratz wrote:
>Christopher Faylor writes:
>> You'd really be much better served to submit one patch at a time.
>
>Noted.
>
>> If you look at bootstrap.sh, you will see why I'm puzzled why this should be
>> needed. The script is intended to be run from
Christopher Faylor writes:
> You'd really be much better served to submit one patch at a time.
Noted.
> If you look at bootstrap.sh, you will see why I'm puzzled why this should be
> needed. The script is intended to be run from the build directory which
> should be separate from the source dire
On Fri, Jan 18, 2013 at 06:23:49PM +0100, Achim Gratz wrote:
>As requested by Corinna on the Cygwin list, here's a patch to document
>some recent changes in the build environment.
You'd really be much better served to submit one patch at a time.
>From 3dd23c6063a3edb8bfd1874f5b3c68baf0a89ec4 Mon
On 1/18/2013 12:23 PM, Achim Gratz wrote:
+Additionally, libgetopt++ (also available from the cygwin-apps CVS at
+sourceware.org) must be available directly as a subdirectory
+libgetopt++ within the setup source directory.
I don't understand why you need this part. Checking out setup
automati
As requested by Corinna on the Cygwin list, here's a patch to document
some recent changes in the build environment.
>From 3dd23c6063a3edb8bfd1874f5b3c68baf0a89ec4 Mon Sep 17 00:00:00 2001
From: Achim Gratz
Date: Fri, 18 Jan 2013 14:24:13 +0100
Subject: [PATCH 1/3] README: document some recent ch
On Thu, Jan 17, 2013 at 05:22:33PM +, Jon TURNEY wrote:
>On 14/09/2012 01:43, Warren Young wrote:
>> On 9/13/2012 5:09 AM, Jon TURNEY wrote:
>>> On 13/09/2012 03:23, Warren Young wrote:
5. Several build system files refer to iniparse.h, but on my system,
iniparse.yy yields iniparse.hh
On 14/09/2012 01:43, Warren Young wrote:
> On 9/13/2012 5:09 AM, Jon TURNEY wrote:
>> On 13/09/2012 03:23, Warren Young wrote:
>>> 5. Several build system files refer to iniparse.h, but on my system,
>>> iniparse.yy yields iniparse.hh, not .h.
>>
>> See the note on a "Slightly backward-incompatible
On Sep 13 11:26, Christopher Faylor wrote:
> On Wed, Sep 12, 2012 at 10:08:36PM -0600, Eric Blake wrote:
> >On 09/12/2012 09:42 PM, Warren Young wrote:
> >> On 9/12/2012 9:28 PM, Christopher Faylor wrote:
> >>>
> >>> If you're going to do that you really should (re)learn how to submit a
> >>> prope
On Wed, Sep 12, 2012 at 10:46:02PM -0600, Warren Young wrote:
>This patch is incomplete, but I've been fighting this for four hours
>now. I'm tired, hungry, and frustrated, so in case I don't get back to
>finishing this, I decided to just post what I have so far.
>
>The point of the patch is to
On 9/13/2012 5:09 AM, Jon TURNEY wrote:
On 13/09/2012 03:23, Warren Young wrote:
5. Several build system files refer to iniparse.h, but on my system,
iniparse.yy yields iniparse.hh, not .h.
See the note on a "Slightly backward-incompatible change" in the section
"Changes to Yacc and Lex suppor
On Wed, Sep 12, 2012 at 10:08:36PM -0600, Eric Blake wrote:
>On 09/12/2012 09:42 PM, Warren Young wrote:
>> On 9/12/2012 9:28 PM, Christopher Faylor wrote:
>>>
>>> If you're going to do that you really should (re)learn how to submit a
>>> proper patch. A patch uses "diff -u" format and contains a
On 13/09/2012 03:23, Warren Young wrote:
> 5. Several build system files refer to iniparse.h, but on my system,
> iniparse.yy yields iniparse.hh, not .h. In a fresh CVS checkout, this causes:
>
> $ ./bootstrap.sh
> ...noise noise noise...
> $ make
> GEN setup_version.c
> make: **
This patch is incomplete, but I've been fighting this for four hours
now. I'm tired, hungry, and frustrated, so in case I don't get back to
finishing this, I decided to just post what I have so far.
The point of the patch is to get the Select Packages screen's package
lists to sort case-insen
On 09/12/2012 09:42 PM, Warren Young wrote:
> On 9/12/2012 9:28 PM, Christopher Faylor wrote:
>>
>> If you're going to do that you really should (re)learn how to submit a
>> proper patch. A patch uses "diff -u" format and contains a ChangeLog.
>
> It's been a decade since I last used "cvs diff".
On 9/12/2012 9:28 PM, Christopher Faylor wrote:
If you're going to do that you really should (re)learn how to submit a
proper patch. A patch uses "diff -u" format and contains a ChangeLog.
It's been a decade since I last used "cvs diff". I forgot that it
doesn't include -u, since svn diff d
On Wed, Sep 12, 2012 at 08:23:58PM -0600, Warren Young wrote:
>It's that time of decade again...time for me to patch setup.exe again.
If you're going to do that you really should (re)learn how to submit a
proper patch. A patch uses "diff -u" format and contains a ChangeLo
It's that time of decade again...time for me to patch setup.exe again.
But oh noes! The README instructions are wrong, and the program doesn't
build correctly from a fresh checkout. Hafta fix that first.
1. The README implies that you need automake 1.9 and libtool 1.5,
exactly.
Am 07.04.2010, 18:33 Uhr, schrieb Corinna Vinschen:
On Apr 7 16:01, Matthias Andree wrote:
Greetings,
I propose the attached patch to fix the two issues (installation
status truncated, copyright outdated) I reported on cygwin@ (see
forward below), and a third issue, missing lzma and gcrypt fr
On Wed, Apr 07, 2010 at 06:33:43PM +0200, Corinna Vinschen wrote:
>On Apr 7 16:01, Matthias Andree wrote:
>> Greetings,
>>
>> I propose the attached patch to fix the two issues (installation
>> status truncated, copyright outdated) I reported on cygwin@ (see
>> forward below), and a third issue,
On Apr 7 16:01, Matthias Andree wrote:
> Greetings,
>
> I propose the attached patch to fix the two issues (installation
> status truncated, copyright outdated) I reported on cygwin@ (see
> forward below), and a third issue, missing lzma and gcrypt from
> README. diffstat:
>
> ChangeLog | 11
Greetings,
I propose the attached patch to fix the two issues (installation status
truncated, copyright outdated) I reported on cygwin@ (see forward below),
and a third issue, missing lzma and gcrypt from README. diffstat:
ChangeLog | 11 +++
README|4 +++-
res.rc|
Christopher Faylor wrote:
> On Wed, Nov 04, 2009 at 12:57:05PM -0500, Christopher Faylor wrote:
>> On Wed, Nov 04, 2009 at 06:05:27PM +, Dave Korn wrote:
>>> Christopher Faylor wrote:
Why not add a new option entirely or some sort of different syntax for
categories like "Net:" or som
Corinna Vinschen wrote:
> On Nov 4 17:47, Dave Korn wrote:
>> Overall I think this is a much more friendly user experience. OK for head?
>
> In theory, yes, with two tweaks...
>
>> Index: localdir.cc
>> [...]
>> @@ -213,6 +252,12 @@ LocalDirPage::OnNext ()
>>return IDD_CHOOSE;
>>
On Nov 4 17:47, Dave Korn wrote:
> Overall I think this is a much more friendly user experience. OK for head?
In theory, yes, with two tweaks...
> Index: localdir.cc
> [...]
> @@ -213,6 +252,12 @@ LocalDirPage::OnNext ()
> return IDD_CHOOSE;
> }
> }
> + else i
On Wed, Nov 04, 2009 at 12:15:26PM -0600, Yaakov (Cygwin/X) wrote:
>On 04/11/2009 12:05, Dave Korn wrote:
>>Do we actually have any packages that have the same names as categories?
>
>perl
>python
>
>The categories are Capitalized where the packages are not, but I don't
>think we want to go th
On 04/11/2009 12:05, Dave Korn wrote:
Do we actually have any packages that have the same names as categories?
perl
python
The categories are Capitalized where the packages are not, but I don't
think we want to go there.
Yaakov
On Wed, Nov 04, 2009 at 12:57:05PM -0500, Christopher Faylor wrote:
>On Wed, Nov 04, 2009 at 06:05:27PM +, Dave Korn wrote:
>>Christopher Faylor wrote:
>>>Unfortunately, no, I don't think so. I like the idea but I don't like
>>>overloading "-p" as it could cause confusion.
>>
>>Do we actually
On Wed, Nov 04, 2009 at 06:05:27PM +, Dave Korn wrote:
>Christopher Faylor wrote:
>>Unfortunately, no, I don't think so. I like the idea but I don't like
>>overloading "-p" as it could cause confusion.
>
>Do we actually have any packages that have the same names as
>categories? I guess we mig
On Wed, Nov 04, 2009 at 06:02:14PM +, Dave Korn wrote:
>Christopher Faylor wrote:
>
>> I think the original semantics are quite a bit less surprising and the option
>> should be checked first.
>
> Figured that might be the case, so here it is the other way.
>
> * localdir.cc (LocalDirSet
Christopher Faylor wrote:
> I think so but maybe Corinna should ok this since I assume that it changes
> her recently checked in change.
Yes, it reverts part of it:
>> It also resolves the what-to-do-when-the-directory-doesn't-exist problem
>> slightly differently. I didn't want to just auto
On Wed, Nov 04, 2009 at 05:47:48PM +, Dave Korn wrote:
>
>Are we having fun yet?
>
> This patch makes the local package dir browsing experience nicer. (It also
>rolls up the previous patch about fixing the localdir option, sorry for being
>lazy; just ignore that very first hunk for the mo
Christopher Faylor wrote:
> Unfortunately, no, I don't think so. I like the idea but I don't like
> overloading
> "-p" as it could cause confusion.
Do we actually have any packages that have the same names as categories? I
guess we might do one day even if we don't now, but I didn't see th
Christopher Faylor wrote:
> I think the original semantics are quite a bit less surprising and the option
> should be checked first.
Figured that might be the case, so here it is the other way.
* localdir.cc (LocalDirSetting::LocalDirSetting): Restore -l option.
OK now?
cheers,
On Wed, Nov 04, 2009 at 05:47:55PM +, Dave Korn wrote:
>
>Last but not least,
>
> I found myself wanting to run setup in unattended mode to install absolutely
>everything, so I figured the nicest solution was to allow the -p option to
>accept category names as well as package names, so tha
On Wed, Nov 04, 2009 at 05:47:32PM +, Dave Korn wrote:
>
>Hello perverts and non-perverts alike!
>
> Having recently become a pervert, oops I mean provider, I wanted to provide
>a full turnkey installation on a DVD for offline use, and to avoid confusing
>any cygn00bs among them, I wanted
On Wed, Nov 04, 2009 at 05:47:15PM +, Dave Korn wrote:
>
>Hi all,
>
> In unattended mode, setup.exe automatically answers "yes" to all message
>boxes. If the message box is asking whether to retry an incomplete download,
>and the reason for the incomplete download is something non-transie
On Wed, Nov 04, 2009 at 05:47:21PM +, Dave Korn wrote:
>
>
>Hi again!
>
> During the recent rejig of settings handling, the command-line "-l" option
>(aka "--local-package-dir") got borked. This patch restores it, but it might
>not be quite what's wanted, because it changes the semantics
Last but not least,
I found myself wanting to run setup in unattended mode to install absolutely
everything, so I figured the nicest solution was to allow the -p option to
accept category names as well as package names, so that I could use "-p All".
The attached patch does just that.
Are we having fun yet?
This patch makes the local package dir browsing experience nicer. (It also
rolls up the previous patch about fixing the localdir option, sorry for being
lazy; just ignore that very first hunk for the moment. I could have manually
chopped it out but then the line num
Hello perverts and non-perverts alike!
Having recently become a pervert, oops I mean provider, I wanted to provide
a full turnkey installation on a DVD for offline use, and to avoid confusing
any cygn00bs among them, I wanted it to have a setup.exe that would just
install from the provided
Hi again!
During the recent rejig of settings handling, the command-line "-l" option
(aka "--local-package-dir") got borked. This patch restores it, but it might
not be quite what's wanted, because it changes the semantics slightly; that's
just the way I happened to want it to work for th
Hi all,
In unattended mode, setup.exe automatically answers "yes" to all message
boxes. If the message box is asking whether to retry an incomplete download,
and the reason for the incomplete download is something non-transient, like
the localhost or the mirror going offline, or a file is
On Fri, May 15, 2009 at 09:24:56AM -0400, Jonathon Merz wrote:
>Hi Chris,
>
>On Fri, May 15, 2009 at 4:10 AM, Chris January wrote:
>> You really ought to be using Get/SetWindowPlacement rather than
>> GetWindowPos, IsZoomed etc.
>>
>> GetWindowPlacement works in workspace coordinates, whereas GetWi
Hi Chris,
On Fri, May 15, 2009 at 4:10 AM, Chris January wrote:
> You really ought to be using Get/SetWindowPlacement rather than
> GetWindowPos, IsZoomed etc.
>
> GetWindowPlacement works in workspace coordinates, whereas GetWindowPos
> works with screen coordinates so your code won't work proper
Hello Jonathon,
On Wed, 13 May 2009 21:59:38 -0400, Jonathon Merz
wrote:
> Hello,
>
> Per Dave Korn's suggestion in:
>http://cygwin.com/ml/cygwin/2009-05/msg00208.html
>- If setup.exe exits while in a maximized state, it will be
> maximized on next startup, and recall it's la
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Jonathon Merz on 5/14/2009 2:56 PM:
> On Thu, May 14, 2009 at 11:02 AM, Christopher Faylor wrote:
I know that Dave asked for this but I really don't see the need to add
this much machinery. ?I think this is a lot of work to go to
On Thu, May 14, 2009 at 11:02 AM, Christopher Faylor wrote:
>>> I know that Dave asked for this but I really don't see the need to add
>>> this much machinery. ?I think this is a lot of work to go to for
>>> something that is run infrequently and which is usually just clicked
>>> through. ?For othe
On Thu, May 14, 2009 at 08:01:52AM -0400, Jonathon Merz wrote:
>I just took another look at the GNU coding standards and think I see
>better what is required now.
Again, he setup sources don't all conform to GNU coding style. This is
very unfortunate but what you should be doing is adapting to th
Thrall, Bryan wrote:
One additional feature that might be useful is a command
line switch that allows a search through the package list
that puts out a list of matches.
Think of it as a grep through setup.ini
You mean like 'cygcheck -p '?
No, not quite. If I do something like:
cygcheck -
Ralph Hempel wrote on Thursday, May 14, 2009 7:06 AM:
> Christopher Faylor wrote:
>
>>> And some of us just run setup from the command line and never even
>>> bother with the GUI until it has run to completion
>>
>> There's that too. I am hoping to make that even more convenient
>> eventuall
Christopher Faylor wrote:
And some of us just run setup from the command line and never even
bother with the GUI until it has run to completion
There's that too. I am hoping to make that even more convenient
eventually. I'd like to get rid of all remnants of the GUI when
-q (or some othe
It seems unclear (unlikely?) that this feature is definitely wanted,
but on the chance that it is, responses to comments below:
On Wed, May 13, 2009 at 10:23 PM, Christopher Faylor wrote:
> Thanks for the patch but since you asked, I don't understand why you
> chose to add so many new files and so
On Wed, May 13, 2009 at 11:01:34PM -0400, Ralph Hempel wrote:
> Christopher Faylor wrote:
>>I know that Dave asked for this but I really don't see the need to add
>>this much machinery. I think this is a lot of work to go to for
>>something that is run infrequently and which is usually just clicke
Christopher Faylor wrote:
I know that Dave asked for this but I really don't see the need to add
this much machinery. I think this is a lot of work to go to for
something that is run infrequently and which is usually just clicked
through. For other installers, people just seem to live with wha
On Wed, May 13, 2009 at 09:59:38PM -0400, Jonathon Merz wrote:
>Hello,
>
>Per Dave Korn's suggestion in:
> http://cygwin.com/ml/cygwin/2009-05/msg00208.html
>
>I've put together a preliminary patch to make setup.exe restore it's
>last used size and position when it starts. What I've got so far i
Hello,
Per Dave Korn's suggestion in:
http://cygwin.com/ml/cygwin/2009-05/msg00208.html
I've put together a preliminary patch to make setup.exe restore it's
last used size and position when it starts. What I've got so far is:
- setup.exe reads it's last used size, position, and
maximized/n
Christopher Faylor wrote:
> If you are talking about the commenting out of psd.hasMinRect = true;
> then it looks like that was unintentional.
Yep, that's exactly what I meant.
> Looks good. Thanks.
Thanks, I shall commit it.
cheers,
DaveK
On Fri, Apr 24, 2009 at 08:31:23PM +0100, Dave Korn wrote:
>Dave Korn wrote:
>> So here's an updated and retested version of the patch done under the
>> assumption that reverting that change will be acceptable; if not, I can find
>> a
>> different way of doing it. Ok for head?
>
> Doh, no, obv
On Fri, Apr 24, 2009 at 08:30:36PM +0100, Dave Korn wrote:
>
> Prompted by Marcio (thanks!), I went back to the setup.exe filter search
> patch.
>
> The one outstanding issue, you may remember, was the need to set a minimum
>size for the setup dialog, to prevent horrible ugliness when the contro
Dave Korn wrote:
> So here's an updated and retested
and corrected!
> version of the patch done under the assumption that reverting that change
> will be acceptable; if not, I can find a different way of doing it. Ok for
> head?
2009-04-24 Andrew Punch
* PickView.h: Add #includ
Dave Korn wrote:
> So here's an updated and retested version of the patch done under the
> assumption that reverting that change will be acceptable; if not, I can find a
> different way of doing it. Ok for head?
Doh, no, obviously not, I left a bunch of debugging in. Hang on ten
minutes, I'l
Prompted by Marcio (thanks!), I went back to the setup.exe filter search
patch.
The one outstanding issue, you may remember, was the need to set a minimum
size for the setup dialog, to prevent horrible ugliness when the controls
overdrew each other or went outside the client area.
On inve
Andrew Punch wrote:
> So would you like me to do the tooltip, alignment and label - or would
> you prefer to do it?
Sorry if that wasn't clear; I already added it in the reformatted version of
your patch attached to my last message!
cheers,
DaveK
Dave Korn wrote:
Dave Korn wrote:
Andrew Punch wrote:
Hi,
I have attached a patch for searching packages in the package selection
screen. The patch is against version 2.573.2.3 - I couldn't get the CVS
head to build due to a libtool version problem.
Thanks for contributing th
On Apr 1 16:50, Dave Korn wrote:
> One consequence of doing this is that it draws attention to the fact we need
> to implement minimum window size dimensions for the chooser page; it's bad
> enough that you can shrink it down far enough that controls slide off the
> left-hand edge, but it looks
Dave Korn wrote:
> Dave Korn wrote:
>> Andrew Punch wrote:
>>> Hi,
>>>
>>> I have attached a patch for searching packages in the package selection
>>> screen. The patch is against version 2.573.2.3 - I couldn't get the
>>> CVS head to build due to a libtool version problem.
>> Thanks for contribu
Christopher Faylor wrote:
>
> Please don't submit this. I'll fix the problem but not this way.
Okeydokey, cancelled, NP :)
cheers,
DaveK
On Wed, Apr 01, 2009 at 12:54:53PM +0100, Dave Korn wrote:
>
>Hi gang,
>
> AttachConsole (added recently for stdout/stderr handling) doesn't exist on
>win2k, having been introduced in xp/2k3, so setup HEAD currently doesn't run
>there.
>
> The attached patch fixes the load-time problem by add
Dave Korn wrote:
> Andrew Punch wrote:
>> Hi,
>>
>> I have attached a patch for searching packages in the package selection
>> screen. The patch is against version 2.573.2.3 - I couldn't get the CVS
>> head to build due to a libtool version problem.
>
> Thanks for contributing this. I'm current
Hi gang,
AttachConsole (added recently for stdout/stderr handling) doesn't exist on
win2k, having been introduced in xp/2k3, so setup HEAD currently doesn't run
there.
The attached patch fixes the load-time problem by adding an autoload. That
won't prevent the run-time crash if the func
Andrew Punch wrote:
> Hi,
>
> I have attached a patch for searching packages in the package selection
> screen. The patch is against version 2.573.2.3 - I couldn't get the CVS
> head to build due to a libtool version problem.
Thanks for contributing this. I'm currently up-porting it to CVS HEA
Hi,
I have attached a patch for searching packages in the package selection
screen. The patch is against version 2.573.2.3 - I couldn't get the CVS
head to build due to a libtool version problem.
The features of the patch are as follows:
* In the "Select Packages" screen I added a new edit bo
EMAIL PROTECTED]
Sent: woensdag 28 mei 2008 12:06
To: Servaas Goossens
Cc: cygwin-apps@cygwin.com
Subject: Re: [PATCH] - setup.exe --text-mode and
--current-user-only options
Servaas Goossens wrote:
Please consider the following patch to setup. (I tried to follow the
patch submission gui
1 - 100 of 122 matches
Mail list logo
