Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-27 Thread Brian Inglis via Cygwin-apps
On 2023-04-27 10:11, Jon Turney via Cygwin-apps wrote: On 24/04/2023 19:16, Achim Gratz via Cygwin-apps wrote: Corinna Vinschen via Cygwin-apps writes: Calm could create a database containing all the files from the tar archives it uploads, and compare that against the newly uploaded files on th

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-27 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: ... Using std::set_intersection() on values from std::map() here is probably a mistake. It's simple to write, but the performance is not good. A faster alternative which avoids set_intersection calls in a loop is possibly to use one large data structure which maps filenames

Re: [PATCH setup 0/2] Detect filename collisions between packages

2023-04-27 Thread Jon Turney via Cygwin-apps
On 24/04/2023 19:16, Achim Gratz via Cygwin-apps wrote: Corinna Vinschen via Cygwin-apps writes: Calm could create a database containing all the files from the tar archives it uploads, and compare that against the newly uploaded files on the fly. That already exists as the basis for package gr

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-27 Thread Jon Turney via Cygwin-apps
On 24/04/2023 17:26, Christian Franke via Cygwin-apps wrote: Jon Turney via Cygwin-apps wrote: Detect filename collisions between packages Don't check filenames under /etc/postinstall/ for collisions Report when filename collisions exist Add option '--collisions' to enable IMO a useful enhance