Re: support dirent.d_type

2005-04-23 Thread Igor Pechtchanski
On Fri, 22 Apr 2005, Christopher Faylor wrote: > On Fri, Apr 22, 2005 at 11:37:59AM -0400, Igor Pechtchanski wrote: > >On Fri, 22 Apr 2005, lode leroy wrote: > >>I would like to see support for dirent.d_type added to cygwin. > >> > >>fhandler_disk_file::readdir() > >>{ > >>... > >> if (buf.dwFileA

Re: support dirent.d_type

2005-04-23 Thread Corinna Vinschen
On Apr 23 07:36, Eric Blake wrote: > But there are a number of applications out there that behave more > efficiently if d_ino/d_type ARE properly implemented. For example, both > coreutils and findutils are smart enough to avoid extra [l]stat()s on > systems with working d_type when traversing dir

Re: support dirent.d_type

2005-04-23 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Christopher Faylor on 4/22/2005 11:06 AM: > Actually, thanks but I don't think we want to go down this path. > > Properly implementing this field would introduce the same problems as > properly implementing d_ino. Doing this would mean a

Re: support dirent.d_type

2005-04-23 Thread Christopher Faylor
On Fri, Apr 22, 2005 at 11:37:59AM -0400, Igor Pechtchanski wrote: >On Fri, 22 Apr 2005, lode leroy wrote: >>I would like to see support for dirent.d_type added to cygwin. >> >>fhandler_disk_file::readdir() >>{ >>... >> if (buf.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) { >> dir->__d_dirent->d_

Re: support dirent.d_type

2005-04-23 Thread Igor Pechtchanski
On Fri, 22 Apr 2005, lode leroy wrote: > Hello, > > I would like to see support for dirent.d_type added to cygwin. > > fhandler_disk_file::readdir() > { > ... > if (buf.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) { >dir->__d_dirent->d_type = DT_DIR; > } else { >dir->__d_dirent->d_type =

support dirent.d_type

2005-04-22 Thread lode leroy
Hello, I would like to see support for dirent.d_type added to cygwin. fhandler_disk_file::readdir() { ... if (buf.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) { dir->__d_dirent->d_type = DT_DIR; } else { dir->__d_dirent->d_type = DT_REG; } ... }