Re: rebase-0.4 patch

2002-12-06 Thread Jason Tishler
Chris, On Wed, Dec 04, 2002 at 04:02:46PM -0500, Christopher Faylor wrote: > On Thu, Dec 05, 2002 at 05:57:41PM +1100, Robert Collins wrote: > >I suggest an independent module in cygwin-apps CVS repository. > > You have write permission in the cygwin-apps repository, Jason, if > you want to creat

RE: rebase-0.4 patch

2002-12-05 Thread Ralf Habacker
> On Thu, Dec 05, 2002 at 08:44:37PM +1100, Robert Collins wrote: > > On Thu, 2002-12-05 at 19:50, Ralf Habacker wrote: > > > astyle --gnu does not work. It must be astyle --style=gnu. > > > > > > What about spaces and tabs. Tabs would make big files smaller as > > > using tabs, but the problem is

Re: rebase-0.4 patch

2002-12-05 Thread Jason Tishler
Ralf, On Thu, Dec 05, 2002 at 08:44:37PM +1100, Robert Collins wrote: > On Thu, 2002-12-05 at 19:50, Ralf Habacker wrote: > > astyle --gnu does not work. It must be astyle --style=gnu. > > > > What about spaces and tabs. Tabs would make big files smaller as > > using tabs, but the problem is with

RE: rebase-0.4 patch

2002-12-05 Thread Robert Collins
On Thu, 2002-12-05 at 19:43, Ralf Habacker wrote: > BTW: What means FWICT, I haven't found an explanation of this in google. >From What I Can Tell. -- --- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. --- signature.asc Description: This is a digitally signed message par

RE: rebase-0.4 patch

2002-12-05 Thread Robert Collins
On Thu, 2002-12-05 at 19:50, Ralf Habacker wrote: > astyle --gnu does not work. It must be astyle --style=gnu. > > What about spaces and tabs. Tabs would make big files smaller as using tabs, but > the problem is with the indention, which isn't equal for all users and all > editors. For example I

RE: rebase-0.4 patch

2002-12-05 Thread Ralf Habacker
> > However for C++, astyle --gnu does a better job of > meeting the GNU standards, FWICT. > $ astyle --gnu Unknown command line option: gnu For help on options, type 'astyle -h' astyle --gnu does not work. It must be astyle --style=gnu. What about spaces and tabs. Tabs would make big files small

RE: rebase-0.4 patch

2002-12-05 Thread Ralf Habacker
> > > 3. reformat via indent > > > > Which indent command line you will use. I can do it before, do simplifiy > > applying backward to the kde-cygwin archive. > > Just 'indent'. However for C++, astyle --gnu does a better job of > meeting the GNU standards, FWICT. > There are two possibilites.

RE: rebase-0.4 patch

2002-12-05 Thread Robert Collins
On Thu, 2002-12-05 at 19:15, Ralf Habacker wrote: > > 3. reformat via indent > > Which indent command line you will use. I can do it before, do simplifiy > applying backward to the kde-cygwin archive. Just 'indent'. However for C++, astyle --gnu does a better job of meeting the GNU standard

RE: rebase-0.4 patch

2002-12-05 Thread Ralf Habacker
> -Original Message- > From: Jason Tishler [mailto:[EMAIL PROTECTED]] > Sent: Wednesday, December 04, 2002 9:42 PM > To: Ralf Habacker > Cc: Cygwin > Subject: Re: rebase-0.4 patch > > > Ralf, > > On Wed, Dec 04, 2002 at 07:45:52AM +0100, Ralf Habacke

Re: rebase-0.4 patch

2002-12-04 Thread Christopher Faylor
On Thu, Dec 05, 2002 at 05:57:41PM +1100, Robert Collins wrote: >On Thu, 2002-12-05 at 07:41, Jason Tishler wrote: >>>What about the final cvs archive. Where will this code live ? >> >>I've been assuming somewhere in the Cygwin and/or setup.exe source >>trees. > >I suggest an independent module in

Re: rebase-0.4 patch

2002-12-04 Thread Robert Collins
On Thu, 2002-12-05 at 07:41, Jason Tishler wrote: > > What about the final cvs archive. Where will this code live ? > > I've been assuming somewhere in the Cygwin and/or setup.exe source > trees. I suggest an independent module in cygwin-apps CVS repository. Rob -- --- GPG key available at: htt

Re: rebase-0.4 patch

2002-12-04 Thread Jason Tishler
Ralf, On Wed, Dec 04, 2002 at 07:45:52AM +0100, Ralf Habacker wrote: > > Are you willing to accept these changes -- in particular, #2? > > I've applied this patches to the kde-cygwin sources. Thanks. Have you committed them to CVS yet? (So I can patch against the latest source). > Feel free t

rebase-0.4 patch

2002-12-03 Thread Jason Tishler
Ralf, The attached patch changes your version of rebase as follows: 1. Round NewImageSize (to the nearest 0x1) to be consistent with MS's rebase. 2. Fix bug when rebasing up. Are you willing to accept these changes -- in particular, #2? If so, then I would like to offer the f