Re: missing definition of __STRING macro in standard cygwin headers

2007-03-03 Thread Pedro Alves
Brian Dessent wrote: Pedro Alves wrote: It wouldn't work. #define __STRING #x != #define __STRING(x) #x I am just quoting what the OP said, which was: What the web link basically says that cygwin doesn't have #define __STRING #x defined in any of the standard header files which means some

Re: missing definition of __STRING macro in standard cygwin headers

2007-03-03 Thread Brian Dessent
Pedro Alves wrote: > It wouldn't work. > #define __STRING #x != #define __STRING(x) #x I am just quoting what the OP said, which was: > What the web link basically says that cygwin doesn't have > #define __STRING #x > defined in any of the standard header files which means some source code I h

Re: missing definition of __STRING macro in standard cygwin headers

2007-03-03 Thread Pedro Alves
Brian Dessent wrote: Eric Blake wrote: Not to mention the fact that it's incredibly silly to rely on libc headers to define something as trivial as the stringify operator which is a standard part of the C language. Does it also require __COMMENTBEGIN to be defined as /*? __BRACEBEGIN as {? Why

Re: missing definition of __STRING macro in standard cygwin headers

2007-03-03 Thread Brian Dessent
Eric Blake wrote: > Then that's a bug in FAAC. Using any identifier in the __ namespace is > admitting that your code is relying on implementation details, and it > deserves to break when ported to a different implementation. > > That said, submit a patch, and it will probably be applied, since

Re: missing definition of __STRING macro in standard cygwin headers

2007-03-03 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jaakko Pääkkönen on 3/3/2007 3:08 AM: > Hi > Shouldn't this be fixed in cygwin headers? > http://www.audiocoding.com/modules/newbb/viewtopic.php?topic_id=448&forum=3 > > What the web link basically says that cygwin doesn't have > #defin

Re: missing definition of __STRING macro in standard cygwin headers

2007-03-03 Thread Christopher Faylor
On Sat, Mar 03, 2007 at 12:08:50PM +0200, Jaakko P??kk?nen wrote: >...cygwin doesn't have >#define __STRING #x >defined in any of the standard header files which means some source code >won't compile out of the box (FAAC library in this case). Hacking up all the >software by inserting that bit int