Re: Patch for run-1.3.0-1 core dump

2014-06-09 Thread Patrick Herbst
>> >> On 3/20/2014 8:57 AM, Patrick Herbst wrote: >> >>> On 2/18/2014 4:16 AM, Corinna Vinschen wrote: >>> Did my earlier patch get included? I haven't seen a "run" new version >>> yet. >>> >>> http://www.cygwin.com/ml/cygwin/2013-12/msg6.html >>> >>> My patch was the one that properly quote a

Re: Patch for run-1.3.0-1 core dump

2014-03-20 Thread Max Polk
On 3/20/2014 8:57 AM, Patrick Herbst wrote: On 2/18/2014 4:16 AM, Corinna Vinschen wrote: Did my earlier patch get included? I haven't seen a "run" new version yet. http://www.cygwin.com/ml/cygwin/2013-12/msg6.html My patch was the one that properly quote arguments. Maybe let's start with

Re: Patch for run-1.3.0-1 core dump

2014-03-20 Thread Patrick Herbst
> On 2/18/2014 4:16 AM, Corinna Vinschen wrote: > Did my earlier patch get included? I haven't seen a "run" new version > yet. > > http://www.cygwin.com/ml/cygwin/2013-12/msg6.html > > My patch was the one that properly quote arguments. Maybe let's start > with that before putting new stuff u

Re: Patch for run-1.3.0-1 core dump

2014-02-19 Thread Max Polk
On 2/18/2014 4:16 AM, Corinna Vinschen wrote: On Feb 17 17:25, Jon TURNEY wrote: ... I went to all the trouble of investigating this, discovering that run2_freeargv() is double-freeing the last element in newargv because the NULL terminator isn't moved when the arguments are shifted down over ne

Re: Patch for run-1.3.0-1 core dump

2014-02-18 Thread Corinna Vinschen
On Feb 18 10:05, Corinna Vinschen wrote: > Hi Jon, > Hi Chuck, > > On Feb 17 17:25, Jon TURNEY wrote: > > On 12/08/2013 15:22, Charles Wilson wrote: > > > On 8/10/2013 1:34 PM, foo wrote: > > >> Whenever I execute run.exe, it generates run.exe.stackdump. > > >> > > >> At line 370 in run.c, run2_fr

Re: Patch for run-1.3.0-1 core dump

2014-02-18 Thread Corinna Vinschen
Hi Jon, Hi Chuck, On Feb 17 17:25, Jon TURNEY wrote: > On 12/08/2013 15:22, Charles Wilson wrote: > > On 8/10/2013 1:34 PM, foo wrote: > >> Whenever I execute run.exe, it generates run.exe.stackdump. > >> > >> At line 370 in run.c, run2_freeargv() tries to free newargv, and > >> run2_freeqrgv() ex

Re: Patch for run-1.3.0-1 core dump

2014-02-17 Thread Charles Wilson
On 2/17/2014 12:25 PM, Jon TURNEY wrote: Since I've been running with CYGWIN error_start always set at the moment, I've noticed that run is always crashing after launching the process. I went to all the trouble of investigating this, discovering that run2_freeargv() is double-freeing the last el

Re: Patch for run-1.3.0-1 core dump

2014-02-17 Thread Jon TURNEY
On 12/08/2013 15:22, Charles Wilson wrote: > On 8/10/2013 1:34 PM, foo wrote: >> Whenever I execute run.exe, it generates run.exe.stackdump. >> >> At line 370 in run.c, run2_freeargv() tries to free newargv, and >> run2_freeqrgv() expects that newargv is terminated by NULL. However, >> in shifting

Re: Patch for run-1.3.0-1 core dump

2013-08-12 Thread Charles Wilson
On 8/10/2013 1:34 PM, foo wrote: Whenever I execute run.exe, it generates run.exe.stackdump. At line 370 in run.c, run2_freeargv() tries to free newargv, and run2_freeqrgv() expects that newargv is terminated by NULL. However, in shifting newargv at line 253-256, it fails to shift NULL terminato