Re: [PATCH] Fix optional variables in libargp

2022-02-18 Thread Andrew Schulman via Cygwin
> Hello! > I have successfully tested it on i386. Really, just remove PREFIX > completely and it's okay. GetProcAddress() appears to be "clever" and adds > the leading underscope by itself on i386. I don't know what you did wrong > and why you could not reproduce the solution. > However, i have

RE: [PATCH] Fix optional variables in libargp

2013-07-23 Thread Pavel Fedin
Hello! > Sorry, this was my fault. I accidentally mangled your patch when I > took PREFIX out. I fixed that, and it works fine in x86 now. Good. Please don't forget that packages which make use of libargp (if there are any) have to be recompiled against new argp.h in order to take advantage

Re: [PATCH] Fix optional variables in libargp

2013-07-23 Thread Andrew Schulman
> Hello! > I have successfully tested it on i386. Really, just remove PREFIX > completely and it's okay. GetProcAddress() appears to be "clever" and adds > the leading underscope by itself on i386. I don't know what you did wrong > and why you could not reproduce the solution. > However, i have

RE: [PATCH] Fix optional variables in libargp

2013-07-22 Thread Pavel Fedin
Hello! I have successfully tested it on i386. Really, just remove PREFIX completely and it's okay. GetProcAddress() appears to be "clever" and adds the leading underscope by itself on i386. I don't know what you did wrong and why you could not reproduce the solution. However, i have one idea. Af

RE: [PATCH] Fix optional variables in libargp

2013-07-22 Thread Pavel Fedin
Hello! > So at this point your patch doesn't work in x86 for me. I'd appreciate > it if someone else could test it, or suggest a modification to make it > work. Ok, i'll test it myself. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- Problem reports:

Re: [PATCH] Fix optional variables in libargp

2013-07-21 Thread Andrew Schulman
> I have tested the implementation on x86-64 with RedHat's Prelink utility, > and it works quite fine. i386 should work too, but please retest, just in > case. Fedin, thanks for sending this. I've tested it for x86_64, and it works there. However in x86, in my testing I can't get it to work. I

Re: [PATCH] Fix optional variables in libargp

2013-07-17 Thread Eric Blake
On 07/17/2013 12:32 AM, Fedin Pavel wrote: > Hello! > >> Okay, well I agree that this sounds like a good solution. For now you >> have a workaround, and I'll be glad to consider a patch if you submit >> one. > > Please take it. This is my experimental implementation which appears to be > simpl