Re: Cygwin crashes in kill_pgrp, _pinfo truncation issue.

2012-09-17 Thread Andrey Khalyavin
2012/8/23 Andrey Khalyavin wrote: > > I got two more crash dumps from our bots running 20120816 snapshot. > Both of them crashed in this place. process_state equals to > PID_IN_USE | PIE_EXECED and your new check in _pinfo::exist is really there. > So the race condition on process_state field does

Re: Cygwin crashes in kill_pgrp, _pinfo truncation issue.

2012-08-23 Thread Andrey Khalyavin
On Wed, 15 Aug 2012 10:11:16 -0400, Christopher Faylor wrote: >On Wed, Aug 15, 2012 at 04:54:42PM +0400, Andrey Khalyavin wrote: >>I finally got a cygwin crash dump from our build bots. It shows, that >>cygwin1.dll crashes in kill_pgrp function on line: >>(pid > 1 && p->pgid != pid) || >>wh

Re: Cygwin crashes in kill_pgrp, _pinfo truncation issue.

2012-08-16 Thread Christopher Faylor
On Thu, Aug 16, 2012 at 08:20:37PM +0400, Andrey Khalyavin wrote: >On Wed, 15 Aug 2012 10:11:16 -0400, Christopher Faylor wrote: >>On Wed, Aug 15, 2012 at 04:54:42PM +0400, Andrey Khalyavin wrote: >>>I finally got a cygwin crash dump from our build bots. It shows, that >>>cygwin1.dll crashes in kil

Re: Cygwin crashes in kill_pgrp, _pinfo truncation issue.

2012-08-16 Thread Andrey Khalyavin
On Wed, 15 Aug 2012 10:11:16 -0400, Christopher Faylor wrote: >On Wed, Aug 15, 2012 at 04:54:42PM +0400, Andrey Khalyavin wrote: >>I finally got a cygwin crash dump from our build bots. It shows, that >>cygwin1.dll crashes in kill_pgrp function on line: >>(pid > 1 && p->pgid != pid) || >>wh

Re: Cygwin crashes in kill_pgrp, _pinfo truncation issue.

2012-08-15 Thread Christopher Faylor
On Wed, Aug 15, 2012 at 04:54:42PM +0400, Andrey Khalyavin wrote: >I finally got a cygwin crash dump from our build bots. It shows, that >cygwin1.dll crashes in kill_pgrp function on line: > (pid > 1 && p->pgid != pid) || >where p is a pointer to _pinfo. This function enumerates all _pinfo'

Cygwin crashes in kill_pgrp, _pinfo truncation issue.

2012-08-15 Thread Andrey Khalyavin
I finally got a cygwin crash dump from our build bots. It shows, that cygwin1.dll crashes in kill_pgrp function on line: (pid > 1 && p->pgid != pid) || where p is a pointer to _pinfo. This function enumerates all _pinfo's and executes this line for all of them which pass p->exists() check