Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-20 Thread Corinna Vinschen
On Jul 17 21:33, Marc Hoersken via Cygwin wrote: > Hi Corinna, > > Am 17.07.2020 um 21:21 schrieb Corinna Vinschen: > > I don't agree here. The sole purpose for connect_errorcode is to set > > SOL_SOCKET/SO_ERROR in case a caller requests FD_CONNECT and FD_CONNECT > > is available. After being s

Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-17 Thread Marc Hoersken via Cygwin
Hi Corinna, Am 17.07.2020 um 21:21 schrieb Corinna Vinschen: I don't agree here. The sole purpose for connect_errorcode is to set SOL_SOCKET/SO_ERROR in case a caller requests FD_CONNECT and FD_CONNECT is available. After being set once, SOL_SOCKET/SO_ERROR should not be rewritten, given the d

Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-17 Thread Corinna Vinschen
Hi Marc, On Jul 17 20:56, Marc Hoersken via Cygwin wrote: > Hi Corinna, > > Am 16.07.2020 um 11:25 schrieb Corinna Vinschen: > [...] > > So, rather than setting FD_WRITE at some later point in the code, what > > about handling this where the other FD_CONNECT stuff is handled, by > > not erasing t

Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-17 Thread Marc Hoersken via Cygwin
Hi Corinna, Am 16.07.2020 um 11:25 schrieb Corinna Vinschen: Thanks for the patch. I pushed it. thanks for pushing it already. Please excuse my delayed response, family live kept me busy. But then I got second thoughts in terms of how to fix the issue. Yes, I also got second thoughts

Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-16 Thread Corinna Vinschen
Hi Marc, On Jul 15 20:54, Marc Hoersken via Cygwin wrote: > Hello everyone, > > I identified an issue related to the way the events FD_CONNECT and FD_CLOSE > returned by WSAEnumNetworkEvents are currently handled in > winsup/cygwin/fhandler_socket_inet.cc. > > It seems like the code does not han

[PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-15 Thread Marc Hoersken via Cygwin
Hello everyone, I identified an issue related to the way the events FD_CONNECT and FD_CLOSE returned by WSAEnumNetworkEvents are currently handled in winsup/cygwin/fhandler_socket_inet.cc. It seems like the code does not handle the fact that those events are returned only once for a socket a